Ingo Molnar
2055da9738
sched/wait: Disambiguate wq_entry->task_list and wq_head->task_list naming ...
So I've noticed a number of instances where it was not obvious from the
code whether ->task_list was for a wait-queue head or a wait-queue entry.
Furthermore, there's a number of wait-queue users where the lists are
not for 'tasks' but other entities (poll tables, etc.), in which case
the 'task_list' name is actively confusing.
To clear this all up, name the wait-queue head and entry list structure
fields unambiguously:
struct wait_queue_head::task_list => ::head
struct wait_queue_entry::task_list => ::entry
For example, this code:
rqw->wait.task_list.next != &wait->task_list
... is was pretty unclear (to me) what it's doing, while now it's written this way:
rqw->wait.head.next != &wait->entry
... which makes it pretty clear that we are iterating a list until we see the head.
Other examples are:
list_for_each_entry_safe(pos, next, &x->task_list, task_list) {
list_for_each_entry(wq, &fence->wait.task_list, task_list) {
... where it's unclear (to me) what we are iterating, and during review it's
hard to tell whether it's trying to walk a wait-queue entry (which would be
a bug), while now it's written as:
list_for_each_entry_safe(pos, next, &x->head, entry) {
list_for_each_entry(wq, &fence->wait.head, entry) {
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2017-06-20 12:19:14 +02:00
2017-03-21 06:44:33 +01:00
2015-04-17 09:04:02 -04:00
2016-12-25 17:21:22 +01:00
2017-04-03 18:01:34 +02:00
2017-03-09 01:32:35 +01:00
2015-09-05 13:19:05 +02:00
2014-10-20 16:21:31 +02:00
2015-04-03 08:18:25 +02:00
2015-11-08 14:12:25 +01:00
2015-09-05 13:19:08 +02:00
2016-07-19 17:27:42 +02:00
2016-09-22 00:14:41 +02:00
2017-02-21 23:21:30 +01:00
2016-03-14 17:08:25 +01:00
2016-10-19 08:45:48 +02:00
2016-09-02 01:24:06 +02:00
2015-11-08 14:12:28 +01:00
2013-04-05 09:36:53 -07:00
2016-07-26 00:09:18 +02:00
2017-01-11 17:23:06 +01:00
2017-01-11 17:23:06 +01:00
2017-03-09 01:29:17 +01:00
2014-10-20 16:21:31 +02:00
2017-05-22 20:32:05 +02:00
2016-09-02 01:24:06 +02:00
2017-03-21 06:44:33 +01:00
2017-04-14 12:08:52 +02:00
2016-07-19 18:15:21 +02:00
2016-07-19 18:15:21 +02:00
2016-01-11 20:19:57 +01:00
2016-09-02 01:24:06 +02:00
2017-03-21 06:44:33 +01:00
2016-09-02 01:24:06 +02:00
2017-01-11 17:23:06 +01:00
2016-05-20 12:33:51 +02:00
2016-07-08 16:23:11 +02:00
2016-09-02 01:24:06 +02:00
2016-07-09 10:24:45 +02:00
2017-04-14 12:08:53 +02:00
2016-07-09 10:24:45 +02:00
2016-09-22 00:14:40 +02:00
2017-05-04 14:46:25 +02:00
2015-11-10 10:01:21 -08:00
2016-05-20 12:33:51 +02:00
2016-05-20 12:33:51 +02:00
2017-03-09 01:29:24 +01:00
2016-07-09 10:24:45 +02:00
2016-05-20 12:33:51 +02:00
2016-06-27 10:48:28 +02:00
2017-03-09 01:29:23 +01:00
2015-04-17 09:04:02 -04:00
2016-06-06 17:07:33 +02:00
2015-04-17 09:03:59 -04:00
2016-05-20 12:33:51 +02:00
2015-09-05 13:19:06 +02:00
2017-05-05 00:43:52 +02:00
2016-06-04 00:23:35 +02:00
2017-04-22 17:56:18 +02:00
2016-07-19 18:18:06 +02:00
2017-06-20 12:19:14 +02:00
2017-03-09 01:29:27 +01:00
2016-05-20 12:33:51 +02:00
2017-01-26 23:03:21 +01:00
2016-11-04 23:31:29 +01:00
2014-10-20 16:21:31 +02:00
2015-09-05 13:19:06 +02:00
2016-01-11 20:19:59 +01:00
2017-01-11 17:23:06 +01:00
2017-04-19 22:05:48 +02:00
2015-10-28 10:30:17 +09:00
2015-10-28 10:30:17 +09:00
2016-05-20 12:33:51 +02:00
2015-09-05 13:19:10 +02:00
2017-02-21 21:23:13 +01:00
2016-05-20 12:33:51 +02:00
2015-10-28 10:30:17 +09:00
2016-06-04 16:05:59 +02:00
2014-10-20 16:21:31 +02:00
2014-10-20 16:21:31 +02:00
2015-09-05 19:37:21 +02:00
2015-06-25 01:13:36 +02:00
2016-03-14 17:08:27 +01:00
2016-05-20 12:33:51 +02:00
2016-06-26 01:20:08 +02:00
2017-01-11 17:23:04 +01:00
2015-09-05 19:37:22 +02:00
2015-09-05 19:37:22 +02:00
2016-07-09 10:24:45 +02:00
2015-04-17 09:04:02 -04:00
2016-09-02 01:24:06 +02:00
2015-09-05 19:37:22 +02:00
2017-01-11 17:23:06 +01:00
2016-09-02 01:24:06 +02:00
2017-03-09 01:32:32 +01:00
2016-06-29 17:33:18 +10:00
2016-09-02 01:24:06 +02:00
2014-10-20 16:21:31 +02:00
2016-08-31 18:21:34 +02:00
2017-02-23 18:38:54 +01:00
2016-03-14 17:08:30 +01:00
2016-07-19 18:15:21 +02:00
2015-09-05 13:19:06 +02:00
2016-09-02 01:24:06 +02:00
2016-11-04 23:08:59 +01:00
2016-08-31 18:21:35 +02:00
2013-11-13 12:09:31 +09:00
2015-11-08 14:12:24 +01:00
2016-08-31 09:33:33 +01:00
2016-01-11 20:19:55 +01:00
2014-10-20 16:21:31 +02:00
2014-10-20 16:21:31 +02:00
2015-09-05 19:37:16 +02:00
2016-12-19 00:59:21 +01:00
2015-10-28 10:30:17 +09:00
2016-07-19 18:15:21 +02:00
2015-12-20 13:39:00 +01:00
2015-09-05 13:19:10 +02:00
2016-05-20 12:33:51 +02:00
2016-05-20 12:33:51 +02:00
2017-03-09 01:29:34 +01:00
2017-03-09 01:29:16 +01:00
2017-03-09 01:29:14 +01:00
2015-10-28 10:30:17 +09:00
2016-09-02 01:24:06 +02:00
2017-03-09 01:29:21 +01:00
2016-09-02 01:24:06 +02:00
2017-03-09 01:29:31 +01:00
2016-07-19 17:48:06 +02:00
2013-04-19 13:51:25 +02:00
2016-03-14 17:08:18 +01:00
2017-03-09 01:29:29 +01:00
2015-09-05 19:37:16 +02:00
2015-09-05 19:37:16 +02:00
2017-04-22 18:01:15 +02:00
2015-09-05 13:19:06 +02:00
2017-05-05 00:43:50 +02:00
2016-09-02 01:24:06 +02:00
2015-07-23 17:07:35 +01:00
2016-11-04 23:31:31 +01:00
2016-05-20 12:33:51 +02:00
2017-01-23 00:47:15 +01:00
2016-09-02 01:24:06 +02:00
2016-11-04 23:31:33 +01:00
2017-02-12 00:34:31 +01:00
2016-01-11 20:19:57 +01:00
2016-08-31 18:21:35 +02:00
2017-01-23 00:46:55 +01:00
2015-04-03 08:18:24 +02:00
2014-10-20 16:21:31 +02:00
2016-05-21 17:07:17 +02:00
2017-01-10 01:32:51 +01:00
2016-03-14 17:08:24 +01:00
2016-11-30 21:21:33 +01:00
2015-09-05 13:19:10 +02:00
2016-07-09 10:24:21 +02:00
2016-03-14 17:08:25 +01:00
2015-09-05 19:37:22 +02:00
2013-07-03 16:07:59 -07:00
2017-03-16 22:59:54 +01:00
2016-05-20 12:33:51 +02:00
2014-10-20 16:21:31 +02:00
2016-05-20 12:33:51 +02:00
2015-06-25 01:13:42 +02:00
2055da9738