Joe Lawrence
6aa6caff30
[SCSI] scsi_transport_sas: move bsg destructor into sas_rphy_remove ...
The recent change in sysfs, bcdde7e221a8750f9b62b6d0bd31b72ea4ad9309
"sysfs: make __sysfs_remove_dir() recursive" revealed an asymmetric
rphy device creation/deletion sequence in scsi_transport_sas:
modprobe mpt2sas
sas_rphy_add
device_add A rphy->dev
device_add B sas_device transport class
device_add C sas_end_device transport class
device_add D bsg class
rmmod mpt2sas
sas_rphy_delete
sas_rphy_remove
device_del B
device_del C
device_del A
sysfs_remove_group recursive sysfs dir removal
sas_rphy_free
device_del D warning
where device A is the parent of B, C, and D.
When sas_rphy_free tries to unregister the bsg request queue (device D
above), the ensuing sysfs cleanup discovers that its sysfs group has
already been removed and emits a warning, "sysfs group... not found for
kobject 'end_device-X:0'".
Since bsg creation is a side effect of sas_rphy_add, move its
complementary removal call into sas_rphy_remove. This imposes the
following tear-down order for the devices above: D, B, C, A.
Note the sas_device and sas_end_device transport class devices (B and C
above) are created and destroyed both via the list match traversal in
attribute_container_device_trigger, so the order in which they are
handled is fixed. This is fine as long as they are deleted before their
parent device.
Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2014-05-22 15:54:03 -07:00
2014-03-19 15:04:44 -07:00
2014-03-19 15:04:44 -07:00
2013-06-04 11:15:59 -07:00
2014-03-15 10:19:19 -07:00
2014-03-19 15:04:44 -07:00
2014-04-01 19:19:15 -07:00
2014-03-19 15:04:47 -07:00
2014-04-07 14:55:46 -07:00
2014-04-07 14:55:46 -07:00
2013-11-15 16:47:22 -08:00
2014-03-15 10:19:18 -07:00
2013-10-25 11:19:33 +01:00
2014-03-19 15:04:44 -07:00
2014-03-20 13:43:45 +01:00
2013-11-15 16:47:22 -08:00
2014-03-19 15:04:44 -07:00
2014-03-15 10:19:17 -07:00
2013-09-04 13:52:35 -07:00
2014-04-01 18:49:04 -07:00
2014-03-15 10:18:58 -07:00
2014-03-15 10:19:21 -07:00
2014-04-28 07:49:25 -07:00
2014-01-30 11:19:05 -08:00
2013-10-14 15:26:04 +02:00
2013-11-23 22:33:47 -08:00
2013-04-09 14:13:21 -04:00
2014-03-19 15:04:44 -07:00
2014-04-12 16:51:08 -07:00
2014-03-15 10:19:18 -07:00
2014-04-12 18:02:16 -07:00
2013-11-15 16:47:22 -08:00
2013-11-29 08:48:39 +04:00
2013-11-29 08:48:39 +04:00
2013-11-29 08:48:39 +04:00
2013-01-03 15:57:01 -08:00
2013-11-26 11:09:07 +01:00
2013-11-26 11:09:07 +01:00
2013-11-26 11:09:07 +01:00
2013-10-25 11:44:54 +01:00
2014-03-19 15:04:44 -07:00
2013-04-09 14:13:23 -04:00
2013-04-09 14:13:29 -04:00
2014-03-10 21:15:09 +01:00
2013-04-09 14:13:29 -04:00
2013-10-14 15:26:04 +02:00
2013-10-25 09:57:57 +01:00
2013-06-26 18:32:47 -07:00
2013-01-03 15:57:01 -08:00
2013-02-27 19:10:18 -08:00
2013-07-09 22:52:29 +01:00
2013-11-15 16:47:22 -08:00
2013-01-03 15:57:01 -08:00
2013-10-25 11:40:42 +01:00
2013-10-25 11:36:26 +01:00
2014-03-19 15:04:44 -07:00
2013-04-09 14:13:17 -04:00
2014-03-19 15:04:44 -07:00
2014-03-19 15:04:44 -07:00
2013-08-01 18:08:34 -07:00
2013-08-01 18:08:34 -07:00
2013-01-03 15:57:01 -08:00
2013-06-26 18:32:47 -07:00
2014-03-19 15:04:44 -07:00
2013-04-09 14:13:16 -04:00
2013-04-09 14:13:16 -04:00
2014-03-19 15:04:44 -07:00
2013-04-09 14:13:16 -04:00
2013-11-26 11:09:07 +01:00
2014-03-15 10:18:59 -07:00
2014-03-15 10:19:23 -07:00
2014-04-21 07:56:53 -07:00
2014-03-15 10:19:23 -07:00
2013-01-03 15:57:01 -08:00
2012-11-27 08:59:43 +04:00
2013-04-09 14:13:16 -04:00
2014-03-19 15:04:44 -07:00
2014-03-19 15:04:44 -07:00
2014-04-01 19:19:15 -07:00
2014-03-19 15:04:42 -07:00
2013-11-29 08:48:39 +04:00
2013-04-09 14:13:27 -04:00
2014-03-15 10:19:19 -07:00
2014-04-11 16:15:36 -04:00
2014-04-11 16:15:36 -04:00
2013-01-03 15:57:01 -08:00
2014-04-10 15:30:35 -07:00
2013-01-03 15:57:01 -08:00
2014-03-15 10:19:18 -07:00
2014-04-03 16:57:19 -07:00
2013-01-03 15:57:01 -08:00
2013-12-19 20:56:28 -08:00
2013-04-09 14:13:17 -04:00
2013-12-19 07:39:02 -08:00
2014-03-27 08:26:31 -07:00
2014-03-27 08:26:31 -07:00
2013-01-03 15:57:01 -08:00
2013-04-09 14:13:15 -04:00
2013-10-14 15:26:04 +02:00
2013-04-15 14:30:44 -06:00
2013-10-14 15:31:06 +02:00
2014-03-19 15:04:44 -07:00
2013-04-09 14:13:17 -04:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-06-19 17:53:35 +02:00
2014-03-19 15:04:44 -07:00
2013-04-09 14:13:17 -04:00
2013-12-06 08:30:18 -08:00
2013-04-09 14:13:17 -04:00
2013-01-03 15:57:01 -08:00
2014-02-27 08:07:39 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2014-03-19 15:04:37 -07:00
2013-06-24 13:00:10 -07:00
2014-04-21 14:28:40 -07:00
2014-04-21 14:27:26 -07:00
2013-03-28 14:27:24 -04:00
2014-04-10 15:30:35 -07:00
2014-04-10 15:30:35 -07:00
2013-05-31 15:16:51 -04:00
2014-04-11 17:23:52 -07:00
2014-04-01 18:49:04 -07:00
2014-03-15 10:19:24 -07:00
2014-03-15 10:17:50 -07:00
2014-02-20 14:54:28 +01:00
2014-05-22 15:54:03 -07:00
2014-03-24 10:05:30 -07:00
2014-04-11 17:23:52 -07:00
2013-11-23 22:33:50 -08:00
2014-04-11 17:23:52 -07:00
2014-03-27 08:26:33 -07:00
2014-03-27 08:26:31 -07:00
2013-10-25 10:59:54 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-12-16 10:57:51 -08:00
2014-03-15 10:19:22 -07:00
2013-10-14 15:26:04 +02:00
2014-03-12 13:16:54 +04:00
2013-05-04 14:50:16 -04:00
2013-05-04 14:50:16 -04:00
2013-05-04 14:50:16 -04:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2014-03-19 15:04:44 -07:00
2013-04-09 14:13:17 -04:00
2013-11-15 16:47:22 -08:00
2013-10-25 11:51:37 +01:00
2014-03-19 15:04:44 -07:00
2014-04-28 16:16:08 -07:00
2014-03-19 15:04:46 -07:00
2014-03-19 15:04:46 -07:00
2013-04-09 14:13:15 -04:00
2013-04-09 14:13:15 -04:00
2014-03-19 15:04:44 -07:00
2013-01-03 15:57:01 -08:00
2013-11-26 11:09:07 +01:00
6aa6caff30