linux

mirror of https://github.com/FEX-Emu/linux.git synced 2025-02-02 09:05:51 +00:00

History

Heiko Carstens 264524d5e5 net: cpu offline cause napi stall

Frank Blaschka reported :
<quote>
  During heavy network load we turn off/on cpus.
  Sometimes this causes a stall on the network device.
  Digging into the dump I found out following:

  napi is scheduled but does not run. From the I/O buffers
  and the napi state I see napi/rx_softirq processing has stopped
  because the budget was reached. napi stays in the
  softnet_data poll_list and the rx_softirq was raised again.

  I assume at this time the cpu offline comes in,
  the rx softirq is raised/moved to another cpu but napi stays in the
  poll_list of the softnet_data of the now offline cpu.

  Reviewing dev_cpu_callback (net/core/dev.c) I did not find the
  poll_list is transfered to the new cpu.
</quote>

This patch is a straightforward implementation of Frank suggestion :

Transfert poll_list and trigger NET_RX_SOFTIRQ on new cpu.

Reported-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2011-06-07 01:01:22 -07:00

datagram.c

…

dev_addr_lists.c

net,rcu: convert call_rcu(ha_rcu_free) to kfree_rcu()

2011-05-07 22:50:52 -07:00

dev.c

net: cpu offline cause napi stall

2011-06-07 01:01:22 -07:00

drop_monitor.c

net,rcu: convert call_rcu(free_dm_hw_stat) to kfree_rcu()

2011-05-07 22:50:59 -07:00