Eric Biggers 72f9a07b6b KEYS: be careful with error codes in public_key_verify_signature() ...

In public_key_verify_signature(), if akcipher_request_alloc() fails, we
return -ENOMEM.  But that error code was set 25 lines above, and by
accident someone could easily insert new code in between that assigns to
'ret', which would introduce a signature verification bypass.  Make the
code clearer by moving the -ENOMEM down to where it is used.

Additionally, the callers of public_key_verify_signature() only consider
a negative return value to be an error.  This means that if any positive
return value is accidentally introduced deeper in the call stack (e.g.
'return EBADMSG' instead of 'return -EBADMSG' somewhere in RSA),
signature verification will be bypassed.  Make things more robust by
having public_key_verify_signature() warn about positive errors and
translate them into -EINVAL.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>

2017-12-08 15:13:29 +00:00

..

.gitignore

X.509: Add a crypto key parser for binary (DER) X.509 certificates

2012-10-08 13:50:22 +10:30

asymmetric_keys.h

KEYS: Generalise x509_request_asymmetric_key()

2016-04-11 22:41:56 +01:00

asymmetric_type.c

KEYS: checking the input id parameters before finding asymmetric key

2017-10-18 09:12:40 +01:00

Kconfig

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mscode_parser.c

pefile: Fix the failure of calculation for digest

2016-07-18 12:19:46 +10:00

mscode.asn1

pefile: Parse the "Microsoft individual code signing" data blob

2014-07-09 14:58:37 +01:00

pkcs7_key_type.c

pkcs7: Set the module licence to prevent tainting

2017-11-15 16:38:45 +00:00

pkcs7_parser.c

pkcs7: return correct error code if pkcs7_check_authattrs() fails

2017-12-08 15:13:28 +00:00

pkcs7_parser.h

PKCS#7: Handle blacklisted certificates

2017-04-03 16:07:25 +01:00

pkcs7_trust.c

pkcs7: fix check for self-signed certificate

2017-12-08 15:13:28 +00:00

pkcs7_verify.c

pkcs7: use crypto_shash_digest()

2017-12-08 15:13:28 +00:00

pkcs7.asn1

PKCS#7: Appropriately restrict authenticated attributes and content type

2015-08-12 17:01:01 +01:00

public_key.c

KEYS: be careful with error codes in public_key_verify_signature()

2017-12-08 15:13:29 +00:00

restrict.c

KEYS: Keyring asymmetric key restrict method with chaining

2017-04-04 14:10:13 -07:00

signature.c

KEYS: Add identifier pointers to public_key_signature struct

2016-04-06 16:13:33 +01:00

verify_pefile.c

crypto : asymmetric_keys : verify_pefile:zero memory content before freeing

2017-06-09 13:29:50 +10:00

verify_pefile.h

KEYS: Generalise system_verify_data() to provide access to internal content

2016-04-06 16:14:24 +01:00

x509_akid.asn1

X.509: Extract both parts of the AuthorityKeyIdentifier

2015-08-07 16:26:13 +01:00

x509_cert_parser.c

X.509: reject invalid BIT STRING for subjectPublicKey

2017-12-08 15:13:27 +00:00

x509_parser.h

X.509: Allow X.509 certs to be blacklisted

2017-04-03 16:07:25 +01:00

x509_public_key.c

pkcs7: Set the module licence to prevent tainting

2017-11-15 16:38:45 +00:00

x509.asn1

X.509: Add bits needed for PKCS#7

2014-07-01 16:40:19 +01:00