linux/fs/xfs/linux-2.6
Christoph Hellwig bc990f5cb4 xfs: fix locking in xfs_iget_cache_hit
The locking in xfs_iget_cache_hit currently has numerous problems:

 - we clear the reclaim tag without i_flags_lock which protects
   modifications to it
 - we call inode_init_always which can sleep with pag_ici_lock
   held (this is oss.sgi.com BZ #819)
 - we acquire and drop i_flags_lock a lot and thus provide no
   consistency between the various flags we set/clear under it

This patch fixes all that with a major revamp of the locking in
the function.  The new version acquires i_flags_lock early and
only drops it once we need to call into inode_init_always or before
calling xfs_ilock.

This patch fixes a bug seen in the wild where we race modifying the
reclaim tag.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
2009-08-17 01:23:48 -05:00
..
kmem.c
kmem.h
mrlock.h
sv.h
time.h
xfs_acl.c
xfs_aops.c
xfs_aops.h
xfs_buf.c
xfs_buf.h
xfs_cred.h
xfs_dmapi_priv.h
xfs_export.c
xfs_export.h
xfs_file.c
xfs_fs_subr.c
xfs_fs_subr.h
xfs_globals.c
xfs_globals.h
xfs_ioctl32.c
xfs_ioctl32.h
xfs_ioctl.c
xfs_ioctl.h
xfs_iops.c
xfs_iops.h
xfs_linux.h
xfs_lrw.c
xfs_lrw.h
xfs_quotaops.c
xfs_stats.c
xfs_stats.h
xfs_super.c
xfs_super.h
xfs_sync.c xfs: fix locking in xfs_iget_cache_hit 2009-08-17 01:23:48 -05:00
xfs_sync.h xfs: fix locking in xfs_iget_cache_hit 2009-08-17 01:23:48 -05:00
xfs_sysctl.c
xfs_sysctl.h
xfs_version.h
xfs_vnode.h
xfs_xattr.c