Jayachandran C
12fc1d7b4b
[PATCH] IPMI: fix issues reported by Coverity in ipmi_msghandler.c
...
While looking to the report by Coverity in ipmi, I came across the
following issue:
The IPMI message handler relies on two defines which are the same -one in
include/linux/ipmi.h
#define IPMI_NUM_CHANNELS 0x10
and one in drivers/char/ipmi/ipmi_msghandler.
#define IPMI_MAX_CHANNELS 16
These are used interchangeably in ipmi_msghandler.c, but since the array
addr->channels[] is of size IPMI_MAX_CHANNELS, I have made a patch that
uses IPMI_MAX_CHANNELS for all the checks for the array index.
NOTE: You could probably remove the line that defines IPMI_NUM_CHANNELS
from ipmi.h, or move IPMI_MAX_CHANNELS to ipmi.h
Signed-off-by: Jayachandran C. <c.jayachandran@gmail.com>
Cc: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-02-03 08:32:11 -08:00
..
2006-01-19 16:19:35 -08:00
2006-02-02 07:49:43 -08:00
2006-01-15 01:57:47 +01:00
2006-02-03 08:32:10 -08:00
2006-02-03 08:32:11 -08:00
2005-12-15 10:04:31 -08:00
2006-01-10 08:01:59 -08:00
2006-02-03 08:32:04 -08:00
2006-02-01 08:53:12 -08:00
2006-02-03 08:32:02 -08:00
2006-01-01 22:21:50 +01:00
2006-01-14 10:41:42 -08:00
2005-09-10 10:06:25 -07:00
2005-11-07 07:54:02 -08:00
2006-01-10 08:01:24 -08:00
2006-02-03 08:32:09 -08:00
2005-09-07 16:57:20 -07:00
2005-09-07 16:57:20 -07:00
2005-06-25 16:24:57 -07:00
2006-01-12 09:09:04 -08:00
2006-01-10 08:01:59 -08:00
2005-09-16 10:38:10 -07:00
2006-02-03 08:32:09 -08:00
2006-01-14 10:41:42 -08:00
2006-02-01 08:53:24 -08:00
2005-12-10 00:20:25 -05:00
2006-01-10 08:01:59 -08:00
2005-10-24 15:42:12 +10:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:56 -08:00
2006-01-08 20:14:06 -08:00
2005-11-12 11:42:32 -08:00
2005-11-09 07:55:57 -08:00
2006-02-03 08:32:10 -08:00
2006-01-10 08:02:01 -08:00
2006-01-10 08:01:59 -08:00
2006-02-01 08:53:24 -08:00
2005-12-22 23:09:54 -08:00
2005-10-29 19:30:42 +01:00
2005-10-29 19:30:42 +01:00
2005-10-28 09:52:52 -07:00
2006-01-10 08:01:24 -08:00
2005-10-04 09:39:18 -07:00
2006-01-12 20:09:30 +11:00
2005-10-28 09:52:52 -07:00
2006-01-06 15:22:28 -08:00
2006-01-10 09:45:36 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:02:00 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:56 -08:00
2005-10-28 09:52:52 -07:00
2006-01-10 08:01:59 -08:00
2005-10-29 19:30:55 +01:00
2006-01-11 18:42:11 -08:00
2005-10-28 09:52:52 -07:00
2006-01-14 10:41:42 -08:00
2005-06-25 16:25:04 -07:00
2006-02-03 08:31:59 -08:00
2006-01-11 18:42:10 -08:00
2006-01-07 16:15:52 +00:00
2006-01-12 09:09:00 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:59 -08:00
2006-01-14 10:41:42 -08:00
2005-08-15 14:17:49 -07:00
2005-10-28 21:09:26 -07:00
2006-01-08 20:14:03 -08:00
2006-01-14 10:41:42 -08:00
2006-01-15 02:37:08 +01:00
2006-02-03 08:32:03 -08:00
2006-01-18 19:20:16 -08:00
2006-01-14 10:41:42 -08:00
2006-01-10 08:01:59 -08:00
2006-01-09 15:59:21 -08:00
2006-01-10 13:39:07 +00:00
2005-10-28 09:52:52 -07:00
2006-01-18 19:25:49 -08:00
2005-06-25 16:24:24 -07:00
2006-02-03 08:32:09 -08:00
2005-06-28 21:20:34 -07:00
2005-12-29 10:19:21 -08:00
2006-01-12 20:09:29 +11:00
2005-11-09 07:55:57 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 13:39:07 +00:00
2006-01-10 09:00:55 -08:00
2005-11-07 07:53:39 -08:00
2006-02-01 08:53:26 -08:00