Daniel Borkmann 7c30013133 bpf: fix ri->map_owner pointer on bpf_prog_realloc ... Commit 109980b894 ("bpf: don't select potentially stale ri->map from buggy xdp progs") passed the pointer to the prog itself to be loaded into r4 prior on bpf_redirect_map() helper call, so that we can store the owner into ri->map_owner out of the helper. Issue with that is that the actual address of the prog is still subject to change when subsequent rewrites occur that require slow path in bpf_prog_realloc() to alloc more memory, e.g. from patching inlining helper functions or constant blinding. Thus, we really need to take prog->aux as the address we're holding, which also works with prog clones as they share the same aux object. Instead of then fetching aux->prog during runtime, which could potentially incur cache misses due to false sharing, we are going to just use aux for comparison on the map owner. This will also keep the patchlet of the same size, and later check in xdp_map_invalid() only accesses read-only aux pointer from the prog, it's also in the same cacheline already from prior access when calling bpf_func. Fixes: 109980b894 ("bpf: don't select potentially stale ri->map from buggy xdp progs") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-09-19 16:38:53 -07:00
..
arraymap.c	bpf: inline map in map lookup functions for array and htab	2017-08-19 21:56:34 -07:00
bpf_lru_list.c	bpf: lru: Lower the PERCPU_NR_SCANS from 16 to 4	2017-04-17 13:55:52 -04:00
bpf_lru_list.h	bpf: Only set node->ref = 1 if it has not been set	2017-09-01 09:57:39 -07:00
cgroup.c	bpf: BPF support for sock_ops	2017-07-01 16:15:13 -07:00
core.c	bpf: sock_map fixes for !CONFIG_BPF_SYSCALL and !STREAM_PARSER	2017-08-16 15:34:13 -07:00
devmap.c	bpf: devmap: pass on return value of bpf_map_precharge_memlock	2017-09-18 16:53:30 -07:00
hashtab.c	bpf: Only set node->ref = 1 if it has not been set	2017-09-01 09:57:39 -07:00
helpers.c
inode.c	bpf: Implement show_options	2017-07-06 03:31:46 -04:00
lpm_trie.c	bpf: Allow selecting numa node during map creation	2017-08-19 21:35:43 -07:00
Makefile	bpf: sock_map fixes for !CONFIG_BPF_SYSCALL and !STREAM_PARSER	2017-08-16 15:34:13 -07:00
map_in_map.c	bpf: Add syscall lookup support for fd array and htab	2017-06-29 13:13:25 -04:00
map_in_map.h	bpf: Add syscall lookup support for fd array and htab	2017-06-29 13:13:25 -04:00
percpu_freelist.c
percpu_freelist.h
sockmap.c	bpf: add support for sockmap detach programs	2017-09-08 21:11:00 -07:00
stackmap.c	bpf: Allow selecting numa node during map creation	2017-08-19 21:35:43 -07:00
syscall.c	bpf: do not disable/enable BH in bpf_map_free_id()	2017-09-19 15:42:54 -07:00
tnum.c	bpf/verifier: track signed and unsigned min/max values	2017-08-08 17:51:34 -07:00
verifier.c	bpf: fix ri->map_owner pointer on bpf_prog_realloc	2017-09-19 16:38:53 -07:00