linux/net/dccp
Patrick McHardy 028b027524 [DCCP]: Fix skb->cb conflicts with IP
dev_queue_xmit() and the other IP output functions expect to get a skb
with clear or properly initialized skb->cb. Unlike TCP and UDP, the
dccp_skb_cb doesn't contain a struct inet_skb_parm at the beginning,
so the DCCP-specific data is interpreted by the IP output functions.
This can cause false negatives for the conditional POST_ROUTING hook
invocation, making the packet bypass the hook.

Add a inet_skb_parm/inet6_skb_parm union to the beginning of
dccp_skb_cb to avoid clashes. Also add a BUILD_BUG_ON to make
sure it fits in the cb.

[ Combined with patch from Gerrit Renker to remove two now unnecessary
  memsets of IPCB(skb)->opt ]

Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-04-12 18:35:41 -07:00
..
ccids
ackvec.c
ackvec.h
ccid.c
ccid.h
dccp.h [DCCP]: Fix skb->cb conflicts with IP 2008-04-12 18:35:41 -07:00
diag.c
feat.c
feat.h
input.c
ipv4.c [DCCP]: Fix skb->cb conflicts with IP 2008-04-12 18:35:41 -07:00
ipv6.c [SOCK] proto: Add hashinfo member to struct proto 2008-02-03 04:28:52 -08:00
ipv6.h
Kconfig
Makefile
minisocks.c
options.c
output.c [DCCP]: Fix skb->cb conflicts with IP 2008-04-12 18:35:41 -07:00
probe.c
proto.c [DCCP]: Fix skb->cb conflicts with IP 2008-04-12 18:35:41 -07:00
sysctl.c
timer.c