linux/drivers/tty
Jiri Slaby 7f90cfc505 TTY: ldisc, fix open flag handling
When a concrete ldisc open fails in tty_ldisc_open, we forget to clear
TTY_LDISC_OPEN. This causes a false warning on the next ldisc open:
WARNING: at drivers/char/tty_ldisc.c:445 tty_ldisc_open+0x26/0x38()
Hardware name: System Product Name
Modules linked in: ...
Pid: 5251, comm: a.out Tainted: G        W  2.6.32-5-686 #1
Call Trace:
 [<c1030321>] ? warn_slowpath_common+0x5e/0x8a
 [<c1030357>] ? warn_slowpath_null+0xa/0xc
 [<c119311c>] ? tty_ldisc_open+0x26/0x38
 [<c11936c5>] ? tty_set_ldisc+0x218/0x304
...

So clear the bit when failing...

Introduced in c65c9bc3ef (tty: rewrite the ldisc locking) back in
2.6.31-rc1.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Reported-by: Sergey Lapin <slapin@ossfans.org>
Tested-by: Sergey Lapin <slapin@ossfans.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-29 14:51:54 -08:00
..
vt vcs: make proper usage of the poll flags 2010-11-11 10:51:35 -08:00
Makefile TTY: create drivers/tty/vt and move the vt code there 2010-11-05 08:16:52 -07:00
n_gsm.c n_gsm: Fix length handling 2010-11-11 11:06:09 -08:00
n_hdlc.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
n_r3964.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
n_tty.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
pty.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
sysrq.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
tty_audit.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
tty_buffer.c tty: prevent DOS in the flush_to_ldisc 2010-11-09 15:02:02 -08:00
tty_io.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
tty_ioctl.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
tty_ldisc.c TTY: ldisc, fix open flag handling 2010-11-29 14:51:54 -08:00
tty_mutex.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00
tty_port.c TTY: create drivers/tty and move the tty core files there 2010-11-05 08:10:33 -07:00