Ben Woodard 837c787877 [BLOCK] increase size of disk stat counters ... The kernel's representation of the disk statistics uses the type unsigned which is 32b on both 32b and 64b platforms. Unfortunately, most system tools that work with these numbers that are exported in /proc/diskstats including iostat read these numbers into unsigned longs. This works fine on 32b platforms and when the number of IO transactions are small on 64b platforms. However, when the numbers wrap on 64b platforms & you read the numbers into unsigned longs, and compare the numbers to previous readings, then you get an unsigned representation of a negative number. This looks like a very large 64b number & gives you bizarre readouts in iostat: ilc4: Device: rrqm/s wrqm/s r/s w/s rsec/s wsec/s rkB/s wkB/s avgrq-sz avgqu-sz await svctm %util ilc4: sda 5.50 0.00 143.96 0.00 307496983987862656.00 0.00 153748491993931328.00 0.00 2136028725038430.00 7.94 55.12 5.59 80.42 Though fixing iostat in user space is possible, and a quick survey indicates that several other similar tools also use unsigned longs when processing /proc/diskstats. Therefore, it seems like a better approach would be to extend the length of the disk_stats structure on 64b architectures to 64b. The following patch does that. It should not affect the operation on 32b platforms. Signed-off-by: Ben Woodard <woodard@redhat.com> Cc: Rick Lindsley <ricklind@us.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Jens Axboe <axboe@suse.de>		2006-03-27 09:29:02 +02:00
..
as-iosched.c	[PATCH] fix rmmod problems with elevator attributes, clean them up	2006-03-18 22:27:18 -05:00
blktrace.c	[PATCH] Block queue IO tracing support (blktrace) as of 2006-03-23	2006-03-23 20:00:26 +01:00
cfq-iosched.c	[PATCH] mempool: use mempool_create_slab_pool()	2006-03-26 08:57:00 -08:00
deadline-iosched.c	[PATCH] fix rmmod problems with elevator attributes, clean them up	2006-03-18 22:27:18 -05:00
elevator.c	BUG_ON() Conversion in block/elevator.c	2006-03-24 18:43:26 +01:00
genhd.c	[BLOCK] increase size of disk stat counters	2006-03-27 09:29:02 +02:00
ioctl.c	[PATCH] Block queue IO tracing support (blktrace) as of 2006-03-23	2006-03-23 20:00:26 +01:00
Kconfig	[PATCH] 2TB files: add blkcnt_t	2006-03-26 08:57:00 -08:00
Kconfig.iosched	[BLOCK] iosched: fix setting of default io scheduler	2005-11-04 08:44:58 +01:00
ll_rw_blk.c	[PATCH] blk_execute_rq_nowait-speedup	2006-03-27 09:29:02 +02:00
Makefile	[PATCH] Block queue IO tracing support (blktrace) as of 2006-03-23	2006-03-23 20:00:26 +01:00
noop-iosched.c	[BLOCK] noop-iosched: reimplementation of request dispatching	2005-11-12 10:56:52 +01:00
scsi_ioctl.c	[PATCH] blk: Fix SG_IO ioctl failure retry looping	2006-02-08 10:07:13 +01:00