Eric Dumazet 8d650cdeda tcp: fix tcp_set_congestion_control() use from bpf hook ... Neal reported incorrect use of ns_capable() from bpf hook. bpf_setsockopt(...TCP_CONGESTION...) -> tcp_set_congestion_control() -> ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN) -> ns_capable_common() -> current_cred() -> rcu_dereference_protected(current->cred, 1) Accessing 'current' in bpf context makes no sense, since packets are processed from softirq context. As Neal stated : The capability check in tcp_set_congestion_control() was written assuming a system call context, and then was reused from a BPF call site. The fix is to add a new parameter to tcp_set_congestion_control(), so that the ns_capable() call is only performed under the right context. Fixes: 91b5b21c7c ("bpf: Add support for changing congestion control") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Lawrence Brakmo <brakmo@fb.com> Reported-by: Neal Cardwell <ncardwell@google.com> Acked-by: Neal Cardwell <ncardwell@google.com> Acked-by: Lawrence Brakmo <brakmo@fb.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-07-18 20:33:48 -07:00
..
acpi
asm-generic
clocksource
crypto
drm
dt-bindings
keys
kvm
linux	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2019-07-18 14:04:45 -07:00
math-emu
media
memory
misc	powerpc updates for 5.3	2019-07-13 16:08:36 -07:00
net	tcp: fix tcp_set_congestion_control() use from bpf hook	2019-07-18 20:33:48 -07:00
pcmcia
ras
rdma
scsi
soc
sound
target
trace	f2fs-for-5.3-rc1	2019-07-12 17:28:24 -07:00
uapi	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2019-07-18 14:04:45 -07:00
vdso
video
xen
Kbuild