Neil Horman 73e42897e8 ipv4: fix NULL pointer + success return in route lookup path ... Don't drop route if we're not caching I recently got a report of an oops on a route lookup. Maxime was testing what would happen if route caching was turned off (doing so by setting making rt_caching always return 0), and found that it triggered an oops. I looked at it and found that the problem stemmed from the fact that the route lookup routines were returning success from their lookup paths (which is good), but never set the **rp pointer to anything (which is bad). This happens because in rt_intern_hash, if rt_caching returns false, we call rt_drop and return 0. This almost emulates slient success. What we should be doing is assigning *rp = rt and _not_ dropping the route. This way, during slow path lookups, when we create a new route cache entry, we don't immediately discard it, rather we just don't add it into the cache hash table, but we let this one lookup use it for the purpose of this route request. Maxime has tested and reports it prevents the oops. There is still a subsequent routing issue that I'm looking into further, but I'm confident that, even if its related to this same path, this patch makes sense to take. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2009-06-20 01:15:16 -07:00
..
netfilter	netfilter: ip_tables: fix build error	2009-06-12 01:53:09 +02:00
af_inet.c	ipv4: remove ip_mc_drop_socket() declaration from af_inet.c.	2009-06-03 21:43:26 -07:00
ah4.c	netns xfrm: AH/ESP in netns!	2008-11-25 17:59:27 -08:00
arp.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
cipso_ipv4.c	netlabel: Label incoming TCP connections correctly in SELinux	2009-03-28 15:01:36 +11:00
datagram.c	mib: add net to IP_INC_STATS_BH	2008-07-16 20:20:11 -07:00
devinet.c	net: Fix devinet_sysctl_forward	2009-05-18 22:15:58 -07:00
esp4.c	netns xfrm: AH/ESP in netns!	2008-11-25 17:59:27 -08:00
fib_frontend.c	ipv4: cleanup: remove unnecessary include.	2009-05-18 15:16:38 -07:00
fib_hash.c	ipv4: cleanup - remove two unused parameters from fib_semantic_match().	2009-05-18 15:16:37 -07:00
fib_lookup.h	ipv4: cleanup - remove two unused parameters from fib_semantic_match().	2009-05-18 15:16:37 -07:00
fib_rules.c	net: Remove unused parameter from fill method in fib_rules_ops.	2009-05-20 17:26:23 -07:00
fib_semantics.c	ipv4: cleanup - remove two unused parameters from fib_semantic_match().	2009-05-18 15:16:37 -07:00
fib_trie.c	ipv4: Fix fib_trie rebalancing, part 2	2009-06-18 00:28:51 -07:00
icmp.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
igmp.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
inet_connection_sock.c	net: move bsockets outside of read only beginning of struct inet_hashinfo	2009-02-01 12:31:33 -08:00
inet_diag.c	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
inet_fragment.c	inet fragments: fix sparse warning: context imbalance	2009-02-26 23:13:35 -08:00
inet_hashtables.c	net: move bsockets outside of read only beginning of struct inet_hashinfo	2009-02-01 12:31:33 -08:00
inet_lro.c	include/net net/ - csum_partial - remove unnecessary casts	2008-11-19 15:44:53 -08:00
inet_timewait_sock.c	net: Make inet_twsk_put similar to sock_put	2009-05-06 16:50:52 -07:00
inetpeer.c	net: clean up net/ipv4/ah4.c esp4.c fib_semantics.c inet_connection_sock.c inetpeer.c ip_output.c	2008-11-03 00:23:42 -08:00
ip_forward.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
ip_fragment.c	ipv4: Use frag list abstraction interfaces.	2009-06-09 00:19:37 -07:00
ip_gre.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
ip_input.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
ip_options.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
ip_output.c	net: No more expensive sock_hold()/sock_put() on each tx	2009-06-11 02:55:43 -07:00
ip_sockglue.c	net: skb->rtable accessor	2009-06-03 02:51:02 -07:00
ipcomp.c	netns xfrm: state lookup in netns	2008-11-25 17:30:50 -08:00
ipconfig.c	ipv4: teach ipconfig about the MTU option in DHCP	2009-05-19 15:36:17 -07:00
ipip.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
ipmr.c	PIM-SM: namespace changes	2009-06-14 03:16:13 -07:00
Kconfig	ipv4: update ARPD help text	2009-06-13 23:36:32 -07:00
Makefile	IPVS: Move IPVS to net/netfilter/ipvs	2008-10-07 08:38:24 +11:00
netfilter.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
proc.c	snmp: add missing counters for RFC 4293	2009-04-27 02:45:02 -07:00
protocol.c	net: remove CVS keywords	2008-06-11 21:00:38 -07:00
raw.c	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
route.c	ipv4: fix NULL pointer + success return in route lookup path	2009-06-20 01:15:16 -07:00
syncookies.c	syncookies: remove last_synq_overflow from struct tcp_sock	2009-04-20 02:25:26 -07:00
sysctl_net_ipv4.c	net: '&' redux	2008-11-03 18:21:05 -08:00
tcp_bic.c	tcp: add helper for AI algorithm	2009-03-02 03:00:15 -08:00
tcp_cong.c	tcp: add helper for AI algorithm	2009-03-02 03:00:15 -08:00
tcp_cubic.c	tcp: add helper for AI algorithm	2009-03-02 03:00:15 -08:00
tcp_diag.c	net: inet_diag_handler structs can be const	2008-11-19 15:43:27 -08:00
tcp_highspeed.c	[TCP]: Cong.ctrl modules: remove unused good_ack from cong_avoid	2008-01-28 14:55:41 -08:00
tcp_htcp.c	htcp: merge icsk_ca_state compare	2009-03-02 03:00:14 -08:00
tcp_hybla.c	tcp: Fix tcp_hybla zero congestion window growth with small rho and large cwnd.	2008-10-07 15:58:17 -07:00
tcp_illinois.c	[TCP]: Cong.ctrl modules: remove unused good_ack from cong_avoid	2008-01-28 14:55:41 -08:00
tcp_input.c	tcp: fix loop in ofo handling code and reduce its complexity	2009-05-29 15:02:29 -07:00
tcp_ipv4.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
tcp_lp.c	[TCP]: Cong.ctrl modules: remove unused good_ack from cong_avoid	2008-01-28 14:55:41 -08:00
tcp_minisocks.c	tcp: consolidate paws check	2009-03-15 20:09:52 -07:00
tcp_output.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
tcp_probe.c	tcp: '< 0' test on unsigned	2009-03-13 16:05:14 -07:00
tcp_scalable.c	tcp: add helper for AI algorithm	2009-03-02 03:00:15 -08:00
tcp_timer.c	tcp: cleanup ca_state mess in tcp_timer	2009-03-02 03:00:13 -08:00
tcp_vegas.c	tcp: tcp_vegas ssthresh bugfix	2009-05-25 22:44:59 -07:00
tcp_vegas.h	[TCP]: congestion control API pass RTT in microseconds	2007-07-31 02:27:57 -07:00
tcp_veno.c	tcp: add helper for AI algorithm	2009-03-02 03:00:15 -08:00
tcp_westwood.c	[TCP]: congestion control API pass RTT in microseconds	2007-07-31 02:27:57 -07:00
tcp_yeah.c	tcp: add helper for AI algorithm	2009-03-02 03:00:15 -08:00
tcp.c	tcp: Use SKB queue and list helpers instead of doing it by-hand.	2009-05-28 21:35:47 -07:00
tunnel4.c	[IPV4] TUNNEL4: Fix incoming packet length check for inter-protocol tunnel.	2008-06-05 04:02:33 +09:00
udp_impl.h	udp: introduce struct udp_table and multiple spinlocks	2008-10-29 01:41:45 -07:00
udp.c	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
udplite.c	udp: RCU handling for Unicast packets.	2008-10-29 02:11:14 -07:00
xfrm4_input.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
xfrm4_mode_beet.c	ipsec: Interfamily IPSec BEET	2008-08-06 02:39:30 -07:00
xfrm4_mode_transport.c	[IPSEC]: Use IPv6 calling convention as the convention for x->mode->output	2007-10-10 16:55:54 -07:00
xfrm4_mode_tunnel.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
xfrm4_output.c	net: skb->dst accessors	2009-06-03 02:51:04 -07:00
xfrm4_policy.c	net: replace uses of __constant_{endian}	2009-02-01 00:45:17 -08:00
xfrm4_state.c	xfrm: remove useless forward declarations	2008-11-25 01:05:54 -08:00
xfrm4_tunnel.c	[IPCOMP]: Fix reception of incompressible packets	2008-01-31 19:27:24 -08:00