Dan Carpenter a1c4560d4d drivers/gpu/drm/drm_sysfs.c: sysfs files error handling ...

In the original code we used "j" as an iterator but we used "i" as an
index.

-               for (j = 0; j < i; j++)
-                       device_remove_file(&connector->kdev,
-                                          &connector_attrs[i]);

Smatch complained about that because "i" was potentially passed the end of
the array.  Which makes sense if we should be using "j" there.

I also thought that we should remove the files for &connector_attrs_opt1
but to do that I had to add separate iterators for &connector_attrs and
&connector_attrs_opt1.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>

2010-04-28 18:42:52 +10:00

..

drm

drivers/gpu/drm/drm_sysfs.c: sysfs files error handling

2010-04-28 18:42:52 +10:00

vga

gpu: vga_switcheroo, fix lock imbalance

2010-04-28 18:41:52 +10:00

Makefile

PCI/GPU: implement VGA arbitration on Linux

2009-09-09 13:29:36 -07:00