Theodore Ts'o 1e424a3483 ext4: partial revert to fix double brelse WARNING() ... This is a partial revert of commit 6487a9d (only the changes made to fs/ext4/namei.c), since it is causing the following brelse() double-free warning when running fsstress on a file system with 1k blocksize and we run into a block allocation failure while converting a single-block directory to a multi-block hash-tree indexed directory. WARNING: at fs/buffer.c:1197 __brelse+0x2e/0x33() Hardware name: VFS: brelse: Trying to free free buffer Modules linked in: Pid: 2226, comm: jbd2/sdd-8 Not tainted 2.6.32-rc6-00577-g0003f55 #101 Call Trace: [<c01587fb>] warn_slowpath_common+0x65/0x95 [<c0158869>] warn_slowpath_fmt+0x29/0x2c [<c021168e>] __brelse+0x2e/0x33 [<c0288a9f>] jbd2_journal_refile_buffer+0x67/0x6c [<c028a9ed>] jbd2_journal_commit_transaction+0x319/0x14d8 [<c0164d73>] ? try_to_del_timer_sync+0x58/0x60 [<c0175bcc>] ? sched_clock_cpu+0x12a/0x13e [<c017f6b4>] ? trace_hardirqs_off+0xb/0xd [<c0175c1f>] ? cpu_clock+0x3f/0x5b [<c017f6ec>] ? lock_release_holdtime+0x36/0x137 [<c0664ad0>] ? _spin_unlock_irqrestore+0x44/0x51 [<c0180af3>] ? trace_hardirqs_on_caller+0x103/0x124 [<c0180b1f>] ? trace_hardirqs_on+0xb/0xd [<c0164d73>] ? try_to_del_timer_sync+0x58/0x60 [<c0290d1c>] kjournald2+0x11a/0x310 [<c017118e>] ? autoremove_wake_function+0x0/0x38 [<c0290c02>] ? kjournald2+0x0/0x310 [<c0170ee6>] kthread+0x66/0x6b [<c0170e80>] ? kthread+0x0/0x6b [<c01251b3>] kernel_thread_helper+0x7/0x10 ---[ end trace 5579351b86af61e3 ]--- Commit 6487a9d was an attempt some buffer head leaks in an ENOSPC error path, but in some cases it actually results in an excess ENOSPC, as shown above. Fixing this means cleaning up who is responsible for releasing the buffer heads from the callee to the caller of add_dirent_to_buf(). Since that's a relatively complex change, and we're late in the rcX development cycle, I'm reverting this now, and holding back a more complete fix until after 2.6.32 ships. We've lived with this buffer_head leak on ENOSPC in ext3 and ext4 for a very long time; a few more months won't kill us. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: Curt Wohlgemuth <curtw@google.com>		2009-11-08 15:45:44 -05:00
..
acl.c
acl.h
balloc.c
bitmap.c
block_validity.c
dir.c
ext4_extents.h	ext4: Split uninitialized extents for direct I/O	2009-09-28 15:49:08 -04:00
ext4_jbd2.c
ext4_jbd2.h	ext4: Handle nested ext4_journal_start/stop calls without a journal	2009-09-29 11:01:03 -04:00
ext4.h	ext4: skip conversion of uninit extents after direct IO if there isn't any	2009-11-10 10:48:04 -05:00
extents.c	ext4: Fix return value of ext4_split_unwritten_extents() to fix direct I/O	2009-11-06 04:01:23 -05:00
file.c	const: mark struct vm_struct_operations	2009-09-27 11:39:25 -07:00
fsync.c	ext4: async direct IO for holes and fallocate support	2009-09-28 15:48:29 -04:00
hash.c
ialloc.c
inode.c	ext4: skip conversion of uninit extents after direct IO if there isn't any	2009-11-10 10:48:04 -05:00
ioctl.c
Kconfig	ext4: drop ext4dev compat	2009-10-01 02:21:07 -04:00
Makefile
mballoc.c	ext4: Use tracepoints for mb_history trace file	2009-09-30 00:32:42 -04:00
mballoc.h	ext4: Use tracepoints for mb_history trace file	2009-09-30 00:32:42 -04:00
migrate.c	ext4: Split uninitialized extents for direct I/O	2009-09-28 15:49:08 -04:00
move_extent.c	ext4: EXT4_IOC_MOVE_EXT: Check for different original and donor inodes first	2009-09-28 15:58:29 -04:00
namei.c	ext4: partial revert to fix double brelse WARNING()	2009-11-08 15:45:44 -05:00
resize.c
super.c	Revert "ext4: Remove journal_checksum mount option and enable it by default"	2009-11-02 10:15:27 -08:00
symlink.c
xattr_security.c
xattr_trusted.c
xattr_user.c
xattr.c	ext4: limit block allocations for indirect-block files to < 2^32	2009-09-16 14:45:10 -04:00
xattr.h