linux/fs/ocfs2
Christoph Lameter 50953fe9e0 slab allocators: Remove SLAB_DEBUG_INITIAL flag
I have never seen a use of SLAB_DEBUG_INITIAL.  It is only supported by
SLAB.

I think its purpose was to have a callback after an object has been freed
to verify that the state is the constructor state again?  The callback is
performed before each freeing of an object.

I would think that it is much easier to check the object state manually
before the free.  That also places the check near the code object
manipulation of the object.

Also the SLAB_DEBUG_INITIAL callback is only performed if the kernel was
compiled with SLAB debugging on.  If there would be code in a constructor
handling SLAB_DEBUG_INITIAL then it would have to be conditional on
SLAB_DEBUG otherwise it would just be dead code.  But there is no such code
in the kernel.  I think SLUB_DEBUG_INITIAL is too problematic to make real
use of, difficult to understand and there are easier ways to accomplish the
same effect (i.e.  add debug code before kfree).

There is a related flag SLAB_CTOR_VERIFY that is frequently checked to be
clear in fs inode caches.  Remove the pointless checks (they would even be
pointless without removeal of SLAB_DEBUG_INITIAL) from the fs constructors.

This is the last slab flag that SLUB did not support.  Remove the check for
unimplemented flags from SLUB.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-07 12:12:57 -07:00
..
cluster Merge branch 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2 2007-05-04 20:44:54 -07:00
dlm slab allocators: Remove SLAB_DEBUG_INITIAL flag 2007-05-07 12:12:57 -07:00
alloc.c ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
alloc.h ocfs2: make room for unwritten extents flag 2007-04-26 15:02:37 -07:00
aops.c ocfs2: Force use of GFP_NOFS in ocfs2_write() 2007-05-02 15:08:34 -07:00
aops.h ocfs2: Remember rw lock level during direct io 2007-04-26 15:07:45 -07:00
buffer_head_io.c
buffer_head_io.h
dcache.c
dcache.h
dir.c ocfs2: Wrap access of directory allocations with ip_alloc_sem. 2007-05-02 15:07:42 -07:00
dir.h ocfs2: Remove struct ocfs2_journal_handle in favor of handle_t 2006-12-01 18:28:28 -08:00
dlmglue.c [PATCH] fs/ocfs2/: make 3 functions static 2007-05-02 15:07:27 -07:00
dlmglue.h [PATCH] fs/ocfs2/: make 3 functions static 2007-05-02 15:07:27 -07:00
endian.h
export.c ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
export.h
extent_map.c ocfs2: Cache extent records 2007-04-26 15:10:40 -07:00
extent_map.h ocfs2: Cache extent records 2007-04-26 15:10:40 -07:00
file.c ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
file.h [PATCH] fs/ocfs2/: make 3 functions static 2007-05-02 15:07:27 -07:00
heartbeat.c ocfs2: Proper cleanup in case of error in ocfs2_register_hb_callbacks() 2007-03-14 14:37:09 -07:00
heartbeat.h
inode.c ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
inode.h [PATCH] Copy i_flags to ocfs2 inode flags on write 2007-05-02 15:07:58 -07:00
ioctl.c [PATCH] Copy i_flags to ocfs2 inode flags on write 2007-05-02 15:07:58 -07:00
ioctl.h ocfs2: Implement compat_ioctl() 2007-05-02 15:07:16 -07:00
journal.c ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
journal.h ocfs2: make room for unwritten extents flag 2007-04-26 15:02:37 -07:00
localalloc.c [PATCH] Fix numerous kcalloc() calls, convert to kzalloc() 2006-12-13 09:05:52 -08:00
localalloc.h ocfs2: Remove struct ocfs2_journal_handle in favor of handle_t 2006-12-01 18:28:28 -08:00
Makefile
mmap.c ocfs2: Turn off shared writeable mmap for local files systems with holes. 2007-04-26 15:02:01 -07:00
mmap.h
namei.c ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
namei.h [PATCH] mark struct inode_operations const 2 2007-02-12 09:48:46 -08:00
ocfs1_fs_compat.h
ocfs2_fs.h ocfs2: Implement compat_ioctl() 2007-05-02 15:07:16 -07:00
ocfs2_lockid.h ocfs2: Remove delete inode vote 2007-04-26 14:39:48 -07:00
ocfs2.h ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
slot_map.c ocfs2: Read from an unwritten extent returns zeros 2007-04-26 15:02:41 -07:00
slot_map.h
suballoc.c ocfs2: fix sparse warnings in fs/ocfs2 2007-05-02 15:08:08 -07:00
suballoc.h ocfs2: Remove struct ocfs2_journal_handle in favor of handle_t 2006-12-01 18:28:28 -08:00
super.c slab allocators: Remove SLAB_DEBUG_INITIAL flag 2007-05-07 12:12:57 -07:00
super.h
symlink.c mm: make read_cache_page synchronous 2007-05-07 12:12:51 -07:00
symlink.h [PATCH] mark struct inode_operations const 2 2007-02-12 09:48:46 -08:00
sysfile.c
sysfile.h
uptodate.c [PATCH] slab: remove kmem_cache_t 2006-12-07 08:39:25 -08:00
uptodate.h
ver.c
ver.h
vote.c ocfs2: remove unused code 2007-04-26 14:40:16 -07:00
vote.h ocfs2: remove unused code 2007-04-26 14:40:16 -07:00