Javier Martinez Canillas
a841178445
mfd: cros_ec: Use a zero-length array for command data ...
Commit 1b84f2a4cd4a ("mfd: cros_ec: Use fixed size arrays to transfer
data with the EC") modified the struct cros_ec_command fields to not
use pointers for the input and output buffers and use fixed length
arrays instead.
This change was made because the cros_ec ioctl API uses that struct
cros_ec_command to allow user-space to send commands to the EC and
to get data from the EC. So using pointers made the API not 64-bit
safe. Unfortunately this approach was not flexible enough for all
the use-cases since there may be a need to send larger commands
on newer versions of the EC command protocol.
So to avoid to choose a constant length that it may be too big for
most commands and thus wasting memory and CPU cycles on copy from
and to user-space or having a size that is too small for some big
commands, use a zero-length array that is both 64-bit safe and
flexible. The same buffer is used for both output and input data
so the maximum of these values should be used to allocate it.
Suggested-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
2015-06-15 13:18:19 +01:00
2013-06-18 09:41:10 +02:00
2014-03-19 08:58:15 +00:00
2014-07-09 16:38:02 +01:00
2015-01-22 15:56:07 +00:00
2014-09-26 08:15:45 +01:00
2014-07-09 16:38:04 +01:00
2014-07-09 16:38:05 +01:00
2014-10-20 16:20:53 +02:00
2014-10-20 16:20:53 +02:00
2015-03-12 09:07:03 +00:00
2014-12-14 16:10:09 -08:00
2015-03-13 23:15:54 +01:00
2014-06-03 08:11:51 +01:00
2014-03-19 08:58:07 +00:00
2015-03-12 09:08:01 +00:00
2015-02-26 10:04:07 +00:00
2015-02-26 10:04:07 +00:00
2015-02-26 10:04:07 +00:00
2014-07-28 11:01:42 +01:00
2014-06-03 08:11:38 +01:00
2014-03-19 08:58:37 +00:00
2014-09-18 11:03:10 -07:00
2014-11-25 16:18:43 +00:00
2015-04-09 10:26:15 +01:00
2014-06-06 12:08:39 -07:00
2015-06-15 13:18:19 +01:00
2015-06-15 13:18:19 +01:00
2015-06-15 13:18:19 +01:00
2014-03-19 08:58:07 +00:00
2013-07-31 13:01:29 +01:00
2015-01-20 12:52:48 +00:00
2014-09-26 08:15:41 +01:00
2015-03-12 09:06:48 +00:00
2015-03-12 09:06:40 +00:00
2014-08-29 09:26:29 +01:00
2014-03-19 08:58:39 +00:00
2015-01-22 16:04:04 +00:00
2015-01-22 16:04:04 +00:00
2013-08-20 03:16:00 +02:00
2015-03-03 16:41:23 +00:00
2015-01-22 15:56:24 +00:00
2015-01-22 15:55:51 +00:00
2013-09-26 11:04:16 +02:00
2015-03-26 14:20:18 +00:00
2014-07-22 13:17:06 +01:00
2014-07-25 15:31:02 +01:00
2015-03-26 14:20:18 +00:00
2013-07-31 13:01:29 +01:00
2014-10-15 06:58:16 +02:00
2014-01-06 09:13:29 +00:00
2014-10-20 16:20:53 +02:00
2015-03-30 08:19:56 +01:00
2015-03-03 16:41:12 +00:00
2015-01-22 15:56:12 +00:00
2015-01-22 15:56:12 +00:00
2014-07-25 15:31:45 +01:00
2014-03-19 08:58:07 +00:00
2014-10-20 16:20:53 +02:00
2015-03-30 10:05:07 +01:00
2015-04-14 17:29:55 -07:00
2015-01-22 15:56:17 +00:00
2014-06-03 08:11:36 +01:00
2014-07-25 15:31:39 +01:00
2014-01-06 09:13:29 +00:00
2015-04-09 10:25:54 +01:00
2015-01-22 15:55:56 +00:00
2015-03-12 09:08:12 +00:00
2014-06-03 08:11:32 +01:00
2014-07-25 15:31:41 +01:00
2014-09-26 08:15:46 +01:00
2014-06-03 08:11:30 +01:00
2013-06-30 23:29:44 +02:00
2014-06-03 08:11:34 +01:00
2014-11-25 16:19:24 +00:00
2015-01-22 16:03:55 +00:00
2015-03-12 09:07:54 +00:00
2015-03-04 08:18:28 +00:00
2015-03-23 11:48:30 +00:00
2015-01-22 16:03:44 +00:00
2015-01-22 16:03:44 +00:00
2014-07-09 14:58:10 +01:00
2014-07-22 13:17:02 +01:00
2014-10-20 16:20:53 +02:00
2015-03-30 10:06:55 +01:00
2014-09-24 13:30:16 +01:00
2015-03-30 08:19:57 +01:00
2015-03-04 08:18:27 +00:00
2015-01-22 16:03:53 +00:00
2014-10-20 16:20:53 +02:00
2013-04-09 09:46:23 +02:00
2014-06-23 12:30:56 +01:00
2014-03-19 08:58:07 +00:00
2015-01-22 15:56:21 +00:00
2014-10-20 16:20:53 +02:00
2015-03-30 08:19:58 +01:00
2015-03-30 10:07:08 +01:00
2014-03-19 08:58:07 +00:00
2014-01-06 09:13:29 +00:00
2014-06-03 08:11:17 +01:00
2015-01-22 15:56:19 +00:00
2015-03-26 14:20:18 +00:00
2014-09-26 08:15:51 +01:00
2015-01-22 15:55:47 +00:00
2015-03-03 16:41:21 +00:00
2015-03-03 16:41:21 +00:00
2015-03-03 16:41:21 +00:00
2015-03-03 16:41:21 +00:00
2015-03-03 16:41:21 +00:00
2015-03-03 16:41:21 +00:00
2015-03-03 16:41:21 +00:00
2015-03-12 09:27:41 +00:00
2015-03-26 14:20:19 +00:00
2015-04-09 10:26:54 +01:00
2014-07-25 15:31:44 +01:00
2015-03-06 23:04:40 +01:00
2013-04-19 18:37:59 +02:00
2015-03-12 09:08:12 +00:00
2014-10-20 16:20:53 +02:00
2015-01-22 15:56:26 +00:00
2014-10-20 16:20:53 +02:00
2014-10-20 16:20:53 +02:00
2014-07-09 16:37:55 +01:00
2013-04-09 12:18:16 +02:00
2014-12-30 16:59:59 -08:00
2014-12-30 16:59:59 -08:00
2014-03-19 08:58:17 +00:00
2015-01-22 15:55:49 +00:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2015-03-26 14:20:17 +00:00
2014-11-25 16:18:58 +00:00
2014-12-14 16:10:09 -08:00
2015-03-03 16:41:15 +00:00
2014-03-19 08:58:34 +00:00
2014-07-25 15:31:47 +01:00
2014-06-03 08:11:27 +01:00
2014-06-03 08:11:28 +01:00
2015-04-09 10:26:40 +01:00
2014-11-25 16:18:53 +00:00
2015-01-22 16:03:46 +00:00
2015-01-22 16:03:34 +00:00
2014-09-26 08:15:48 +01:00
2014-10-20 16:20:53 +02:00
2014-03-19 08:58:07 +00:00
2013-06-13 12:11:39 +02:00
2014-03-19 08:58:07 +00:00
2014-07-28 08:10:06 +01:00
2014-01-06 09:13:29 +00:00
2014-10-20 16:20:53 +02:00
2014-09-26 08:15:34 +01:00
2015-03-26 14:20:18 +00:00
2014-07-25 15:31:42 +01:00
2015-03-30 12:39:22 +01:00
2015-01-22 16:03:48 +00:00
2014-09-18 11:03:10 -07:00
2013-07-31 13:01:29 +01:00
2015-03-03 16:41:14 +00:00
2014-11-25 16:18:42 +00:00
2014-01-21 08:27:45 +00:00
2013-08-20 08:51:58 +01:00
2014-01-06 09:13:25 +00:00
2014-01-21 08:27:51 +00:00
2013-07-31 13:01:29 +01:00
2014-01-21 08:27:51 +00:00
2015-04-09 10:26:48 +01:00
2014-11-25 16:18:56 +00:00
2014-11-25 16:18:51 +00:00
2014-07-25 15:31:42 +01:00
2014-07-22 13:17:05 +01:00
2014-06-03 08:11:34 +01:00
2015-01-22 15:56:03 +00:00
2014-09-26 08:15:35 +01:00
2014-09-26 08:15:35 +01:00
2014-11-25 16:18:55 +00:00
a841178445