Eric Dumazet abb57ea48f net: add skb_dst_force() in sock_queue_err_skb() ... Commit 7fee226ad2 (add a noref bit on skb dst) forgot to use skb_dst_force() on packets queued in sk_error_queue This triggers following warning, for applications using IP_CMSG_PKTINFO receiving one error status ------------[ cut here ]------------ WARNING: at include/linux/skbuff.h:457 ip_cmsg_recv_pktinfo+0xa6/0xb0() Hardware name: 2669UYD Modules linked in: isofs vboxnetadp vboxnetflt nfsd ebtable_nat ebtables lib80211_crypt_ccmp uinput xcbc hdaps tp_smapi thinkpad_ec radeonfb fb_ddc radeon ttm drm_kms_helper drm ipw2200 intel_agp intel_gtt libipw i2c_algo_bit i2c_i801 agpgart rng_core cfbfillrect cfbcopyarea cfbimgblt video raid10 raid1 raid0 linear md_mod vboxdrv Pid: 4697, comm: miredo Not tainted 2.6.39-rc6-00569-g5895198-dirty #22 Call Trace: [<c17746b6>] ? printk+0x1d/0x1f [<c1058302>] warn_slowpath_common+0x72/0xa0 [<c15bbca6>] ? ip_cmsg_recv_pktinfo+0xa6/0xb0 [<c15bbca6>] ? ip_cmsg_recv_pktinfo+0xa6/0xb0 [<c1058350>] warn_slowpath_null+0x20/0x30 [<c15bbca6>] ip_cmsg_recv_pktinfo+0xa6/0xb0 [<c15bbdd7>] ip_cmsg_recv+0x127/0x260 [<c154f82d>] ? skb_dequeue+0x4d/0x70 [<c1555523>] ? skb_copy_datagram_iovec+0x53/0x300 [<c178e834>] ? sub_preempt_count+0x24/0x50 [<c15bdd2d>] ip_recv_error+0x23d/0x270 [<c15de554>] udp_recvmsg+0x264/0x2b0 [<c15ea659>] inet_recvmsg+0xd9/0x130 [<c1547752>] sock_recvmsg+0xf2/0x120 [<c11179cb>] ? might_fault+0x4b/0xa0 [<c15546bc>] ? verify_iovec+0x4c/0xc0 [<c1547660>] ? sock_recvmsg_nosec+0x100/0x100 [<c1548294>] __sys_recvmsg+0x114/0x1e0 [<c1093895>] ? __lock_acquire+0x365/0x780 [<c1148b66>] ? fget_light+0xa6/0x3e0 [<c1148b7f>] ? fget_light+0xbf/0x3e0 [<c1148aee>] ? fget_light+0x2e/0x3e0 [<c1549f29>] sys_recvmsg+0x39/0x60 Close bug https://bugzilla.kernel.org/show_bug.cgi?id=34622 Reported-by: Witold Baryluk <baryluk@smp.if.uj.edu.pl> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> CC: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2011-05-18 02:21:31 -04:00
..
datagram.c	Fix a typo in datagram.c and sctp/socket.c.	2010-12-06 13:10:11 -08:00
dev_addr_lists.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2011-03-18 10:37:40 -07:00
dev.c	net: Change netdev_fix_features messages loglevel	2011-05-17 15:44:10 -04:00
drop_monitor.c	net: fix incorrect spelling in drop monitor protocol	2011-03-21 18:20:26 -07:00
dst.c	net: Add initial_ref arg to dst_alloc().	2011-02-17 15:44:00 -08:00
ethtool.c	net: ethtool: fix IPV6 checksum feature name string	2011-05-17 16:50:02 -04:00
fib_rules.c	net: Put flowi_* prefix on AF independent members of struct flowi	2011-03-12 15:08:44 -08:00
filter.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
flow.c	net: Make flow cache paths use a const struct flowi.	2011-02-22 18:44:31 -08:00
gen_estimator.c	pkt_sched: remov unnecessary bh_disable	2010-09-10 12:47:59 -07:00
gen_stats.c	net/core: EXPORT_SYMBOL cleanups	2010-07-12 12:57:55 -07:00
iovec.c	net: Limit socket I/O iovec total length to INT_MAX.	2010-10-28 11:47:52 -07:00
kmap_skb.h	[PATCH] severing skbuff.h -> highmem.h	2006-12-04 02:00:29 -05:00
link_watch.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
Makefile	net: support time stamping in phy devices.	2010-07-18 19:15:26 -07:00
neighbour.c	neigh: __rcu annotations	2011-01-20 16:59:34 -08:00
net_namespace.c	net_ns: add __rcu annotations	2010-10-25 14:18:27 -07:00
net-sysfs.c	net: rename group sysfs entry to netdev_group	2011-02-09 19:16:15 -08:00
net-sysfs.h	xps: Add CONFIG_XPS	2010-11-28 18:24:14 -08:00
net-traces.c	netdev: Add tracepoints to netdev layer	2010-09-07 17:51:33 +02:00
netevent.c	net/core: EXPORT_SYMBOL cleanups	2010-07-12 12:57:55 -07:00
netpoll.c	bond: service netpoll arp queue on master device	2011-02-27 20:11:54 -08:00
pktgen.c	kthread: use kthread_create_on_node()	2011-03-22 17:44:01 -07:00
request_sock.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2010-12-08 13:47:38 -08:00
rtnetlink.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
scm.c	Allow passing O_PATH descriptors via SCM_RIGHTS datagrams	2011-03-15 02:21:45 -04:00
skbuff.c	net: add skb_dst_force() in sock_queue_err_skb()	2011-05-18 02:21:31 -04:00
sock.c	Fix common misspellings	2011-03-31 11:26:23 -03:00
stream.c	net: Fix the condition passed to sk_wait_event()	2010-10-03 20:41:32 -07:00
sysctl_net_core.c	rps: add __rcu annotations	2010-10-25 14:18:27 -07:00
timestamping.c	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2010-12-17 12:27:22 -08:00
user_dma.c	net/core/user_dma.c: Use frag list abstraction interfaces.	2009-06-09 00:19:10 -07:00
utils.c	net: return operator cleanup	2010-09-23 14:33:39 -07:00