Cesar Eduardo Barros
597781f3e5
kmap_atomic: make kunmap_atomic() harder to misuse
...
kunmap_atomic() is currently at level -4 on Rusty's "Hard To Misuse"
list[1] ("Follow common convention and you'll get it wrong"), except in
some architectures when CONFIG_DEBUG_HIGHMEM is set[2][3].
kunmap() takes a pointer to a struct page; kunmap_atomic(), however, takes
takes a pointer to within the page itself. This seems to once in a while
trip people up (the convention they are following is the one from
kunmap()).
Make it much harder to misuse, by moving it to level 9 on Rusty's list[4]
("The compiler/linker won't let you get it wrong"). This is done by
refusing to build if the type of its first argument is a pointer to a
struct page.
The real kunmap_atomic() is renamed to kunmap_atomic_notypecheck()
(which is what you would call in case for some strange reason calling it
with a pointer to a struct page is not incorrect in your code).
The previous version of this patch was compile tested on x86-64.
[1] http://ozlabs.org/~rusty/index.cgi/tech/2008-04-01.html
[2] In these cases, it is at level 5, "Do it right or it will always
break at runtime."
[3] At least mips and powerpc look very similar, and sparc also seems to
share a common ancestor with both; there seems to be quite some
degree of copy-and-paste coding here. The include/asm/highmem.h file
for these three archs mention x86 CPUs at its top.
[4] http://ozlabs.org/~rusty/index.cgi/tech/2008-03-30.html
[5] As an aside, could someone tell me why mn10300 uses unsigned long as
the first parameter of kunmap_atomic() instead of void *?
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Cc: Russell King <linux@arm.linux.org.uk> (arch/arm)
Cc: Ralf Baechle <ralf@linux-mips.org> (arch/mips)
Cc: David Howells <dhowells@redhat.com> (arch/frv, arch/mn10300)
Cc: Koichi Yasutake <yasutake.koichi@jp.panasonic.com> (arch/mn10300)
Cc: Kyle McMartin <kyle@mcmartin.ca> (arch/parisc)
Cc: Helge Deller <deller@gmx.de> (arch/parisc)
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org> (arch/parisc)
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> (arch/powerpc)
Cc: Paul Mackerras <paulus@samba.org> (arch/powerpc)
Cc: "David S. Miller" <davem@davemloft.net> (arch/sparc)
Cc: Thomas Gleixner <tglx@linutronix.de> (arch/x86)
Cc: Ingo Molnar <mingo@redhat.com> (arch/x86)
Cc: "H. Peter Anvin" <hpa@zytor.com> (arch/x86)
Cc: Arnd Bergmann <arnd@arndb.de> (include/asm-generic)
Cc: Rusty Russell <rusty@rustcorp.com.au> ("Hard To Misuse" list)
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-08-09 20:44:54 -07:00
..
2009-08-03 09:05:00 +01:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-08-17 18:32:09 -07:00
2009-12-12 13:08:14 +01:00
2008-12-09 00:50:13 -08:00
2008-08-31 20:59:37 -07:00
2010-05-17 07:57:27 -07:00
2010-05-17 07:57:27 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-12-03 16:04:52 -08:00
2010-04-06 15:52:11 -07:00
2008-07-27 23:00:59 +02:00
2009-06-11 21:02:14 +02:00
2009-11-27 17:33:43 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-09-02 00:49:38 -07:00
2009-01-14 19:56:50 -08:00
2010-06-29 00:38:02 -07:00
2009-11-26 09:16:19 +01:00
2009-11-26 09:16:19 +01:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-03-12 15:52:32 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-04-12 22:37:07 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-07-24 09:57:52 -06:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-03-12 15:52:42 -08:00
2008-08-29 02:15:23 -07:00
2008-08-29 23:10:21 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-12-16 07:20:12 -08:00
2010-01-29 08:22:01 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-06-07 05:01:00 -07:00
2008-07-27 23:00:59 +02:00
2010-05-18 16:10:44 -06:00
2010-02-05 12:22:42 +01:00
2009-12-17 11:03:24 -05:00
2008-08-31 20:56:15 -07:00
2008-07-27 23:00:59 +02:00
2008-08-29 02:15:13 -07:00
2010-07-24 09:58:21 -06:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-06-16 04:56:53 -07:00
2008-07-27 23:00:59 +02:00
2008-07-30 15:40:50 -07:00
2008-07-27 23:00:59 +02:00
2008-08-24 20:33:56 -07:00
2009-10-01 13:45:13 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-08-09 20:44:54 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-12-04 09:17:09 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-03-03 02:30:37 -08:00
2010-03-03 02:30:37 -08:00
2008-08-29 02:15:23 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-08-29 02:15:21 -07:00
2008-09-10 23:07:41 -07:00
2008-07-27 23:00:59 +02:00
2009-01-04 15:44:52 -08:00
2009-10-01 13:45:13 -07:00
2009-08-03 09:56:52 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-04-13 01:50:43 -07:00
2008-07-27 23:00:59 +02:00
2009-01-02 21:31:13 -08:00
2009-01-14 19:56:50 -08:00
2008-11-01 21:44:01 -07:00
2009-01-30 00:03:53 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-06-16 19:47:51 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-08-17 18:32:09 -07:00
2009-11-16 02:54:09 -08:00
2008-07-27 23:00:59 +02:00
2010-06-09 11:12:36 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-08-17 18:32:10 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-08-29 14:16:48 -07:00
2008-07-27 23:00:59 +02:00
2009-06-16 04:56:21 -07:00
2010-07-14 17:14:00 +10:00
2008-08-24 22:08:34 -07:00
2008-07-27 23:00:59 +02:00
2009-09-22 07:17:41 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-03-16 14:40:39 +10:30
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-03-19 12:51:25 +01:00
2008-12-26 15:35:41 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-09-10 06:28:20 -07:00
2008-07-27 23:00:59 +02:00
2008-09-08 15:40:45 -07:00
2009-01-02 21:15:25 -08:00
2008-07-27 23:00:59 +02:00
2009-01-08 16:58:42 -08:00
2009-01-08 16:58:42 -08:00
2008-07-27 23:00:59 +02:00
2010-01-14 03:14:53 -08:00
2009-06-11 21:02:17 +02:00
2008-07-27 23:00:59 +02:00
2010-01-12 02:46:16 -08:00
2010-07-24 09:58:21 -06:00
2008-07-27 23:00:59 +02:00
2010-03-12 15:52:41 -08:00
2010-03-12 15:52:41 -08:00
2010-03-12 15:52:42 -08:00
2008-07-27 23:00:59 +02:00
2009-01-30 00:03:53 -08:00
2008-07-27 23:00:59 +02:00
2009-06-16 04:56:23 -07:00
2008-07-27 23:00:59 +02:00
2010-06-08 23:31:27 +02:00
2010-03-03 08:08:49 -08:00
2009-07-27 12:10:38 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-05-25 23:36:31 -07:00
2010-02-20 16:41:46 +00:00
2008-07-27 23:00:59 +02:00
2009-08-17 18:32:10 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-03-18 23:51:57 -07:00
2008-07-27 23:00:59 +02:00
2009-01-02 18:35:29 -08:00
2009-01-02 19:32:59 -08:00
2008-11-02 00:15:38 -07:00
2008-07-27 23:00:59 +02:00
2010-07-30 00:03:58 -06:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-01-02 19:42:12 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-11-07 22:41:03 -08:00
2008-07-27 23:00:59 +02:00
2010-05-27 09:12:54 -07:00
2008-07-27 23:00:59 +02:00
2009-03-02 15:41:30 -08:00
2008-12-27 00:35:12 -08:00
2008-07-27 23:00:59 +02:00
2008-10-13 09:51:40 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-01-02 19:34:46 -08:00
2009-01-02 21:10:04 -08:00
2009-06-11 21:01:52 +02:00
2009-11-02 04:19:42 -08:00
2009-09-24 09:34:47 +09:30
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-10-12 13:26:31 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-12-14 23:55:32 +01:00
2009-12-14 23:55:32 +01:00
2009-12-14 23:55:32 +01:00
2008-07-27 23:00:59 +02:00
2008-12-07 00:04:30 -08:00
2008-07-27 23:00:59 +02:00
2008-08-31 01:40:12 -07:00
2010-03-27 08:36:18 -07:00
2008-09-06 19:30:17 +01:00
2009-12-10 23:32:10 -08:00
2009-12-10 23:32:10 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-01-06 18:10:27 -08:00
2008-07-27 23:00:59 +02:00
2010-02-17 13:07:21 +01:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-08-17 18:32:10 -07:00
2010-03-03 08:08:49 -08:00
2008-07-27 23:00:59 +02:00
2008-11-12 23:51:54 -08:00
2008-07-27 23:00:59 +02:00
2010-05-14 11:13:27 +02:00
2010-05-14 11:13:27 +02:00
2008-07-27 23:00:59 +02:00
2008-09-19 21:18:03 -07:00
2009-01-06 13:19:28 -08:00
2008-07-27 23:00:59 +02:00
2010-01-15 01:34:28 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-07-27 12:10:38 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-01-20 19:04:42 -08:00
2008-07-27 23:00:59 +02:00
2009-06-16 04:56:11 -07:00
2009-01-02 21:33:05 -08:00
2008-12-04 09:16:47 -08:00
2008-07-27 23:00:59 +02:00
2008-12-04 09:17:03 -08:00
2008-07-27 23:00:59 +02:00
2009-08-16 18:25:00 -07:00
2010-01-05 20:41:48 -08:00
2010-01-05 20:41:48 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2010-03-12 15:52:32 -08:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-08-31 20:59:37 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2009-09-23 07:39:29 -07:00
2008-09-11 23:46:40 -07:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00
2008-07-27 23:00:59 +02:00