Kazuya Mio ad4fb9cafe ext4: fix 32bit overflow in ext4_ext_find_goal() ... ext4_ext_find_goal() returns an ideal physical block number that the block allocator tries to allocate first. However, if a required file offset is smaller than the existing extent's one, ext4_ext_find_goal() returns a wrong block number because it may overflow at "block - le32_to_cpu(ex->ee_block)". This patch fixes the problem. ext4_ext_find_goal() will also return a wrong block number in case a file offset of the existing extent is too big. In this case, the ideal physical block number is fixed in ext4_mb_initialize_context(), so it's no problem. reproduce: # dd if=/dev/zero of=/mnt/mp1/tmp bs=127M count=1 oflag=sync # dd if=/dev/zero of=/mnt/mp1/file bs=512K count=1 seek=1 oflag=sync # filefrag -v /mnt/mp1/file Filesystem type is: ef53 File size of /mnt/mp1/file is 1048576 (256 blocks, blocksize 4096) ext logical physical expected length flags 0 128 67456 128 eof /mnt/mp1/file: 2 extents found # rm -rf /mnt/mp1/tmp # echo $((512*4096)) > /sys/fs/ext4/loop0/mb_stream_req # dd if=/dev/zero of=/mnt/mp1/file bs=512K count=1 oflag=sync conv=notrunc result (linux-2.6.37-rc2 + ext4 patch queue): # filefrag -v /mnt/mp1/file Filesystem type is: ef53 File size of /mnt/mp1/file is 1048576 (256 blocks, blocksize 4096) ext logical physical expected length flags 0 0 33280 128 1 128 67456 33407 128 eof /mnt/mp1/file: 2 extents found result(apply this patch): # filefrag -v /mnt/mp1/file Filesystem type is: ef53 File size of /mnt/mp1/file is 1048576 (256 blocks, blocksize 4096) ext logical physical expected length flags 0 0 66560 128 1 128 67456 66687 128 eof /mnt/mp1/file: 2 extents found Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>		2011-01-10 12:12:28 -05:00
..
acl.c	ext4: update ctime when changing the file's permission by setfacl	2010-06-15 12:19:59 -04:00
acl.h
balloc.c	ext4: rename mark_bitmap_end() to ext4_mark_bitmap_end()	2010-10-27 21:30:15 -04:00
bitmap.c
block_validity.c	ext4: rename {exit,init}_ext4_*() to ext4_{exit,init}_*()	2010-10-27 21:30:14 -04:00
dir.c	ext4: Use ext4_error_file() to print the pathname to the corrupted inode	2011-01-10 12:10:55 -05:00
ext4_extents.h	ext4: rename {ext,idx}_pblock and inline small extent functions	2010-10-27 21:30:14 -04:00
ext4_jbd2.c	ext4: Pass line numbers to ext4_error() and friends	2010-07-27 11:56:40 -04:00
ext4_jbd2.h	ext4: Pass line numbers to ext4_error() and friends	2010-07-27 11:56:40 -04:00
ext4.h	ext4: Use ext4_error_file() to print the pathname to the corrupted inode	2011-01-10 12:10:55 -05:00
extents.c	ext4: fix 32bit overflow in ext4_ext_find_goal()	2011-01-10 12:12:28 -05:00
file.c	ext4: improve llseek error handling for overly large seek offsets	2010-10-27 21:30:06 -04:00
fsync.c	Merge branch 'next' into upstream-merge	2010-10-27 23:44:47 -04:00
hash.c
ialloc.c	Merge branch 'next' into upstream-merge	2010-10-27 23:44:47 -04:00
inode.c	ext4: Use pr_warning_ratelimited() instead of printk_ratelimit()	2010-12-17 10:40:47 -05:00
ioctl.c	ext4: Add EXT4_IOC_TRIM ioctl to handle batched discard	2010-11-19 21:47:07 -05:00
Kconfig
Makefile	ext4: use bio layer instead of buffer layer in mpage_da_submit_io	2010-10-27 21:30:10 -04:00
mballoc.c	ext4: remove warning message from ext4_issue_discard helper	2011-01-10 12:09:59 -05:00
mballoc.h
migrate.c	ext4: ext4_ext_migrate should use NULL not 0	2011-01-10 12:11:00 -05:00
move_extent.c	ext4: rename {ext,idx}_pblock and inline small extent functions	2010-10-27 21:30:14 -04:00
namei.c	ext4: add more error checks to ext4_mkdir()	2011-01-10 12:11:16 -05:00
page-io.c	ext4: test the correct variable in ext4_init_pageio()	2011-01-10 12:10:44 -05:00
resize.c	Merge branch 'next' into upstream-merge	2010-10-27 23:44:47 -04:00
super.c	ext4: Use ext4_error_file() to print the pathname to the corrupted inode	2011-01-10 12:10:55 -05:00
symlink.c
xattr_security.c
xattr_trusted.c
xattr_user.c
xattr.c	ext2,ext3,ext4: clarify comment for extN_xattr_set_handle	2011-01-10 12:10:30 -05:00
xattr.h	ext4: fix compile with CONFIG_EXT4_FS_XATTR disabled	2010-10-28 09:29:17 -07:00