Dmitry Monakhov aef4885ae1 ext4: move error report out of atomic context in ext4_init_block_bitmap() ... Error report likely result in IO so it is bad idea to do it from atomic context. This patch should fix following issue: BUG: sleeping function called from invalid context at include/linux/buffer_head.h:349 in_atomic(): 1, irqs_disabled(): 0, pid: 137, name: kworker/u128:1 5 locks held by kworker/u128:1/137: #0: ("writeback"){......}, at: [<ffffffff81085618>] process_one_work+0x228/0x4d0 #1: ((&(&wb->dwork)->work)){......}, at: [<ffffffff81085618>] process_one_work+0x228/0x4d0 #2: (jbd2_handle){......}, at: [<ffffffff81242622>] start_this_handle+0x712/0x7b0 #3: (&ei->i_data_sem){......}, at: [<ffffffff811fa387>] ext4_map_blocks+0x297/0x430 #4: (&(&bgl->locks[i].lock)->rlock){......}, at: [<ffffffff811f3180>] ext4_read_block_bitmap_nowait+0x5d0/0x630 CPU: 3 PID: 137 Comm: kworker/u128:1 Not tainted 3.17.0-rc2-00184-g82752e4 #165 Hardware name: Intel Corporation W2600CR/W2600CR, BIOS SE5C600.86B.99.99.x028.061320111235 06/13/2011 Workqueue: writeback bdi_writeback_workfn (flush-1:0) 0000000000000411 ffff880813777288 ffffffff815c7fdc ffff880813777288 ffff880813a8bba0 ffff8808137772a8 ffffffff8108fb30 ffff880803e01e38 ffff880803e01e38 ffff8808137772c8 ffffffff811a8d53 ffff88080ecc6000 Call Trace: [<ffffffff815c7fdc>] dump_stack+0x51/0x6d [<ffffffff8108fb30>] __might_sleep+0xf0/0x100 [<ffffffff811a8d53>] __sync_dirty_buffer+0x43/0xe0 [<ffffffff811a8e03>] sync_dirty_buffer+0x13/0x20 [<ffffffff8120f581>] ext4_commit_super+0x1d1/0x230 [<ffffffff8120fa03>] save_error_info+0x23/0x30 [<ffffffff8120fd06>] __ext4_error+0xb6/0xd0 [<ffffffff8120f260>] ? ext4_group_desc_csum+0x140/0x190 [<ffffffff811f2d8c>] ext4_read_block_bitmap_nowait+0x1dc/0x630 [<ffffffff8122e23a>] ext4_mb_init_cache+0x21a/0x8f0 [<ffffffff8113ae95>] ? lru_cache_add+0x55/0x60 [<ffffffff8112e16c>] ? add_to_page_cache_lru+0x6c/0x80 [<ffffffff8122eaa0>] ext4_mb_init_group+0x190/0x280 [<ffffffff8122ec51>] ext4_mb_good_group+0xc1/0x190 [<ffffffff8123309a>] ext4_mb_regular_allocator+0x17a/0x410 [<ffffffff8122c821>] ? ext4_mb_use_preallocated+0x31/0x380 [<ffffffff81233535>] ? ext4_mb_new_blocks+0x205/0x8e0 [<ffffffff8116ed5c>] ? kmem_cache_alloc+0xfc/0x180 [<ffffffff812335b0>] ext4_mb_new_blocks+0x280/0x8e0 [<ffffffff8116f2c4>] ? __kmalloc+0x144/0x1c0 [<ffffffff81221797>] ? ext4_find_extent+0x97/0x320 [<ffffffff812257f4>] ext4_ext_map_blocks+0xbc4/0x1050 [<ffffffff811fa387>] ? ext4_map_blocks+0x297/0x430 [<ffffffff811fa3ab>] ext4_map_blocks+0x2bb/0x430 [<ffffffff81200e43>] ? ext4_init_io_end+0x23/0x50 [<ffffffff811feb44>] ext4_writepages+0x564/0xaf0 [<ffffffff815cde3b>] ? _raw_spin_unlock+0x2b/0x40 [<ffffffff810ac7bd>] ? lock_release_non_nested+0x2fd/0x3c0 [<ffffffff811a009e>] ? writeback_sb_inodes+0x10e/0x490 [<ffffffff811a009e>] ? writeback_sb_inodes+0x10e/0x490 [<ffffffff811377e3>] do_writepages+0x23/0x40 [<ffffffff8119c8ce>] __writeback_single_inode+0x9e/0x280 [<ffffffff811a026b>] writeback_sb_inodes+0x2db/0x490 [<ffffffff811a0664>] wb_writeback+0x174/0x2d0 [<ffffffff810ac359>] ? lock_release_holdtime+0x29/0x190 [<ffffffff811a0863>] wb_do_writeback+0xa3/0x200 [<ffffffff811a0a40>] bdi_writeback_workfn+0x80/0x230 [<ffffffff81085618>] ? process_one_work+0x228/0x4d0 [<ffffffff810856cd>] process_one_work+0x2dd/0x4d0 [<ffffffff81085618>] ? process_one_work+0x228/0x4d0 [<ffffffff81085c1d>] worker_thread+0x35d/0x460 [<ffffffff810858c0>] ? process_one_work+0x4d0/0x4d0 [<ffffffff810858c0>] ? process_one_work+0x4d0/0x4d0 [<ffffffff8108a885>] kthread+0xf5/0x100 [<ffffffff810990e5>] ? local_clock+0x25/0x30 [<ffffffff8108a790>] ? __init_kthread_worker+0x70/0x70 [<ffffffff815ce2ac>] ret_from_fork+0x7c/0xb0 [<ffffffff8108a790>] ? __init_kthread_work Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@vger.kernel.org		2014-10-13 03:42:12 -04:00
..
9p	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
adfs	adfs: add __printf verification, fix format/argument mismatches	2014-08-08 15:57:24 -07:00
affs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
afs	AFS: Correctly assemble the client UUID	2014-07-29 10:14:36 -07:00
autofs4	autofs4: comment typo: remove a a doubled word	2014-08-08 15:57:19 -07:00
befs	fs/befs/linuxvfs.c: check superblock before dump operation	2014-08-08 15:57:20 -07:00
bfs	fs/bfs: use bfs prefix for dump_imap	2014-08-08 15:57:24 -07:00
btrfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2014-08-27 09:14:17 -07:00
cachefiles	fs/cachefiles: replace kerror by pr_err	2014-06-06 16:08:14 -07:00
ceph	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client	2014-08-13 17:43:29 -06:00
cifs	Merge branch 'for-linus' of git://git.samba.org/sfrench/cifs-2.6	2014-08-20 18:33:21 -05:00
coda	fs/coda: use linux/uaccess.h	2014-08-08 15:57:20 -07:00
configfs	fs/configfs: use pr_fmt	2014-06-04 16:53:53 -07:00
cramfs	fs/cramfs/inode.c: use linux/uaccess.h	2014-08-08 15:57:25 -07:00
debugfs	fs: debugfs: remove trailing whitespace	2014-07-09 16:58:21 -07:00
devpts	fs/devpts/inode.c: convert printk to pr_foo()	2014-06-06 16:08:14 -07:00
dlm	fs/dlm/debug_fs.c: remove unnecessary null test before debugfs_remove	2014-08-08 15:57:27 -07:00
ecryptfs	write_iter variants of {__,}generic_file_aio_write()	2014-05-06 17:38:00 -04:00
efivarfs	fs/efivarfs/super.c: use static const for dentry_operations	2014-06-04 16:54:14 -07:00
efs	fs/efs/namei.c: return is not a function	2014-08-08 15:57:18 -07:00
exofs	fs/exofs/ore_raid.c: replace count*size kzalloc by kcalloc	2014-08-08 15:57:24 -07:00
exportfs	fs/exportfs/expfs.c: kernel-doc warning fixes	2014-06-04 16:54:14 -07:00
ext2	fs/ext2/super.c: Drop memory allocation cast	2014-07-15 22:40:22 +02:00
ext3	ext3: Count internal journal as bsddf overhead in ext3_statfs	2014-08-19 23:16:51 +02:00
ext4	ext4: move error report out of atomic context in ext4_init_block_bitmap()	2014-10-13 03:42:12 -04:00
f2fs	f2fs: use for_each_set_bit to simplify the code	2014-08-04 13:20:53 -07:00
fat	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
freevxfs	Major changes for 3.14 include support for the newly added ZERO_RANGE	2014-04-04 15:39:39 -07:00
fscache	fs/fscache: make ctl_table static	2014-08-06 18:01:12 -07:00
fuse	switch iov_iter_get_pages() to passing maximal number of pages	2014-08-07 14:40:11 -04:00
gfs2	Merge branch 'sched/urgent' into sched/core, to merge fixes before applying new changes	2014-07-28 10:03:00 +02:00
hfs	write_iter variants of {__,}generic_file_aio_write()	2014-05-06 17:38:00 -04:00
hfsplus	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
hostfs	hostfs: support rename flags	2014-08-07 14:40:09 -04:00
hpfs	fs/hpfs/dnode.c: fix suspect code indent	2014-08-08 15:57:22 -07:00
hppfs
hugetlbfs	fs/hugetlbfs/inode.c: remove null test before kfree	2014-06-04 16:54:11 -07:00
isofs	isofs: Fix unbounded recursion when processing relocated directories	2014-08-19 18:29:30 +02:00
jbd	jbd/jbd2: use non-movable memory for the jbd superblock	2014-09-04 22:36:35 -04:00
jbd2	jbd2: simplify calling convention around __jbd2_journal_clean_checkpoint_list	2014-09-18 00:58:12 -04:00
jffs2	MTD updates for 3.17-rc1	2014-08-08 18:13:21 -07:00
jfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
kernfs	Merge 3.16-rc6 into driver-core-next	2014-07-21 10:07:25 -07:00
lockd	fs: lockd: Use ktime_get_ns()	2014-07-23 15:01:44 -07:00
logfs	fs/logfs/readwrite.c: kernel-doc warning fixes	2014-08-06 18:01:12 -07:00
minix	minix zmap block counts calculation fix	2014-08-08 15:57:20 -07:00
ncpfs	fs/ncpfs/getopt.c: replace simple_strtoul by kstrtoul	2014-06-04 16:54:21 -07:00
nfs	nfs: Don't busy-wait on SIGKILL in __nfs_iocounter_wait	2014-08-22 18:04:44 -04:00
nfs_common	fs/nfs_common/nfsacl.c: move EXPORT symbol after functions	2014-07-12 18:43:42 -04:00
nfsd	Merge branch 'for-3.17' of git://linux-nfs.org/~bfields/linux	2014-08-09 14:31:18 -07:00
nilfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-08-11 11:44:11 -07:00
nls
notify	list: fix order of arguments for hlist_add_after(_rcu)	2014-08-06 18:01:24 -07:00
ntfs	ntfs: kernel-doc warning fixes	2014-08-06 18:01:12 -07:00
ocfs2	fs/ocfs2/slot_map.c: replace count*size kzalloc by kcalloc	2014-08-06 18:01:13 -07:00
omfs	fs/omfs/inode.c: replace count*size kzalloc by kcalloc	2014-08-08 15:57:25 -07:00
openpromfs	fs: push sync_filesystem() down to the file system's remount_fs()	2014-03-13 10:14:33 -04:00
proc	Revert "proc: Point /proc/{mounts,net} at /proc/thread-self/{mounts,net} instead of /proc/self/{mounts,net}"	2014-08-10 21:24:59 -07:00
pstore	fs/pstore/ram_core.c: replace count*size kmalloc by kmalloc_array	2014-08-08 15:57:25 -07:00
qnx4	fs: push sync_filesystem() down to the file system's remount_fs()	2014-03-13 10:14:33 -04:00
qnx6	fs/qnx6: update debugging to current functions	2014-08-08 15:57:26 -07:00
quota	fs/quota: kernel-doc warning fixes	2014-07-15 22:40:23 +02:00
ramfs	fs/ramfs/file-nommu.c: replace count*size kzalloc by kcalloc	2014-08-08 15:57:18 -07:00
reiserfs	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2014-08-13 17:45:40 -06:00
romfs	fs/romfs/super.c: add blank line after declarations	2014-08-08 15:57:25 -07:00
squashfs	fs/squashfs/super.c: logging cleanup	2014-08-06 18:01:13 -07:00
sysfs	kernfs: move the last knowledge of sysfs out from kernfs	2014-06-03 08:11:18 -07:00
sysv	write_iter variants of {__,}generic_file_aio_write()	2014-05-06 17:38:00 -04:00
ubifs	UBIFS: Add log overlap assertions	2014-07-31 15:52:51 +03:00
udf	udf: avoid unneeded up_write when fail to add entry in ->symlink	2014-08-19 18:29:30 +02:00
ufs	fs/ufs/inode.c: kernel-doc warning fixes	2014-08-08 15:57:21 -07:00
xfs	Merge branch 'xfs-misc-fixes-3.17-2' into for-next	2014-08-04 13:55:27 +10:00
aio.c	aio: fix reqs_available handling	2014-08-24 15:47:27 -07:00
anon_inodes.c	vfs: Allocate anon_inode_inode in anon_inode_init()	2014-03-27 09:52:54 -07:00
attr.c	fs,userns: Change inode_capable to capable_wrt_inode_uidgid	2014-06-10 13:57:22 -07:00
bad_inode.c	bad_inode: add ->rename2()	2014-08-07 14:40:09 -04:00
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	Merge branch 'x86/vdso' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next	2014-06-05 08:05:29 -07:00
binfmt_em86.c
binfmt_flat.c	fs/binfmt_flat.c: make old_reloc() static	2014-06-04 16:54:21 -07:00
binfmt_misc.c	binfmt_misc: add missing 'break' statement	2014-04-03 16:21:16 -07:00
binfmt_script.c
binfmt_som.c
block_dev.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
buffer.c	vfs: fix data corruption when blocksize < pagesize for mmaped data	2014-10-01 21:49:18 -04:00
char_dev.c
compat_binfmt_elf.c	binfmt_elf: add ELF_HWCAP2 to compat auxv entries	2014-03-04 08:05:21 +00:00
compat_ioctl.c	Bluetooth: Move HCI socket definitions into its own header file	2014-07-11 13:53:04 +03:00
compat.c	locks: rename file-private locks to "open file description locks"	2014-04-22 08:23:58 -04:00
coredump.c	coredump: fix the setting of PF_DUMPCORE	2014-07-23 15:10:54 -07:00
dcache.c	fs: mark __d_obtain_alias static	2014-08-07 14:40:11 -04:00
dcookies.c	fs/compat: fix lookup_dcookie() parameter handling	2014-01-29 16:22:40 -08:00
direct-io.c	switch iov_iter_get_pages() to passing maximal number of pages	2014-08-07 14:40:11 -04:00
drop_caches.c	fs: convert use of typedef ctl_table to struct ctl_table	2014-06-06 16:08:16 -07:00
eventfd.c
eventpoll.c	epoll: fix use-after-free in eventpoll_release_file	2014-06-16 17:21:59 -10:00
exec.c	fork/exec: cleanup mm initialization	2014-08-08 15:57:23 -07:00
fcntl.c	shm: add sealing API	2014-08-08 15:57:31 -07:00
fhandle.c
file_table.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-06-12 10:30:18 -07:00
file.c	fs/file.c: don't open-code kvfree()	2014-05-06 17:31:10 -04:00
filesystems.c	sys_sysfs: Add CONFIG_SYSFS_SYSCALL	2014-04-03 16:21:05 -07:00
fs_pin.c	make fs/{namespace,super}.c forget about acct.h	2014-08-07 14:40:09 -04:00
fs_struct.c
fs-writeback.c	sched: Remove proliferation of wait_on_bit() action functions	2014-07-16 15:10:39 +02:00
inode.c	mm: allow drivers to prevent new writable mappings	2014-08-08 15:57:31 -07:00
internal.h	make fs/{namespace,super}.c forget about acct.h	2014-08-07 14:40:09 -04:00
ioctl.c
Kconfig	kernfs: add CONFIG_KERNFS	2014-02-07 16:08:57 -08:00
Kconfig.binfmt
libfs.c	fs/libfs.c: add generic data flush to fsync	2014-06-04 16:53:55 -07:00
locks.c	locks: move locks_free_lock calls in do_fcntl_add_lease outside spinlock	2014-08-14 10:07:47 -04:00
Makefile	take fs_pin stuff to fs/*	2014-08-07 14:40:08 -04:00
mbcache.c	fs/mbcache: replace __builtin_log2() with ilog2()	2014-06-25 22:08:29 -04:00
mount.h	death to mnt_pinned	2014-08-07 14:40:09 -04:00
mpage.c	fs/block_dev.c: add bdev_read_page() and bdev_write_page()	2014-06-04 16:54:02 -07:00
namei.c	namei: trivial fix to vfs_rename_dir comment	2014-08-07 14:40:10 -04:00
namespace.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-08-11 11:44:11 -07:00
no-block.c
open.c	vfs: fix check for fallocate on active swapfile	2014-08-01 02:36:04 -04:00
pipe.c	new helper: copy_page_from_iter()	2014-05-06 17:39:42 -04:00
pnode.c	smarter propagate_mnt()	2014-04-01 23:19:08 -04:00
pnode.h	smarter propagate_mnt()	2014-04-01 23:19:08 -04:00
posix_acl.c	posix_acl: handle NULL ACL in posix_acl_equiv_mode	2014-05-06 13:58:42 -04:00
proc_namespace.c	namespaces: Use task_lock and not rcu to protect nsproxy	2014-07-29 18:08:50 -07:00
read_write.c	switch simple generic_file_aio_read() users to ->read_iter()	2014-05-06 17:37:55 -04:00
readdir.c	fanotify: create FAN_ACCESS event for readdir	2014-06-04 16:53:52 -07:00
select.c
seq_file.c	fs/seq_file: fallback to vmalloc allocation	2014-07-03 09:21:54 -07:00
signalfd.c
splice.c	Merge commit '9f12600fe425bc28f0ccba034a77783c09c15af4' into for-linus	2014-06-12 00:28:09 -04:00
stack.c
stat.c
statfs.c
super.c	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2014-08-13 17:45:40 -06:00
sync.c	Revert "writeback: do not sync data dirtied after sync start"	2014-02-22 02:02:28 +01:00
timerfd.c	timerfd: Use ktime_mono_to_real()	2014-07-23 10:18:02 -07:00
utimes.c
xattr.c	simple_xattr: permit 0-size extended attributes	2014-07-23 15:10:55 -07:00