Paul Menage 6c826818ff /proc/sysvipc/shm: fix 32-bit truncation of segment sizes ...

sysvipc_shm_proc_show() picks between format strings (based on the
expected maximum length of a SHM segment) in a way that prevents gcc from
performing format checks on the seq_printf() parameters.  This hid two
format errors - shp->shm_segsz and shp->shm_nattach are both unsigned
long, but were being printed as unsigned int and signed int respectively.
This leads to 32-bit truncation of SHM segment sizes reported in
/proc/sysvipc/shm.  (And for nattach, but that's less of a problem for
most users).

This patch makes the format string directly visible to gcc's format
specifier checker, and fixes the two broken format specifiers.

Signed-off-by: Paul Menage <menage@google.com>
Cc: Nadia Derbey <Nadia.Derbey@bull.net>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Pierre Peiffer <peifferp@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2008-06-12 18:05:41 -07:00

..

compat_mq.c

…

compat.c

…

ipc_sysctl.c

…

ipcns_notifier.c

…

Makefile

…

mqueue.c

…

msg.c

…

msgutil.c

…

namespace.c

…

sem.c

…

shm.c

…

util.c

…

util.h

…