Julia Lawall
b0d5e15cc4
[SCSI] bnx2fc: adjust duplicate test ...
Delete successive tests to the same location. The code tested the result
of a previous allocation, that itself was already tested. It is changed to
test the result of the most recent allocation.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/ )
// <smpl>
@s exists@
local idexpression y;
expression x,e;
@@
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2013-01-30 14:04:54 +11:00
2013-01-03 15:57:01 -08:00
2012-09-01 08:24:35 -07:00
2013-01-03 15:57:01 -08:00
2012-08-20 14:51:24 -07:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-30 11:54:54 +11:00
2013-01-30 14:04:54 +11:00
2013-01-29 14:15:34 +11:00
2013-01-30 10:48:50 +11:00
2013-01-30 11:58:06 +11:00
2012-09-24 12:21:56 +04:00
2012-12-17 17:15:26 -08:00
2013-01-29 14:00:04 +11:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-10-07 11:52:55 +01:00
2012-11-19 14:16:09 +01:00
2013-01-30 11:42:55 +11:00
2013-01-03 15:57:01 -08:00
2013-01-29 14:15:35 +11:00
2013-01-29 14:15:35 +11:00
2013-01-03 15:57:01 -08:00
2012-11-27 08:59:34 +04:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-30 14:01:45 +11:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-06-28 11:44:36 +02:00
2013-01-03 15:57:01 -08:00
2012-04-22 20:16:49 +02:00
2012-04-22 20:16:49 +02:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-09-14 11:58:53 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-03-28 18:30:03 +01:00
2012-04-05 17:09:40 -07:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-29 13:55:06 +11:00
2012-09-01 08:43:34 -07:00
2013-01-03 15:57:01 -08:00
2012-07-20 08:58:40 +01:00
2012-05-10 09:19:39 +01:00
2013-01-03 15:57:01 -08:00
2012-05-10 09:19:39 +01:00
2013-01-03 15:57:01 -08:00
2012-11-27 08:59:43 +04:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-30 10:48:53 +11:00
2013-01-30 10:48:53 +11:00
2013-01-03 15:57:01 -08:00
2012-09-24 12:10:55 +04:00
2013-01-03 15:57:01 -08:00
2012-12-01 10:09:17 +00:00
2013-01-03 15:57:01 -08:00
2012-03-22 12:55:29 -07:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2012-03-28 18:30:03 +01:00
2012-12-01 10:09:17 +00:00
2013-01-03 15:57:01 -08:00
2012-09-01 08:42:43 -07:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-10-07 11:34:36 +01:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-03-28 18:30:03 +01:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-10-09 12:23:11 +01:00
2012-09-24 12:11:00 +04:00
2012-10-09 12:04:42 +01:00
2012-12-17 08:27:23 -08:00
2012-09-13 16:26:39 -04:00
2012-11-30 09:26:48 +00:00
2012-07-20 09:05:54 +01:00
2012-10-02 08:55:12 +01:00
2012-11-30 09:08:16 +00:00
2012-08-01 09:02:41 -07:00
2013-01-29 13:55:07 +11:00
2012-12-01 10:08:41 +00:00
2012-05-10 09:06:12 +01:00
2012-11-30 17:40:33 -08:00
2012-11-13 21:11:31 -08:00
2012-09-24 12:10:59 +04:00
2012-11-30 09:28:34 +00:00
2012-11-13 22:45:42 -08:00
2012-10-09 16:22:19 +09:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-09-24 13:07:02 +04:00
2012-09-14 17:59:29 +01:00
2013-01-03 15:57:01 -08:00
2012-10-09 12:28:58 +01:00
2012-03-28 18:30:03 +01:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2012-03-28 18:30:03 +01:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
2012-03-27 08:26:36 +01:00
2012-03-28 18:30:03 +01:00
2013-01-03 15:57:01 -08:00
2013-01-03 15:57:01 -08:00
b0d5e15cc4