linux/arch/tile/kernel
Christoph Lameter b4f501916c tile: Replace __get_cpu_var uses
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x).  This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.

Other use cases are for storing and retrieving data from the current
processors percpu area.  __get_cpu_var() can be used as an lvalue when
writing data or on the right side of an assignment.

__get_cpu_var() is defined as :

#define __get_cpu_var(var) (*this_cpu_ptr(&(var)))

__get_cpu_var() always only does an address determination. However, store
and retrieve operations could use a segment prefix (or global register on
other platforms) to avoid the address calculation.

this_cpu_write() and this_cpu_read() can directly take an offset into a
percpu area and use optimized assembly code to read and write per cpu
variables.

This patch converts __get_cpu_var into either an explicit address
calculation using this_cpu_ptr() or into a use of this_cpu operations that
use the offset.  Thereby address calculations are avoided and less registers
are used when code is generated.

At the end of the patch set all uses of __get_cpu_var have been removed so
the macro is removed too.

The patch set includes passes over all arches as well. Once these operations
are used throughout then specialized macros can be defined in non -x86
arches as well in order to optimize per cpu access by f.e.  using a global
register that may be set to the per cpu base.

Transformations done to __get_cpu_var()

1. Determine the address of the percpu instance of the current processor.

	DEFINE_PER_CPU(int, y);
	int *x = &__get_cpu_var(y);

    Converts to

	int *x = this_cpu_ptr(&y);

2. Same as #1 but this time an array structure is involved.

	DEFINE_PER_CPU(int, y[20]);
	int *x = __get_cpu_var(y);

    Converts to

	int *x = this_cpu_ptr(y);

3. Retrieve the content of the current processors instance of a per cpu
variable.

	DEFINE_PER_CPU(int, y);
	int x = __get_cpu_var(y)

   Converts to

	int x = __this_cpu_read(y);

4. Retrieve the content of a percpu struct

	DEFINE_PER_CPU(struct mystruct, y);
	struct mystruct x = __get_cpu_var(y);

   Converts to

	memcpy(&x, this_cpu_ptr(&y), sizeof(x));

5. Assignment to a per cpu variable

	DEFINE_PER_CPU(int, y)
	__get_cpu_var(y) = x;

   Converts to

	__this_cpu_write(y, x);

6. Increment/Decrement etc of a per cpu variable

	DEFINE_PER_CPU(int, y);
	__get_cpu_var(y)++

   Converts to

	__this_cpu_inc(y)

Acked-by: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
2014-08-26 13:45:54 -04:00
..
vdso tile: Convert VDSO timekeeping to the precise mechanism 2014-07-23 10:16:50 -07:00
asm-offsets.c tile: check for correct compiler earlier in asm-offsets.c 2013-09-03 14:53:09 -04:00
backtrace.c arch/tile: big-endian: properly bswap instruction bundles when backtracing 2012-06-18 13:11:21 -04:00
compat_signal.c tile: Use get_signal() signal_setup_done() 2014-08-06 13:03:20 +02:00
compat.c tile: remove stray blank space 2013-09-16 15:47:32 -04:00
early_printk.c tile: various console improvements 2013-08-12 14:46:18 -04:00
entry.S tile: implement gettimeofday() via vDSO 2013-08-13 16:26:21 -04:00
ftrace.c ftrace: Do not pass data to ftrace_dyn_arch_init 2014-03-07 10:06:14 -05:00
hardwall.c proc: convert /proc/$PID/hardwall to seq_file interface 2014-08-08 15:57:23 -07:00
head_32.S tile: parameterize VA and PA space more cleanly 2013-09-03 14:47:34 -04:00
head_64.S tile: parameterize VA and PA space more cleanly 2013-09-03 14:47:34 -04:00
hvglue_trace.c tile: provide traceability for hypervisor calls 2013-08-13 16:26:31 -04:00
hvglue.S tile: provide traceability for hypervisor calls 2013-08-13 16:26:31 -04:00
intvec_32.S tile: Enable NMIs on return from handle_nmi() without errors 2014-03-07 11:19:48 -05:00
intvec_64.S tile: Enable NMIs on return from handle_nmi() without errors 2014-03-07 11:19:48 -05:00
irq.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
kgdb.c tilegx: support KGDB 2013-09-03 14:51:26 -04:00
kprobes.c tile: support kprobes on tilegx 2013-08-30 11:55:53 -04:00
machine_kexec.c arch/tile: support kexec() for tilegx 2012-05-25 12:48:25 -04:00
Makefile tile/perf: Support perf_events on tilegx and tilepro 2014-03-07 11:19:48 -05:00
mcount_64.S tile: ftrace: Remove check of obsolete variable function_trace_stop 2014-07-18 13:57:03 -04:00
messaging.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
module.c mm/vmalloc.c: clean up map_vm_area third argument 2014-08-06 18:01:19 -07:00
pci_gx.c tile: pci: Use irq_alloc/free_hwirq() 2014-05-16 14:05:21 +02:00
pci-dma.c tile PCI RC: make default consistent DMA mask 32-bit 2013-09-03 14:53:37 -04:00
pci.c arch/tile: remove unused variable 'devcap' 2014-04-04 13:11:40 -04:00
perf_event.c tile/perf: Support perf_events on tilegx and tilepro 2014-03-07 11:19:48 -05:00
pmc.c tile: Add support for handling PMC hardware 2014-03-07 11:19:47 -05:00
proc.c tile: convert use of typedef ctl_table to struct ctl_table 2014-06-06 16:08:15 -07:00
process.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
ptrace.c tile: correct r1 value during syscall tracing 2013-08-30 11:56:20 -04:00
reboot.c tile: various console improvements 2013-08-12 14:46:18 -04:00
regs_32.S tile: change <asm/system.h> to <asm/switch_to.h> in comments 2013-09-03 14:53:17 -04:00
regs_64.S tile: change <asm/system.h> to <asm/switch_to.h> in comments 2013-09-03 14:53:17 -04:00
relocate_kernel_32.S tile: remove support for TILE64 2013-09-03 14:53:29 -04:00
relocate_kernel_64.S tile: remove support for TILE64 2013-09-03 14:53:29 -04:00
setup.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
signal.c tile: Use get_signal() signal_setup_done() 2014-08-06 13:03:20 +02:00
single_step.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
smp.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
smpboot.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
stack.c arch: tile: re-use kbasename() helper 2013-09-30 10:34:46 -04:00
sys.c tile: support CONFIG_PREEMPT 2013-08-13 16:26:01 -04:00
sysfs.c tile: support reporting Tilera hypervisor statistics 2013-09-03 14:51:36 -04:00
tile-desc_32.c arch/tile: factor out <arch/opcode.h> header 2011-11-03 16:58:54 -04:00
tile-desc_64.c arch/tile: factor out <arch/opcode.h> header 2011-11-03 16:58:54 -04:00
time.c tile: Replace __get_cpu_var uses 2014-08-26 13:45:54 -04:00
tlb.c tile: do less L1 I-cache eviction 2013-08-30 11:56:34 -04:00
traps.c replace strict_strto* call with kstrto* 2014-05-28 15:47:16 -04:00
unaligned.c arch: tile: kernel: unaligned.c: Cleaning up uninitialized variables 2014-06-07 21:39:11 -04:00
usb.c usb: add host support for the tilegx architecture 2012-07-18 16:40:29 -04:00
vdso.c arm64,ia64,ppc,s390,sh,tile,um,x86,mm: remove default gate area 2014-08-08 15:57:27 -07:00
vmlinux.lds.S tile: make __write_once a synonym for __read_mostly 2013-09-03 14:53:32 -04:00