Linus Torvalds bd3769bfed netfilter: Fix slab corruption. ...

Use the correct pattern for singly linked list insertion and
deletion.  We can also calculate the list head outside of the
mutex.

Fixes: e3b37f11e6e4 ("netfilter: replace list_head with single linked list")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Aaron Conole <aconole@bytheb.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/netfilter/core.c | 108 ++++++++++++++++-----------------------------------
 1 file changed, 33 insertions(+), 75 deletions(-)

2016-10-11 04:44:37 -04:00

..

ipset

…

ipvs

ipvs: use nf_ct_kill helper

2016-08-12 00:43:52 +02:00

core.c

netfilter: Fix slab corruption.

2016-10-11 04:44:37 -04:00

Kconfig

netfilter: nf_tables: add number generator expression

2016-08-22 11:42:22 +02:00

Makefile

netfilter: nf_tables: add range expression

2016-09-25 23:16:42 +02:00

nf_conntrack_acct.c

…

nf_conntrack_amanda.c

…

nf_conntrack_broadcast.c

…

nf_conntrack_core.c

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

2016-09-25 23:34:19 +02:00

nf_conntrack_ecache.c

netfilter: don't rely on DYING bit to detect when destroy event was sent

2016-08-30 11:43:08 +02:00

nf_conntrack_expect.c

netfilter: nf_ct_expect: remove the redundant slash when policy name is empty

2016-08-09 10:38:46 +02:00

nf_conntrack_extend.c

netfilter: move nat hlist_head to nf_conn

2016-07-11 11:47:50 +02:00

nf_conntrack_ftp.c

netfilter: ftp: Remove the useless code

2016-09-07 10:38:00 +02:00

nf_conntrack_h323_asn1.c

netfilter: nf_conntrack_h323: fix off-by-one in DecodeQ931

2016-07-11 12:32:45 +02:00

nf_conntrack_h323_main.c

netfilter: Remove explicit rcu_read_lock in nf_hook_slow

2016-09-24 21:29:53 +02:00

nf_conntrack_h323_types.c

…

nf_conntrack_helper.c

netfilter: Remove explicit rcu_read_lock in nf_hook_slow

2016-09-24 21:29:53 +02:00

nf_conntrack_irc.c

netfilter: Add helper array register/unregister functions

2016-07-21 02:31:53 +02:00

nf_conntrack_l3proto_generic.c

…

nf_conntrack_labels.c

netfilter: connlabels: move set helper to xt_connlabel

2016-07-22 17:05:10 +02:00

nf_conntrack_netbios_ns.c

…

nf_conntrack_netlink.c

netfilter: conntrack: remove packet hotpath stats

2016-09-12 19:59:39 +02:00

nf_conntrack_pptp.c

netfilter: conntrack: get rid of conntrack timer

2016-08-30 11:43:09 +02:00

nf_conntrack_proto_dccp.c

netfilter: conntrack: Only need first 4 bytes to get l4proto ports

2016-08-12 00:41:08 +02:00

nf_conntrack_proto_generic.c

netfilter: remove ip_conntrack* sysctl compat code

2016-08-13 13:27:13 +02:00

nf_conntrack_proto_gre.c

netfilter: gre: Use consistent GRE and PTTP header structure instead of the ones defined by netfilter

2016-09-07 10:36:52 +02:00

nf_conntrack_proto_sctp.c

netfilter: remove ip_conntrack* sysctl compat code

2016-08-13 13:27:13 +02:00

nf_conntrack_proto_tcp.c

netfilter: remove ip_conntrack* sysctl compat code

2016-08-13 13:27:13 +02:00

nf_conntrack_proto_udp.c

netfilter: remove ip_conntrack* sysctl compat code

2016-08-13 13:27:13 +02:00

nf_conntrack_proto_udplite.c

netfilter: conntrack: Only need first 4 bytes to get l4proto ports

2016-08-12 00:41:08 +02:00

nf_conntrack_proto.c

netfilter: remove ip_conntrack* sysctl compat code

2016-08-13 13:27:13 +02:00

nf_conntrack_sane.c

netfilter: Add helper array register/unregister functions

2016-07-21 02:31:53 +02:00

nf_conntrack_seqadj.c

netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

2016-09-25 14:54:01 +02:00

nf_conntrack_sip.c

netfilter: nf_ct_sip: allow tab character in SIP headers

2016-09-07 13:53:43 +02:00

nf_conntrack_snmp.c

…

nf_conntrack_standalone.c

netfilter: evict stale entries when user reads /proc/net/nf_conntrack

2016-09-25 14:54:08 +02:00

nf_conntrack_tftp.c

netfilter: Add helper array register/unregister functions

2016-07-21 02:31:53 +02:00

nf_conntrack_timeout.c

…

nf_conntrack_timestamp.c

…

nf_dup_netdev.c

…

nf_internals.h

netfilter: replace list_head with single linked list

2016-09-25 14:38:48 +02:00

nf_log_common.c

netfilter: nf_log: get rid of XT_LOG_* macros

2016-09-25 23:16:45 +02:00

nf_log.c

netfilter: fix namespace handling in nf_log_proc_dostring

2016-10-04 08:41:06 +02:00

nf_nat_amanda.c

…

nf_nat_core.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2016-09-23 06:46:57 -04:00

nf_nat_ftp.c

…

nf_nat_helper.c

…

nf_nat_irc.c

…

nf_nat_proto_common.c

…

nf_nat_proto_dccp.c

…

nf_nat_proto_sctp.c

…

nf_nat_proto_tcp.c

…

nf_nat_proto_udp.c

…

nf_nat_proto_udplite.c

…

nf_nat_proto_unknown.c

…

nf_nat_redirect.c

…

nf_nat_sip.c

…

nf_nat_tftp.c

…

nf_queue.c

netfilter: replace list_head with single linked list

2016-09-25 14:38:48 +02:00

nf_sockopt.c

…

nf_synproxy_core.c

…

nf_tables_api.c

netfilter: nf_tables: validate maximum value of u32 netlink attributes

2016-09-23 09:29:02 +02:00

nf_tables_core.c

netfilter: nft_log: complete NFTA_LOG_FLAGS attr support

2016-09-25 23:16:43 +02:00

nf_tables_inet.c

netfilter: Add the missed return value check of nft_register_chain_type

2016-09-12 19:54:45 +02:00

nf_tables_netdev.c

netfilter: Add the missed return value check of nft_register_chain_type

2016-09-12 19:54:45 +02:00

nf_tables_trace.c

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

2016-09-25 23:34:19 +02:00

nfnetlink_acct.c

netfilter: nfnetlink: use list_for_each_entry_safe to delete all objects

2016-08-25 13:11:00 +02:00

nfnetlink_cthelper.c

netfilter: Remove explicit rcu_read_lock in nf_hook_slow

2016-09-24 21:29:53 +02:00

nfnetlink_cttimeout.c

netfilter: cttimeout: unlink timeout objs in the unconfirmed ct lists

2016-08-25 13:11:30 +02:00

nfnetlink_log.c

netfilter: Remove explicit rcu_read_lock in nf_hook_slow

2016-09-24 21:29:53 +02:00

nfnetlink_queue.c

netfilter: replace list_head with single linked list

2016-09-25 14:38:48 +02:00

nfnetlink.c

…

nft_bitwise.c

netfilter: nf_tables: validate maximum value of u32 netlink attributes

2016-09-23 09:29:02 +02:00

nft_byteorder.c

netfilter: nf_tables: validate maximum value of u32 netlink attributes

2016-09-23 09:29:02 +02:00

nft_cmp.c

netfilter: nf_tables: validate maximum value of u32 netlink attributes

2016-09-23 09:29:02 +02:00

nft_compat.c

netfilter: nft_compat: fix crash when related match/target module is removed

2016-07-23 12:25:00 +02:00

nft_counter.c

…

nft_ct.c

netfilter: nft_ct: report error if mark and dir specified simultaneously

2016-09-25 14:54:04 +02:00

nft_dup_netdev.c

…

nft_dynset.c

netfilter: nft_dynset: allow to invert match criteria

2016-09-12 18:49:50 +02:00

nft_exthdr.c

netfilter: nf_tables: validate maximum value of u32 netlink attributes

2016-09-23 09:29:02 +02:00

nft_fwd_netdev.c

…

nft_hash.c

netfilter: nft_hash: fix hash overflow validation

2016-09-13 10:49:23 +02:00

nft_immediate.c

netfilter: nf_tables: validate maximum value of u32 netlink attributes

2016-09-23 09:29:02 +02:00

nft_limit.c

netfilter: nft_limit: fix divided by zero panic

2016-10-04 08:59:03 +02:00

nft_log.c

netfilter: nft_log: complete NFTA_LOG_FLAGS attr support

2016-09-25 23:16:43 +02:00

nft_lookup.c

netfilter: nft_lookup: remove superfluous element found check

2016-09-23 09:30:48 +02:00

nft_masq.c

…

nft_meta.c

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

2016-09-25 23:34:19 +02:00

nft_nat.c

…

nft_numgen.c

netfilter: nft_numgen: add number generation offset

2016-09-22 16:33:05 +02:00

nft_payload.c

netfilter: nf_tables: check tprot_set first when we use xt.thoff

2016-09-23 09:30:26 +02:00

nft_queue.c

netfilter: nft_queue: add _SREG_QNUM attr to select the queue number

2016-09-23 09:29:50 +02:00

nft_quota.c

netfilter: nft_quota: introduce nft_overquota()

2016-09-07 11:02:06 +02:00

nft_range.c

netfilter: nf_tables: add range expression

2016-09-25 23:16:42 +02:00

nft_redir.c

…

nft_reject_inet.c

netfilter: nft_reject: restrict to INPUT/FORWARD/OUTPUT

2016-08-25 12:55:34 +02:00

nft_reject.c

netfilter: nft_reject: restrict to INPUT/FORWARD/OUTPUT

2016-08-25 12:55:34 +02:00

nft_set_hash.c

netfilter: nf_tables: honor NLM_F_EXCL flag in set element insertion

2016-08-26 17:30:20 +02:00

nft_set_rbtree.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next

2016-09-06 12:45:26 -07:00

x_tables.c

netfilter: x_tables: speed up jump target validation

2016-07-18 21:35:23 +02:00

xt_addrtype.c

…

xt_AUDIT.c

…

xt_bpf.c

…

xt_cgroup.c

…

xt_CHECKSUM.c

…

xt_CLASSIFY.c

…

xt_cluster.c

…

xt_comment.c

…

xt_connbytes.c

…

xt_connlabel.c

netfilter: connlabels: move set helper to xt_connlabel

2016-07-22 17:05:10 +02:00

xt_connlimit.c

netfilter: Enhance the codes used to get random once

2016-09-23 09:30:36 +02:00

xt_connmark.c

…

xt_CONNSECMARK.c

…

xt_conntrack.c

netfilter: use_nf_conn_expires helper in more places

2016-08-12 00:43:13 +02:00

xt_cpu.c

…

xt_CT.c

…

xt_dccp.c

…

xt_devgroup.c

…

xt_dscp.c

…

xt_DSCP.c

…

xt_ecn.c

…

xt_esp.c

…

xt_hashlimit.c

netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

2016-09-30 20:15:27 +02:00

xt_helper.c

netfilter: Remove explicit rcu_read_lock in nf_hook_slow

2016-09-24 21:29:53 +02:00

xt_hl.c

…

xt_HL.c

…

xt_HMARK.c

…

xt_IDLETIMER.c

…

xt_ipcomp.c

…

xt_iprange.c

…

xt_ipvs.c

…

xt_l2tp.c

…

xt_LED.c

…

xt_length.c

…

xt_limit.c

…

xt_LOG.c

…

xt_mac.c

…

xt_mark.c

…

xt_multiport.c

…

xt_nat.c

…

xt_NETMAP.c

…

xt_nfacct.c

netfilter: nfnetlink_acct: report overquota to the right netns

2016-08-18 00:38:23 +02:00

xt_NFLOG.c

netfilter: xt_NFLOG: nflog-range does not truncate packets

2016-06-24 11:03:23 +02:00

xt_NFQUEUE.c

…

xt_osf.c

…

xt_owner.c

netfilter: Allow xt_owner in any user namespace

2016-06-23 13:58:55 +02:00

xt_physdev.c

netfilter: physdev: add missed blank

2016-08-12 00:42:14 +02:00

xt_pkttype.c

…

xt_policy.c

…

xt_quota.c

…

xt_rateest.c

…

xt_RATEEST.c

netfilter: Enhance the codes used to get random once

2016-09-23 09:30:36 +02:00

xt_realm.c

…

xt_recent.c

netfilter: Enhance the codes used to get random once

2016-09-23 09:30:36 +02:00

xt_REDIRECT.c

…

xt_repldata.h

…

xt_sctp.c

sctp: rename WORD_TRUNC/ROUND macros

2016-09-22 03:13:26 -04:00

xt_SECMARK.c

…

xt_set.c

…

xt_socket.c

…

xt_state.c

…

xt_statistic.c

…

xt_string.c

…

xt_tcpmss.c

…

xt_TCPMSS.c

netfilter: xt_TCPMSS: Refactor the codes to decrease one condition check and more readable

2016-09-24 21:13:21 +02:00

xt_TCPOPTSTRIP.c

…

xt_tcpudp.c

netfilter: Convert FWINV<[foo]> macros and uses to NF_INVF

2016-07-03 10:55:07 +02:00

xt_TEE.c

netfilter: Add the missed return value check of register_netdevice_notifier

2016-09-12 19:54:43 +02:00

xt_time.c

…

xt_TPROXY.c

netfilter: tproxy: properly refcount tcp listeners

2016-08-18 00:51:13 +02:00

xt_TRACE.c

netfilter: xt_TRACE: add explicitly nf_logger_find_get call

2016-06-23 13:26:49 +02:00

xt_u32.c

…