Wang Nan bd315aab8a perf top: Fix segfault pressing -> with no hist entries ... 'perf top' segfaults with following operation: # perf top -e page-faults -p 11400 # 11400 never generates page-fault Then on the resulting empty interface, press right key: # ./perf top -e page-faults -p 11400 perf: Segmentation fault -------- backtrace -------- ./perf[0x535428] /lib64/libc.so.6(+0x3545f)[0x7f0dd360745f] ./perf[0x531d46] ./perf(perf_evlist__tui_browse_hists+0x96)[0x5340d6] ./perf[0x44ba2f] /lib64/libpthread.so.0(+0x81d0)[0x7f0dd49dc1d0] /lib64/libc.so.6(clone+0x6c)[0x7f0dd36b90dc] The bug resides in perf_evsel__hists_browse() that, in the above circumstance browser->selection can be NULL, but code after skip_annotation doesn't consider it. This patch fix it by checking browser->selection before fetching browser->selection->map. Signed-off-by: Wang Nan <wangnan0@huawei.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Zefan Li <lizefan@huawei.com> Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1442226235-117265-1-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2015-09-14 15:10:41 -03:00
..
browsers	perf top: Fix segfault pressing -> with no hist entries	2015-09-14 15:10:41 -03:00
gtk	perf build: Add gtk objects building	2015-02-12 11:49:12 -03:00
stdio	perf callchain: Use a common function to resolve symbol or name	2014-11-19 12:33:47 -03:00
tui	perf ui tui progress: Implement the ui_progress_ops->finish() method	2015-08-24 16:18:26 -03:00
browser.c	perf ui browser: Introduce ui_browser__printf()	2015-08-12 10:27:05 -03:00
browser.h	perf tools: Rename perf_session_env to perf_env	2015-08-28 14:53:55 -03:00
Build	perf build: Add slang objects building	2015-02-12 11:48:13 -03:00
helpline.c
helpline.h
hist.c	perf tools: Pass struct perf_hpp_fmt to its callbacks	2015-01-21 13:24:34 -03:00
keysyms.h
libslang.h	perf ui browser: Introduce ui_browser__printf()	2015-08-12 10:27:05 -03:00
progress.c
progress.h	perf tools: Remove EOL whitespaces	2015-01-21 13:24:31 -03:00
setup.c	perf tools: Call perf_hpp__init() before setting up GUI browsers	2014-05-21 11:45:35 +02:00
ui.h
util.c
util.h