Mathieu Desnoyers 87f3b6b6fb Marker depmod fix core kernel list ... * Theodore Ts'o (tytso@mit.edu) wrote: > > I've been playing with adding some markers into ext4 to see if they > could be useful in solving some problems along with Systemtap. It > appears, though, that as of 2.6.27-rc8, markers defined in code which is > compiled directly into the kernel (i.e., not as modules) don't show up > in Module.markers: > > kvm_trace_entryexit arch/x86/kvm/kvm-intel %u %p %u %u %u %u %u %u > kvm_trace_handler arch/x86/kvm/kvm-intel %u %p %u %u %u %u %u %u > kvm_trace_entryexit arch/x86/kvm/kvm-amd %u %p %u %u %u %u %u %u > kvm_trace_handler arch/x86/kvm/kvm-amd %u %p %u %u %u %u %u %u > > (Note the lack of any of the kernel_sched_* markers, and the markers I > added for ext4_* and jbd2_* are missing as wel.) > > Systemtap apparently depends on in-kernel trace_mark being recorded in > Module.markers, and apparently it's been claimed that it used to be > there. Is this a bug in systemtap, or in how Module.markers is getting > built? And is there a file that contains the equivalent information > for markers located in non-modules code? I think the problem comes from "markers: fix duplicate modpost entry" (commit d35cb360c2) Especially : - add_marker(mod, marker, fmt); + if (!mod->skip) + add_marker(mod, marker, fmt); } return; fail: Here is a fix that should take care if this problem. Thanks for the bug report! Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Tested-by: "Theodore Ts'o" <tytso@mit.edu> CC: Greg KH <greg@kroah.com> CC: David Smith <dsmith@redhat.com> CC: Roland McGrath <roland@redhat.com> CC: Sam Ravnborg <sam@ravnborg.org> CC: Wenji Huang <wenji.huang@oracle.com> CC: Takashi Nishiie <t-nishiie@np.css.fujitsu.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2008-10-06 16:34:19 -07:00
..
basic
genksyms	kbuild: genksyms: Include extern information in dumps	2008-07-31 23:01:31 +02:00
kconfig	kconfig: readd lost change count	2008-09-29 08:03:01 -07:00
ksymoops
mod	Marker depmod fix core kernel list	2008-10-06 16:34:19 -07:00
package
rt-tester
.gitignore
bin2c.c
binoffset.c
bloat-o-meter
checkincludes.pl
checkkconfigsymbols.sh
checkpatch.pl	checkpatch: version 0.21	2008-07-24 10:47:27 -07:00
checkstack.pl	fix checkstack.pl arch detection	2008-07-25 10:53:27 -07:00
checksyscalls.sh
checkversion.pl
cleanfile
cleanpatch
conmakehash.c
decodecode
diffconfig	kconfig: add diffconfig utility	2008-07-25 22:12:41 +02:00
export_report.pl
extract-ikconfig
gcc-version.sh
gcc-x86_64-has-stack-protector.sh
gen_initramfs_list.sh
headers_check.pl	kbuild: optimize headers_* targets	2008-07-25 22:12:16 +02:00
headers_install.pl	kbuild: install all headers when arch is changed	2008-07-25 22:12:18 +02:00
headers.sh	kbuild: prepare headers_* for arch/$ARCH/include	2008-07-25 22:12:33 +02:00
kallsyms.c
Kbuild.include
kernel-doc	kernel-doc: allow structs whose members are all private	2008-09-23 08:09:13 -07:00
Lindent
Makefile
Makefile.build
Makefile.clean
Makefile.fwinst	firmware: silence __fw_modbuild and __fw_modinst 'Nothing to be done' messages	2008-08-02 07:52:29 +01:00
Makefile.headersinst	kbuild: install all headers when arch is changed	2008-07-25 22:12:18 +02:00
Makefile.host
Makefile.lib
Makefile.modinst
Makefile.modpost	markers: fix duplicate modpost entry	2008-07-22 09:59:41 -07:00
makelst
mkcompile_h
mkmakefile
mksysmap
mkuboot.sh
mkversion
namespace.pl
patch-kernel	bugfix for scripts/patch-kernel in 2.6 sublevel stepping	2008-08-06 22:11:33 +02:00
pnmtologo.c
profile2linkerlist.pl
setlocalversion	setlocalversion: do not describe if there is nothing to describe	2008-07-25 22:12:53 +02:00
show_delta
unifdef.c
ver_linux	kbuild: scripts/ver_linux: don't set PATH	2008-07-31 23:36:54 +02:00