Vasu Dev
bc0e17f691
[SCSI] libfc, fcoe: fixed locking issues with lport->lp_mutex around lport->link_status ...
The fcoe_xmit could call fc_pause in case the pending skb queue len is larger
than FCOE_MAX_QUEUE_DEPTH, the fc_pause was trying to grab lport->lp_muex to
change lport->link_status and that had these issues :-
1. The fcoe_xmit was getting called with bh disabled, thus causing
"BUG: scheduling while atomic" when grabbing lport->lp_muex with bh disabled.
2. fc_linkup and fc_linkdown function calls lport_enter function with
lport->lp_mutex held and these enter function in turn calls fcoe_xmit to send
lport related FC frame, e.g. fc_linkup => fc_lport_enter_flogi to send flogi
req. In this case grabbing the same lport->lp_mutex again in fc_puase from
fcoe_xmit would cause deadlock.
The lport->lp_mutex was used for setting FC_PAUSE in fcoe_xmit path but
FC_PAUSE bit was not used anywhere beside just setting and clear this
bit in lport->link_status, instead used a separate field qfull in fc_lport
to eliminate need for lport->lp_mutex to track pending queue full condition
and in turn avoid above described two locking issues.
Also added check for lp->qfull in fc_fcp_lport_queue_ready to trigger
SCSI_MLQUEUE_HOST_BUSY when lp->qfull is set to prevent more scsi-ml cmds
while lp->qfull is set.
This patch eliminated FC_LINK_UP and FC_PAUSE and instead used dedicated
fields in fc_lport for this, this simplified all related conditional
code.
Also removed fc_pause and fc_unpause functions and instead used newly added
lport->qfull directly in fcoe.
Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2009-03-06 15:37:49 -06:00
2008-12-29 11:24:12 -06:00
2008-10-23 11:42:16 -05:00
2006-06-30 19:25:36 +02:00
2009-01-02 10:22:16 -06:00
2008-12-29 11:24:11 -06:00
2008-08-07 09:55:48 +01:00
2009-02-21 20:29:38 -06:00
2008-12-29 11:24:17 -06:00
2008-08-23 12:14:12 -07:00
2009-03-06 15:37:49 -06:00
2009-02-10 11:15:18 -05:00
2009-03-06 15:37:49 -06:00
2009-01-16 10:17:09 -05:00
2009-02-10 11:15:19 -05:00
2008-12-01 11:15:55 -06:00
2009-01-05 12:17:42 -06:00
2009-02-10 11:15:20 -05:00
2009-01-25 07:55:13 -06:00
2008-10-09 08:56:13 +02:00
2008-01-11 18:22:30 -06:00
2008-10-23 11:42:18 -05:00
2008-07-26 15:15:00 -04:00
2008-10-23 11:42:17 -05:00
2007-01-06 09:18:00 -06:00
2008-05-02 10:18:22 -05:00
2007-06-17 16:15:56 -05:00
2009-01-06 11:28:08 +01:00
2007-06-17 16:09:29 -05:00
2009-01-02 12:16:18 -06:00
2006-09-12 17:12:31 -05:00
2008-04-07 12:19:01 -05:00
2006-09-12 17:12:31 -05:00
2007-10-12 14:41:00 -04:00
2009-01-02 10:22:16 -06:00
2008-10-16 16:52:06 +02:00
2007-08-04 09:11:06 -05:00
2008-04-27 12:19:55 -05:00
2008-12-29 11:24:12 -06:00
2008-02-06 10:41:01 -08:00
2008-01-11 18:28:57 -06:00
2008-10-14 10:23:27 -07:00
2007-05-04 17:59:05 -07:00
2008-12-29 11:24:12 -06:00
2008-04-07 12:15:44 -05:00
2008-04-07 12:15:44 -05:00
2007-10-12 14:41:00 -04:00
2008-12-29 11:24:24 -06:00
2008-10-13 09:28:48 -04:00
2008-04-07 12:15:40 -05:00
2006-09-26 11:35:32 -07:00
2008-11-15 11:10:14 -06:00
2008-05-08 10:46:56 -07:00
2007-11-25 12:19:26 +02:00
2007-03-20 11:27:03 -05:00
2008-12-29 11:24:12 -06:00
2008-12-29 11:24:35 -06:00
2008-12-29 11:24:14 -06:00
2008-08-29 02:13:10 -07:00
2008-01-11 18:22:35 -06:00
2008-12-29 11:24:12 -06:00
2008-04-27 12:19:55 -05:00
2007-11-25 12:19:26 +02:00
2006-06-30 19:25:36 +02:00
2008-10-09 08:56:13 +02:00
2008-10-09 08:56:13 +02:00
2008-11-30 10:03:36 -08:00
2008-10-09 08:56:13 +02:00
2009-01-02 12:16:18 -06:00
2006-09-12 17:12:31 -05:00
2009-01-02 10:22:16 -06:00
2009-02-21 20:29:36 -06:00
2008-01-11 18:28:06 -06:00
2008-12-29 11:24:12 -06:00
2008-07-27 10:31:49 -04:00
2006-10-04 03:38:54 -04:00
2008-12-29 11:24:12 -06:00
2008-12-29 11:24:12 -06:00
2008-12-29 11:24:12 -06:00
2009-01-16 10:17:09 -05:00
2009-01-02 10:22:16 -06:00
2008-10-09 08:56:13 +02:00
2008-08-23 12:14:12 -07:00
2008-12-29 11:24:23 -06:00
2008-12-29 11:24:22 -06:00
2008-04-27 12:33:04 -05:00
2009-01-08 16:25:14 +11:00
2009-01-02 10:22:16 -06:00
2009-01-13 10:41:34 -06:00
2009-02-10 11:15:19 -05:00
2008-07-27 10:31:49 -04:00
2008-01-30 13:14:02 -06:00
2008-12-29 11:24:19 -06:00
2008-12-28 20:00:03 +01:00
2009-01-02 16:12:51 +01:00
2009-01-06 11:28:08 +01:00
2008-11-05 12:40:23 -05:00
2008-06-05 09:23:44 -05:00
2007-10-12 14:41:00 -04:00
2008-04-07 12:19:07 -05:00
2006-09-12 17:12:31 -05:00
2009-01-02 12:10:04 -06:00
2008-10-09 08:56:13 +02:00
2007-10-12 14:51:18 -04:00
2008-01-30 13:14:02 -06:00
2008-12-29 11:24:12 -06:00
2007-10-12 14:55:07 -04:00
2009-01-02 10:22:16 -06:00
2007-07-19 10:04:50 -07:00
2008-07-27 10:31:49 -04:00
2008-12-29 11:24:11 -06:00
2008-08-23 12:14:12 -07:00
2008-10-16 09:24:44 -07:00
2007-10-12 14:50:55 -04:00
2007-11-25 12:19:26 +02:00
2008-07-27 10:31:49 -04:00
2006-10-04 03:38:54 -04:00
2009-01-16 16:15:15 +11:00
2009-01-06 11:28:09 +01:00
2007-10-23 12:35:35 -04:00
2008-12-29 11:24:12 -06:00
2006-10-25 15:11:55 -07:00
2008-01-30 13:14:02 -06:00
2006-10-17 19:28:51 -07:00
2008-10-11 12:39:35 -07:00
2008-08-29 02:14:46 -07:00
2009-01-02 10:22:16 -06:00
2009-01-02 10:22:16 -06:00
2009-01-13 10:45:44 -06:00
2009-01-08 16:27:31 -08:00
2009-01-02 10:22:16 -06:00
2007-07-14 19:28:10 -05:00
2009-02-21 20:29:38 -06:00
2006-06-30 19:25:36 +02:00
2008-10-23 11:42:17 -05:00
2008-10-13 09:28:52 -04:00
2008-10-03 11:46:12 -05:00
2008-04-19 19:10:33 -07:00
2009-02-10 11:15:17 -05:00
2007-07-18 11:16:32 -05:00
2009-01-02 10:22:16 -06:00
2008-07-02 15:06:25 -06:00
2008-10-10 10:53:26 -07:00
2008-07-27 10:31:49 -04:00
2006-05-20 00:39:08 -04:00
2007-10-12 14:46:58 -04:00
2009-01-06 09:43:33 -06:00
2009-01-02 10:22:16 -06:00
2009-01-02 10:22:16 -06:00
2008-12-29 11:24:32 -06:00
2007-10-12 14:38:09 -04:00
2009-01-02 10:22:16 -06:00
2006-06-10 16:24:40 -05:00
2006-10-11 13:44:25 -05:00
2009-01-13 10:48:11 -06:00
2006-08-19 13:39:11 -07:00
2008-01-11 18:22:40 -06:00
2009-01-05 09:06:23 -06:00
2009-03-05 10:34:37 -06:00
2008-10-15 08:41:28 -04:00
2009-01-02 10:22:16 -06:00
2009-02-10 11:15:17 -05:00
2009-01-02 10:58:41 -06:00
2009-01-02 10:22:16 -06:00
2009-01-02 10:22:16 -06:00
2008-12-29 11:24:24 -06:00
2008-10-20 08:52:41 -07:00
2008-12-29 11:24:24 -06:00
2008-02-07 18:02:44 -06:00
2008-04-07 12:15:39 -05:00
2009-01-02 12:06:52 -06:00
2009-01-02 12:02:25 -06:00
2008-12-29 11:24:11 -06:00
2008-01-11 18:28:57 -06:00
2008-04-16 09:28:11 -05:00
2007-11-25 12:19:26 +02:00
2006-12-09 09:41:18 -08:00
2008-10-23 11:42:19 -05:00
2008-08-31 01:23:17 -07:00
2008-12-29 11:24:12 -06:00
2007-11-25 12:19:26 +02:00
2006-11-15 16:43:50 -06:00
2008-12-29 11:24:14 -06:00
2007-07-14 18:56:33 -05:00
2008-12-29 11:24:14 -06:00
2008-04-28 17:31:13 -07:00
2006-09-07 12:39:34 -05:00
2008-04-07 12:19:01 -05:00
2007-10-19 23:22:55 +02:00
2008-12-29 11:24:12 -06:00
2009-01-02 10:22:16 -06:00
2007-11-29 09:24:52 -08:00
bc0e17f691