Boaz Harrosh
c18c821fd4
nfsd41: Fix a crash when a callback is retried ...
If a callback is retried at nfsd4_cb_recall_done() due to
some error, the returned rpc reply crashes here:
@@ -514,6 +514,7 @@ decode_cb_sequence(struct xdr_stream *xdr, struct nfsd4_cb_sequence *res,
u32 dummy;
__be32 *p;
+ BUG_ON(!res);
if (res->cbs_minorversion == 0)
return 0;
[BUG_ON added for demonstration]
This is because the nfsd4_cb_done_sequence() has NULLed out
the task->tk_msg.rpc_resp pointer.
Also eventually the rpc would use the new slot without making
sure it is free by calling nfsd41_cb_setup_sequence().
This problem was introduced by a 4.1 protocol addition patch:
[0421b5c5] nfsd41: Backchannel: Implement cb_recall over NFSv4.1
Which was overlooking the possibility of an RPC callback retries.
For not-4.1 case redoing the _prepare is harmless.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
2010-08-06 17:05:39 -04:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:15:42 -04:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:05:02 -04:00
2010-05-27 09:12:56 -07:00
2010-05-27 09:12:41 -07:00
2010-05-27 22:06:06 -04:00
2010-05-27 22:05:02 -04:00
2010-05-12 18:23:58 -07:00
2010-05-30 08:56:39 -07:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:15:47 -04:00
2010-05-19 22:41:57 -04:00
2010-05-21 18:31:12 -04:00
2010-04-30 14:52:51 -05:00
2010-05-27 22:15:42 -04:00
2010-05-27 22:05:02 -04:00
2010-05-30 09:11:11 -07:00
2010-05-30 09:11:11 -07:00
2010-05-30 09:11:11 -07:00
2010-05-27 22:16:02 -04:00
2010-05-27 09:12:56 -07:00
2010-05-26 08:19:23 -07:00
2010-05-30 09:16:14 -07:00
2010-05-27 22:15:42 -04:00
2010-05-17 05:27:03 +02:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:06:06 -04:00
2010-05-27 09:12:56 -07:00
2010-05-21 19:30:41 +02:00
2010-05-27 10:26:37 -07:00
2010-05-27 22:15:42 -04:00
2010-05-30 09:11:11 -07:00
2010-05-27 22:05:02 -04:00
2010-05-28 11:37:41 -04:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:05:02 -04:00
2010-08-06 17:05:39 -04:00
2010-05-27 22:05:02 -04:00
2010-05-21 18:31:14 -04:00
2010-05-27 22:05:02 -04:00
2010-05-30 09:11:11 -07:00
2010-05-27 22:06:06 -04:00
2010-05-25 08:07:06 -07:00
2010-05-27 09:12:47 -07:00
2010-05-27 22:06:06 -04:00
2010-05-30 09:11:11 -07:00
2010-05-27 22:15:47 -04:00
2010-05-30 09:11:11 -07:00
2010-05-27 22:15:42 -04:00
2010-05-23 08:27:42 +01:00
2010-05-27 22:15:47 -04:00
2010-05-27 22:16:05 -04:00
2010-05-27 22:15:42 -04:00
2010-05-30 09:11:11 -07:00
2010-05-30 09:11:11 -07:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:03:07 -04:00
2010-05-27 22:03:05 -04:00
2010-05-27 22:15:33 -04:00
2010-05-27 22:05:02 -04:00
2010-04-27 09:01:26 -07:00
2010-05-27 22:15:47 -04:00
2010-05-27 22:15:33 -04:00
2010-04-29 08:44:37 -07:00
2010-05-27 09:12:53 -07:00
2010-05-21 18:31:16 -04:00
2010-05-27 22:15:33 -04:00
2010-05-21 18:31:16 -04:00
2010-05-11 17:43:58 +02:00
2010-05-27 09:12:46 -07:00
2010-05-21 21:27:26 +02:00
2010-05-27 22:03:07 -04:00
2010-05-25 08:07:00 -07:00
2010-05-21 18:31:18 -04:00
2010-05-21 18:31:22 -04:00
2010-05-21 18:31:16 -04:00
2010-05-21 18:31:18 -04:00
2010-05-27 22:15:33 -04:00
2010-05-21 18:31:17 -04:00
2010-05-27 22:03:06 -04:00
2010-05-18 08:57:00 +10:00
2010-05-21 18:31:17 -04:00
2010-05-30 09:16:14 -07:00
2010-05-27 09:12:56 -07:00
2010-05-21 21:12:40 +02:00
2010-05-21 18:31:17 -04:00
2010-05-30 09:11:11 -07:00
2010-05-27 22:05:02 -04:00
2010-05-20 13:21:42 -07:00
2010-05-21 18:31:18 -04:00
c18c821fd4