Vivek Goyal c94a96ac93 block: Initialize ->queue_lock to internal lock at queue allocation time ... There does not seem to be a clear convention whether q->queue_lock is initialized or not when blk_cleanup_queue() is called. In the past it was not necessary but now blk_throtl_exit() takes up queue lock by default and needs queue lock to be available. In fact elevator_exit() code also has similar requirement just that it is less stringent in the sense that elevator_exit() is called only if elevator is initialized. Two problems have been noticed because of ambiguity about spin lock status. - If a driver calls blk_alloc_queue() and then soon calls blk_cleanup_queue() almost immediately, (because some other driver structure allocation failed or some other error happened) then blk_throtl_exit() will run into issues as queue lock is not initialized. Loop driver ran into this issue recently and I noticed error paths in md driver too. Similar error paths should exist in other drivers too. - If some driver provided external spin lock and zapped the lock before blk_cleanup_queue(), then it can lead to issues. So this patch initializes the default queue lock at queue allocation time. block throttling code is one of the users of queue lock and it is initialized at the queue allocation time, so it makes sense to initialize ->queue_lock also to internal lock. A driver can overide that lock later. This will take care of the issue where a driver does not have to worry about initializing the queue lock to default before calling blk_cleanup_queue() Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Jens Axboe <jaxboe@fusionio.com>		2011-03-02 19:06:49 -05:00
..
blk-cgroup.c
blk-cgroup.h
blk-core.c	block: Initialize ->queue_lock to internal lock at queue allocation time	2011-03-02 19:06:49 -05:00
blk-exec.c
blk-flush.c	block: reimplement FLUSH/FUA to support merge	2011-01-25 12:43:54 +01:00
blk-integrity.c
blk-ioc.c	block: Clean up exit_io_context() source code.	2010-12-21 15:07:45 +01:00
blk-iopoll.c
blk-lib.c
blk-map.c
blk-merge.c	Merge branch 'for-2.6.38/core' of git://git.kernel.dk/linux-2.6-block	2011-01-13 10:45:01 -08:00
blk-settings.c	block: Initialize ->queue_lock to internal lock at queue allocation time	2011-03-02 19:06:49 -05:00
blk-softirq.c
blk-sysfs.c	block: Deprecate QUEUE_FLAG_CLUSTER and use queue_limits instead	2010-12-17 08:35:53 +01:00
blk-tag.c
blk-throttle.c	blkio-throttle: Avoid calling blkiocg_lookup_group() for root group	2011-01-19 08:25:02 -07:00
blk-timeout.c
blk.h	block: reimplement FLUSH/FUA to support merge	2011-01-25 12:43:54 +01:00
bsg.c
cfq-iosched.c	cfq-iosched: Always provide group isolation.	2011-03-01 15:05:08 -05:00
cfq.h
compat_ioctl.c
deadline-iosched.c
elevator.c	block: share request flush fields with elevator_private	2011-02-11 11:08:00 +01:00
genhd.c	block/genhd: Change some numerals into macros	2011-03-02 11:00:15 -05:00
ioctl.c	Merge branch 'for-2.6.38/core' of git://git.kernel.dk/linux-2.6-block	2011-01-13 10:45:01 -08:00
Kconfig	kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT	2011-01-20 17:02:05 -08:00
Kconfig.iosched
Makefile
noop-iosched.c
scsi_ioctl.c