Sukadev Bhattiprolu 29f12ca321 pidns: fix a leak in /proc dentries and inodes with pid namespaces. ... Daniel Lezcano reported a leak in 'struct pid' and 'struct pid_namespace' that is discussed in: http://lkml.org/lkml/2009/10/2/159. To summarize the thread, when container-init is terminated, it sets the PF_EXITING flag, zaps other processes in the container and waits to reap them. As a part of reaping, the container-init should flush any /proc dentries associated with the processes. But because the container-init is itself exiting and the following PF_EXITING check, the dentries are not flushed, resulting in leak in /proc inodes and dentries. This fix reverts the commit 7766755a2f ("Fix /proc dcache deadlock in do_exit") which introduced the check for PF_EXITING. At the time of the commit, shrink_dcache_parent() flushed dentries from other filesystems also and could have caused a deadlock which the commit fixed. But as pointed out by Eric Biederman, after commit 0feae5c47a, shrink_dcache_parent() no longer affects other filesystems. So reverting the commit is now safe. As pointed out by Jan Kara, the leak is not as critical since the unclaimed space will be reclaimed under memory pressure or by: echo 3 > /proc/sys/vm/drop_caches But since this check is no longer required, its best to remove it. Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> Reported-by: Daniel Lezcano <dlezcano@fr.ibm.com> Acked-by: Eric W. Biederman <ebiederm@xmission.com> Acked-by: Jan Kara <jack@ucw.cz> Cc: Andrea Arcangeli <andrea@cpushare.com> Cc: Serge Hallyn <serue@us.ibm.com> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2009-11-12 07:25:57 -08:00
..
array.c	procfs: disable per-task stack usage on NOMMU	2009-09-24 17:11:24 -07:00
base.c	pidns: fix a leak in /proc dentries and inodes with pid namespaces.	2009-11-12 07:25:57 -08:00
cmdline.c
cpuinfo.c
devices.c
generic.c
inode.c
internal.h
interrupts.c
Kconfig
kcore.c	fs: includecheck fix: proc, kcore.c	2009-10-08 07:36:38 -07:00
kmsg.c
loadavg.c
Makefile
meminfo.c	hwpoison: fix/proc/meminfo alignment	2009-10-29 07:39:25 -07:00
mmu.c
nommu.c	seq_file: constify seq_operations	2009-09-23 07:39:29 -07:00
page.c	pagemap: export KPF_HWPOISON	2009-10-08 07:36:39 -07:00
proc_devtree.c
proc_net.c
proc_sysctl.c	sysctl: remove "struct file *" argument of ->proc_handler	2009-09-24 07:21:04 -07:00
proc_tty.c
root.c
softirqs.c
stat.c
task_mmu.c	procfs: provide stack information for threads	2009-09-23 07:39:41 -07:00
task_nommu.c
uptime.c	[PATCH] Fix idle time field in /proc/uptime	2009-09-24 10:16:24 +02:00
version.c
vmcore.c