Mel Gorman 42288fe366 mm: mempolicy: Convert shared_policy mutex to spinlock ... Sasha was fuzzing with trinity and reported the following problem: BUG: sleeping function called from invalid context at kernel/mutex.c:269 in_atomic(): 1, irqs_disabled(): 0, pid: 6361, name: trinity-main 2 locks held by trinity-main/6361: #0: (&mm->mmap_sem){++++++}, at: [<ffffffff810aa314>] __do_page_fault+0x1e4/0x4f0 #1: (&(&mm->page_table_lock)->rlock){+.+...}, at: [<ffffffff8122f017>] handle_pte_fault+0x3f7/0x6a0 Pid: 6361, comm: trinity-main Tainted: G W 3.7.0-rc2-next-20121024-sasha-00001-gd95ef01-dirty #74 Call Trace: __might_sleep+0x1c3/0x1e0 mutex_lock_nested+0x29/0x50 mpol_shared_policy_lookup+0x2e/0x90 shmem_get_policy+0x2e/0x30 get_vma_policy+0x5a/0xa0 mpol_misplaced+0x41/0x1d0 handle_pte_fault+0x465/0x6a0 This was triggered by a different version of automatic NUMA balancing but in theory the current version is vunerable to the same problem. do_numa_page -> numa_migrate_prep -> mpol_misplaced -> get_vma_policy -> shmem_get_policy It's very unlikely this will happen as shared pages are not marked pte_numa -- see the page_mapcount() check in change_pte_range() -- but it is possible. To address this, this patch restores sp->lock as originally implemented by Kosaki Motohiro. In the path where get_vma_policy() is called, it should not be calling sp_alloc() so it is not necessary to treat the PTL specially. Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Tested-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: Mel Gorman <mgorman@suse.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2013-01-02 17:32:13 -08:00
..
backing-dev.c
balloon_compaction.c
bootmem.c
bounce.c
cleancache.c
compaction.c	compaction: fix build error in CMA && !COMPACTION	2012-12-20 17:40:18 -08:00
debug-pagealloc.c
dmapool.c
fadvise.c
failslab.c
filemap_xip.c
filemap.c
fremap.c
frontswap.c
highmem.c	Some nice cleanups, and even a patch my wife did as a "live" demo for	2012-12-20 08:37:05 -08:00
huge_memory.c	mm: clean up transparent hugepage sysfs error messages	2012-12-20 17:40:20 -08:00
hugetlb_cgroup.c	mm/hugetlb: create hugetlb cgroup file in hugetlb_init	2012-12-18 15:02:15 -08:00
hugetlb.c	mm/hugetlb: create hugetlb cgroup file in hugetlb_init	2012-12-18 15:02:15 -08:00
hwpoison-inject.c
init-mm.c
internal.h
interval_tree.c
Kconfig	memory-hotplug: document and enable CONFIG_MOVABLE_NODE	2012-12-18 15:02:12 -08:00
Kconfig.debug
kmemcheck.c
kmemleak-test.c
kmemleak.c	mm/kmemleak.c: remove obsolete simple_strtoul	2012-12-18 15:02:15 -08:00
ksm.c	ksm: make rmap walks more scalable	2012-12-20 07:06:56 -08:00
maccess.c
madvise.c
Makefile
memblock.c
memcontrol.c	memcg: don't register hotcpu notifier from ->css_alloc()	2012-12-20 17:40:20 -08:00
memory_hotplug.c	mm/memory_hotplug.c: improve comments	2012-12-18 15:02:15 -08:00
memory-failure.c
memory.c
mempolicy.c	mm: mempolicy: Convert shared_policy mutex to spinlock	2013-01-02 17:32:13 -08:00
mempool.c
migrate.c
mincore.c
mlock.c
mm_init.c
mmap.c
mmu_context.c
mmu_notifier.c
mmzone.c
mprotect.c	mm/mprotect.c: coding-style cleanups	2012-12-18 15:02:15 -08:00
mremap.c
msync.c
nobootmem.c
nommu.c
oom_kill.c
page_alloc.c	mm: cma: WARN if freed memory is still in use	2012-12-20 17:40:19 -08:00
page_cgroup.c
page_io.c
page_isolation.c
page-writeback.c	mm: fix calculation of dirtyable memory	2012-12-20 17:40:18 -08:00
pagewalk.c
percpu-km.c
percpu-vm.c
percpu.c
pgtable-generic.c
process_vm_access.c
quicklist.c
readahead.c
rmap.c
shmem.c	mempolicy: remove arg from mpol_parse_str, mpol_to_str	2013-01-02 09:27:10 -08:00
slab_common.c	slab: propagate tunable values	2012-12-18 15:02:14 -08:00
slab.c	memcg: add comments clarifying aspects of cache attribute propagation	2012-12-18 15:02:15 -08:00
slab.h	slab: propagate tunable values	2012-12-18 15:02:14 -08:00
slob.c	sl[au]b: always get the cache from its page in kmem_cache_free()	2012-12-18 15:02:14 -08:00
slub.c	slub: drop mutex before deleting sysfs entry	2012-12-18 15:02:15 -08:00
sparse-vmemmap.c
sparse.c
swap_state.c
swap.c
swapfile.c
truncate.c	mm: drop vmtruncate	2012-12-20 18:46:29 -05:00
util.c
vmalloc.c
vmscan.c	mm: fix null pointer dereference in wait_iff_congested()	2012-12-28 08:42:39 -08:00
vmstat.c