Michael Tokarev
d096ad0f79
ext4: do not try to write superblock on ro remount w/o journal ...
When a journal-less ext4 filesystem is mounted on a read-only block
device (blockdev --setro will do), each remount (for other, unrelated,
flags, like suid=>nosuid etc) results in a series of scary messages
from kernel telling about I/O errors on the device.
This is becauese of the following code ext4_remount():
if (sbi->s_journal == NULL)
ext4_commit_super(sb, 1);
at the end of remount procedure, which forces writing (flushing) of
a superblock regardless whenever it is dirty or not, if the filesystem
is readonly or not, and whenever the device itself is readonly or not.
We only need call ext4_commit_super when the file system had been
previously mounted read/write.
Thanks to Eric Sandeen for help in diagnosing this issue.
Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
2012-12-25 14:08:16 -05:00
2012-10-12 09:59:23 +09:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-11 10:21:16 +09:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-26 09:34:04 -07:00
2012-07-30 17:25:21 -07:00
2012-10-09 23:33:55 -04:00
2012-10-14 13:39:34 -07:00
2012-10-02 21:35:55 -04:00
2012-09-18 01:01:37 -07:00
2012-09-21 03:13:08 -07:00
2012-10-02 11:11:09 -07:00
2012-07-14 16:38:34 +04:00
2012-10-02 13:38:27 -07:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-12 10:52:03 +09:00
2012-07-23 00:01:29 +04:00
2012-10-09 23:23:53 +02:00
2012-10-16 18:12:38 -07:00
2012-12-25 14:08:16 -05:00
2012-10-09 23:33:38 -04:00
2012-10-02 20:25:04 -07:00
2012-10-09 16:22:17 +09:00
2012-10-09 23:33:55 -04:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-10 11:15:20 +09:00
2012-10-09 23:33:38 -04:00
2012-10-09 22:34:52 +02:00
2012-10-09 16:22:39 +09:00
2012-10-09 23:33:55 -04:00
2012-09-12 15:52:03 +02:00
2012-12-25 13:29:52 -05:00
2012-10-09 15:04:25 +01:00
2012-10-17 09:18:38 -05:00
2012-10-24 10:46:22 -04:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-16 13:14:42 -04:00
2012-10-09 18:35:22 -04:00
2012-10-09 16:22:17 +09:00
2012-09-26 22:20:08 -04:00
2012-10-02 20:25:04 -07:00
2012-10-09 16:22:17 +09:00
2012-10-06 03:05:31 +09:00
2012-10-02 21:35:55 -04:00
2012-10-24 04:07:02 +03:00
2012-09-20 17:04:50 -07:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-16 18:12:38 -07:00
2012-07-14 16:34:47 +04:00
2012-10-09 23:33:55 -04:00
2012-10-02 21:35:55 -04:00
2012-10-02 20:25:04 -07:00
2012-10-24 15:57:14 -07:00
2012-10-09 23:33:39 -04:00
2012-10-09 16:22:17 +09:00
2012-10-04 09:14:01 -07:00
2012-10-09 23:33:39 -04:00
2012-10-09 23:33:55 -04:00
2012-07-22 23:57:59 +04:00
2012-09-07 14:57:46 -04:00
2012-07-14 16:34:47 +04:00
2012-10-06 03:05:16 +09:00
2012-10-10 12:02:25 +09:00
2012-10-10 12:02:25 +09:00
2012-10-06 03:05:16 +09:00
2012-09-09 10:35:38 +02:00
2012-09-28 10:38:48 +02:00
2012-10-28 10:59:37 -07:00
2012-10-08 06:36:39 +09:00
2012-10-22 08:50:37 +03:00
2012-10-06 03:05:17 +09:00
2012-10-25 14:37:53 -07:00
2012-10-12 20:14:55 -04:00
2012-10-16 13:36:50 -04:00
2012-10-06 03:05:15 +09:00
2012-10-02 20:25:04 -07:00
2012-08-09 15:23:09 +02:00
2012-10-06 03:05:00 +09:00
2012-10-25 22:28:12 +02:00
2012-10-09 15:52:31 +09:00
2012-09-26 22:20:08 -04:00
2012-07-16 08:33:14 -07:00
2012-10-10 01:15:44 -04:00
2012-10-09 23:33:38 -04:00
2012-10-12 20:14:55 -04:00
2012-07-14 16:32:47 +04:00
2012-10-12 10:46:03 +09:00
2012-09-18 01:01:35 -07:00
2012-10-09 16:22:39 +09:00
2012-10-12 20:15:09 -04:00
2012-09-26 22:20:08 -04:00
2012-12-10 16:30:43 -05:00
2012-10-06 03:05:15 +09:00
2012-09-05 10:59:30 +02:00
2012-10-09 18:35:22 -04:00
2012-10-06 03:05:15 +09:00
2012-07-14 16:32:48 +04:00
2012-10-26 10:05:07 -07:00
2012-10-12 20:14:55 -04:00
2012-10-12 20:15:09 -04:00
2012-09-26 21:08:52 -04:00
2012-07-14 16:37:27 +04:00
2012-09-18 01:01:35 -07:00
2012-07-14 16:32:48 +04:00
2012-10-02 21:35:55 -04:00
2012-10-02 21:35:55 -04:00
2012-09-26 22:20:08 -04:00
2012-09-26 22:20:08 -04:00
2012-08-14 21:47:55 -07:00
2012-09-26 22:20:08 -04:00
2012-09-26 22:20:08 -04:00
2012-10-02 20:25:04 -07:00
2012-09-26 22:20:08 -04:00
2012-10-09 23:33:39 -04:00
2012-09-26 22:20:08 -04:00
2012-09-26 22:20:08 -04:00
2012-09-26 22:20:08 -04:00
2012-10-12 13:16:48 -07:00
2012-10-18 12:35:58 -07:00
d096ad0f79