Julia Lawall 21e7b2c4d5 [S390] drivers/s390/crypto: Move dereference to after IS_ERR test ... If reply is ERR_PTR(...), then it should not be dereferenced, so I have moved the dereference from the declaration to after the IS_ERR test. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @match exists@ expression x, E; identifier fld; position p1,p2; @@ ( x = E; | x = E | x@p1->fld ... when != x = E IS_ERR(x@p2) ... when any ) @other_match exists@ expression match.x, E1, E2; position match.p1,match.p2; @@ x = E1 ... when != x = E2 when != x@p1 x@p2 @ script:python depends on !other_match@ p1 << match.p1; p2 << match.p2; @@ print "* file %s dereference %s test %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>		2008-12-25 13:39:16 +01:00
..
ap_bus.c	[S390] ap: Minor code beautification.	2008-12-25 13:38:57 +01:00
ap_bus.h	[S390] zcrypt: Use of Thin Interrupts	2008-12-25 13:38:57 +01:00
Makefile
zcrypt_api.c
zcrypt_api.h
zcrypt_cca_key.h
zcrypt_cex2a.c	[S390] drivers/s390/crypto: Move dereference to after IS_ERR test	2008-12-25 13:39:16 +01:00
zcrypt_cex2a.h
zcrypt_error.h
zcrypt_mono.c
zcrypt_pcica.c	[S390] drivers/s390/crypto: Move dereference to after IS_ERR test	2008-12-25 13:39:16 +01:00
zcrypt_pcica.h
zcrypt_pcicc.c	[S390] drivers/s390/crypto: Move dereference to after IS_ERR test	2008-12-25 13:39:16 +01:00
zcrypt_pcicc.h
zcrypt_pcixcc.c	[S390] drivers/s390/crypto: Move dereference to after IS_ERR test	2008-12-25 13:39:16 +01:00
zcrypt_pcixcc.h