Chuck Lever d45273ed6f NFS: Clean up address comparison in __nfs_find_client() ...

The address comparison in the __nfs_find_client() function is deceptive.
It uses a memcmp() to check a pair of u32 fields for equality.  Not only is
this inefficient, but usually memcmp() is used for comparing two *whole*
sockaddr_in's (which includes comparisons of the address family and port
number), so it's easy to mistake the comparison here for a whole sockaddr
comparison, which it isn't.

So for clarity and efficiency, we replace the memcmp() with a simple test
for equality between the two s_addr fields.  This should have no
behavioral effect.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

2008-01-30 02:05:46 -05:00

..

callback_proc.c

…

callback_xdr.c

NFSv4: debug print ntohl(status) in nfs client callback xdr code

2007-07-19 15:21:40 -04:00

callback.c

Freezer: make kernel threads nonfreezable by default

2007-07-17 10:23:02 -07:00

callback.h

…

client.c

NFS: Clean up address comparison in __nfs_find_client()

2008-01-30 02:05:46 -05:00

delegation.c

NFSv4: Fix an rpc_cred reference leakage in fs/nfs/delegation.c

2007-10-19 17:19:30 -04:00

delegation.h

NFSv4: Use RCU to protect delegations

2007-07-10 23:40:41 -04:00

dir.c

NFS: Ensure that we eject stale inodes as soon as possible

2008-01-30 02:05:22 -05:00

direct.c

NFS/SUNRPC: Convert users of rpc_init_task+rpc_execute to rpc_run_task()

2008-01-30 02:05:39 -05:00

file.c

NFS: Optimise nfs_vm_page_mkwrite()

2008-01-30 02:05:23 -05:00

getroot.c

NFS: Fix an Oops in NFS unmount

2007-12-12 11:12:15 -05:00

idmap.c

…

inode.c

NFS: Prevent nfs_getattr() hang during heavy write workloads

2008-01-30 02:05:45 -05:00

internal.h

NFS: Remove support for the 'mountprog' option

2008-01-30 02:05:46 -05:00

iostat.h

…

Makefile

[NFS] [PATCH] nfs: tiny makefile cleanup

2007-10-09 17:15:36 -04:00

mount_clnt.c

NFS: Improve debugging output in NFS in-kernel mount client

2007-07-10 23:40:47 -04:00

namespace.c

NFS: Fix use of cancel_delayed_work_sync in nfs_release_automount_timer

2007-09-01 10:14:36 -04:00

nfs2xdr.c

NFS: Use unsigned intermediates for manipulating header lengths (NFSv2 XDR)

2008-01-30 02:05:44 -05:00

nfs3acl.c

NFS: Remove nfs_begin_data_update/nfs_end_data_update

2007-10-09 17:19:53 -04:00

nfs3proc.c

NFS: Clean up the (commit|read|write)_setup() callback routines

2008-01-30 02:05:32 -05:00

nfs3xdr.c

NFS: Use unsigned intermediates for manipulating header lengths (NFSv3 XDR)

2008-01-30 02:05:44 -05:00

nfs4_fs.h

NFSv4: Give the lock stateid its own sequence queue

2008-01-10 13:35:32 -08:00

nfs4namespace.c

…

nfs4proc.c

NFS/SUNRPC: Convert all users of rpc_call_setup()

2008-01-30 02:05:32 -05:00

nfs4renewd.c

NFSv4: Fix circular locking dependency in nfs4_kill_renewd

2008-01-03 09:37:16 -05:00

nfs4state.c

NFSv4: Clean up the OPEN/CLOSE serialisation code

2008-01-30 02:05:24 -05:00

nfs4xdr.c

NFS: Change sign of some loop indices in nfs4xdr.c

2008-01-30 02:05:44 -05:00

nfsroot.c

Convert files to UTF-8 and some cleanups

2007-10-19 23:21:04 +02:00

pagelist.c

NFS: Clean up the write request locking.

2008-01-30 02:05:24 -05:00

proc.c

NFS: Clean up the (commit|read|write)_setup() callback routines

2008-01-30 02:05:32 -05:00

read.c

NFS/SUNRPC: Convert users of rpc_init_task+rpc_execute to rpc_run_task()

2008-01-30 02:05:39 -05:00

super.c

NFS: Clean up: copy hostname with kstrndup during mount processing

2008-01-30 02:05:46 -05:00

symlink.c

…

sysctl.c

…

unlink.c

NFS/SUNRPC: Convert all users of rpc_call_setup()

2008-01-30 02:05:32 -05:00

write.c

NFS/SUNRPC: Convert users of rpc_init_task+rpc_execute to rpc_run_task()

2008-01-30 02:05:39 -05:00