linux/arch/mips/kernel
Thomas Gleixner c08b8a4910 [PATCH] sys_alarm() unsigned signed conversion fixup
alarm() calls the kernel with an unsigend int timeout in seconds.  The
value is stored in the tv_sec field of a struct timeval to setup the
itimer.  The tv_sec field of struct timeval is of type long, which causes
the tv_sec value to be negative on 32 bit machines if seconds > INT_MAX.

Before the hrtimer merge (pre 2.6.16) such a negative value was converted
to the maximum jiffies timeout by the timeval_to_jiffies conversion.  It's
not clear whether this was intended or just happened to be done by the
timeval_to_jiffies code.

hrtimers expect a timeval in canonical form and treat a negative timeout as
already expired.  This breaks the legitimate usage of alarm() with a
timeout value > INT_MAX seconds.

For 32 bit machines it is therefor necessary to limit the internal seconds
value to avoid API breakage.  Instead of doing this in all implementations
of sys_alarm the duplicated sys_alarm code is moved into a common function
in itimer.c

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-03-25 08:22:48 -08:00
..
asm-offsets.c
binfmt_elfn32.c
binfmt_elfo32.c
branch.c
cpu-bugs64.c
cpu-probe.c
dma-no-isa.c
entry.S
gdb-low.S
gdb-stub.c
genex.S
head.S
i8259.c
init_task.c
irix5sys.S
irixelf.c
irixinv.c
irixioctl.c
irixsig.c
irq_cpu.c
irq-msc01.c
irq-mv6434x.c
irq-rm7000.c
irq-rm9000.c
irq.c
linux32.c
Makefile
mips_ksyms.c
module.c
proc.c
process.c
ptrace32.c
ptrace.c
r4k_fpu.S
r4k_switch.S
r2300_fpu.S
r2300_switch.S
r6000_fpu.S
reset.c
rtlx.c
scall32-o32.S
scall64-64.S
scall64-n32.S
scall64-o32.S
semaphore.c
setup.c
signal32.c
signal_n32.c
signal-common.h
signal.c
smp_mt.c
smp.c
syscall.c
sysirix.c
time.c
traps.c
unaligned.c
vmlinux.lds.S
vpe.c