mirror of
https://github.com/FEX-Emu/linux.git
synced 2025-01-08 10:30:50 +00:00
877b5691f2
The flags field in 'struct shash_desc' never actually does anything. The only ostensibly supported flag is CRYPTO_TFM_REQ_MAY_SLEEP. However, no shash algorithm ever sleeps, making this flag a no-op. With this being the case, inevitably some users who can't sleep wrongly pass MAY_SLEEP. These would all need to be fixed if any shash algorithm actually started sleeping. For example, the shash_ahash_*() functions, which wrap a shash algorithm with the ahash API, pass through MAY_SLEEP from the ahash API to the shash API. However, the shash functions are called under kmap_atomic(), so actually they're assumed to never sleep. Even if it turns out that some users do need preemption points while hashing large buffers, we could easily provide a helper function crypto_shash_update_large() which divides the data into smaller chunks and calls crypto_shash_update() and cond_resched() for each chunk. It's not necessary to have a flag in 'struct shash_desc', nor is it necessary to make individual shash algorithms aware of this at all. Therefore, remove shash_desc::flags, and document that the crypto_shash_*() functions can be called from any context. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
||
|---|---|---|
| .. | ||
| internal | ||
| acompress.h | ||
| aead.h | ||
| aes.h | ||
| akcipher.h | ||
| algapi.h | ||
| arc4.h | ||
| asym_tpm_subtype.h | ||
| authenc.h | ||
| b128ops.h | ||
| blowfish.h | ||
| cast5.h | ||
| cast6.h | ||
| cast_common.h | ||
| cbc.h | ||
| chacha.h | ||
| cryptd.h | ||
| crypto_wq.h | ||
| ctr.h | ||
| des.h | ||
| dh.h | ||
| drbg.h | ||
| ecdh.h | ||
| engine.h | ||
| gcm.h | ||
| gf128mul.h | ||
| ghash.h | ||
| hash_info.h | ||
| hash.h | ||
| hmac.h | ||
| if_alg.h | ||
| kpp.h | ||
| md5.h | ||
| morus640_glue.h | ||
| morus1280_glue.h | ||
| morus_common.h | ||
| nhpoly1305.h | ||
| null.h | ||
| padlock.h | ||
| pcrypt.h | ||
| pkcs7.h | ||
| poly1305.h | ||
| public_key.h | ||
| rng.h | ||
| scatterwalk.h | ||
| serpent.h | ||
| sha1_base.h | ||
| sha3.h | ||
| sha256_base.h | ||
| sha512_base.h | ||
| sha.h | ||
| skcipher.h | ||
| sm3_base.h | ||
| sm3.h | ||
| sm4.h | ||
| streebog.h | ||
| twofish.h | ||
| xts.h | ||