Jesper Juhl ed7809d9c4 batman-adv: Even Batman should not dereference NULL pointers
There's a problem in net/batman-adv/unicast.c::frag_send_skb().
dev_alloc_skb() allocates memory and may fail, thus returning NULL. If
this happens we'll pass a NULL pointer on to skb_split() which in turn
hands it to skb_split_inside_header() from where it gets passed to
skb_put() that lets skb_tail_pointer() play with it and that function
dereferences it. And thus the bat dies.

While I was at it I also moved the call to dev_alloc_skb() above the
assignment to 'unicast_packet' since there's no reason to do that
assignment if the memory allocation fails.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
2011-01-13 22:11:12 +01:00
..
2010-10-25 13:09:44 -07:00
2010-12-19 21:59:35 -08:00
2010-12-10 12:49:23 +01:00
2010-09-23 14:33:39 -07:00
2010-12-18 22:01:17 -08:00
2010-10-21 15:44:13 +02:00
2010-09-23 14:33:39 -07:00
2010-12-19 21:59:35 -08:00
2010-11-15 13:24:06 -05:00
2010-12-02 13:34:06 -08:00
2010-12-16 13:44:24 -08:00
2010-12-16 13:44:24 -08:00
2010-10-15 15:53:27 +02:00