linux/include
Eric Paris ef41aaa0b7 [IPSEC]: xfrm_policy delete security check misplaced
The security hooks to check permissions to remove an xfrm_policy were
actually done after the policy was removed.  Since the unlinking and
deletion are done in xfrm_policy_by* functions this moves the hooks
inside those 2 functions.  There we have all the information needed to
do the security check and it can be done before the deletion.  Since
auditing requires the result of that security check err has to be passed
back and forth from the xfrm_policy_by* functions.

This patch also fixes a bug where a deletion that failed the security
check could cause improper accounting on the xfrm_policy
(xfrm_get_policy didn't have a put on the exit path for the hold taken
by xfrm_policy_by*)

It also fixes the return code when no policy is found in
xfrm_add_pol_expire.  In old code (at least back in the 2.6.18 days) err
wasn't used before the return when no policy is found and so the
initialization would cause err to be ENOENT.  But since err has since
been used above when we don't get a policy back from the xfrm_policy_by*
function we would always return 0 instead of the intended ENOENT.  Also
fixed some white space damage in the same area.

Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Venkat Yekkirala <vyekkirala@trustedcs.com>
Acked-by: James Morris <jmorris@namei.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-03-07 16:08:09 -08:00
..
acpi
asm-alpha
asm-arm [PATCH] gpio_keys driver shouldn't be ARM-specific 2007-03-05 07:57:51 -08:00
asm-arm26
asm-avr32 avr32: dma-mapping.h 2007-03-07 10:50:30 +01:00
asm-cris
asm-frv
asm-generic Revert "[PATCH] LOG2: Alter get_order() so that it can make use of ilog2() on a constant" 2007-03-06 19:38:01 -08:00
asm-h8300
asm-i386 [PATCH] i386: make x86_64 tsc header require i386 rather than vice-versa 2007-03-06 09:30:24 -08:00
asm-ia64 [IA64] kexec: Use EFI_LOADER_DATA for ELF core header 2007-03-06 14:50:33 -08:00
asm-m32r
asm-m68k
asm-m68knommu [PATCH] m68knommu: GPIO line defines for the ColdFire 5282 2007-03-06 18:08:38 -08:00
asm-mips [MIPS] Wire up ioprio_set and ioprio_get. 2007-03-07 00:07:18 +00:00
asm-parisc
asm-powerpc [PATCH] sched: remove SMT nice 2007-03-05 07:57:51 -08:00
asm-ppc
asm-s390 [S390] check_bugs() should be inline. 2007-03-05 23:35:50 +01:00
asm-sh sh: Revert lazy dcache writeback changes. 2007-03-05 19:46:47 +09:00
asm-sh64
asm-sparc
asm-sparc64 [SPARC64]: Fix floppy build failure. 2007-03-05 13:22:28 -08:00
asm-um
asm-v850
asm-x86_64 Merge branch 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6 2007-03-06 18:05:10 -08:00
asm-xtensa
crypto
keys
linux Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2007-03-06 19:53:34 -08:00
math-emu
media
mtd
net [IPSEC]: xfrm_policy delete security check misplaced 2007-03-07 16:08:09 -08:00
pcmcia
rdma
rxrpc
scsi
sound [ALSA] version 1.0.14rc3 2007-03-06 14:10:08 +01:00
video
Kbuild