David Howells
f05ef8db1a
CRED: Fix NFSD regression
...
Fix a regression in NFSD's permission checking introduced by the credentials
patches. There are two parts to the problem, both in nfsd_setuser():
(1) The return value of set_groups() is -ve if in error, not 0, and should be
checked appropriately. 0 indicates success.
(2) The UID to use for fs accesses is in new->fsuid, not new->uid (which is
0). This causes CAP_DAC_OVERRIDE to always be set, rather than being
cleared if the UID is anything other than 0 after squashing.
Reported-by: J. Bruce Fields <bfields@fieldses.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: James Morris <jmorris@namei.org>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
2009-01-07 15:40:44 -05:00
..
2008-12-25 11:40:09 +11:00
2009-01-05 18:32:06 -08:00
2009-01-04 13:33:20 -08:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00
2008-12-31 18:07:40 -05:00
2008-11-14 10:38:47 +11:00
2009-01-05 18:32:06 -08:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00
2009-01-05 19:02:09 -08:00
2009-01-05 18:32:06 -08:00
2008-12-25 11:40:09 +11:00
2008-12-31 18:07:43 -05:00
2009-01-05 08:40:25 -08:00
2009-01-05 08:40:26 -08:00
2008-12-30 20:33:34 -08:00
2008-12-31 18:07:40 -05:00
2009-01-04 13:33:20 -08:00
2009-01-05 07:45:02 +00:00
2008-11-14 10:38:54 +11:00
2008-11-14 10:38:54 +11:00
2009-01-04 13:33:20 -08:00
2008-11-14 10:38:55 +11:00
2008-11-14 10:39:25 +11:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:53:38 -05:00
2008-11-06 22:37:59 -05:00
2009-01-05 08:40:30 -08:00
2009-01-04 13:33:20 -08:00
2009-01-05 11:54:29 -05:00
2009-01-07 15:40:44 -05:00
2008-11-14 10:38:57 +11:00
2008-11-14 10:38:58 +11:00
2009-01-04 13:33:20 -08:00
2008-12-23 15:21:32 -05:00
2009-01-07 15:40:44 -05:00
2009-01-05 11:54:29 -05:00
2009-01-05 11:54:27 -05:00
2009-01-05 18:32:43 -08:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00
2008-11-18 15:08:56 +01:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00
2009-01-05 18:32:43 -08:00
2009-01-05 11:54:28 -05:00
2009-01-04 13:33:20 -08:00
2009-01-05 11:54:28 -05:00
2008-12-31 18:07:39 -05:00
2009-01-04 13:33:20 -08:00
2008-12-04 17:16:36 +11:00
2008-11-14 10:39:04 +11:00
2008-12-29 16:47:18 +11:00
2008-12-29 08:29:50 +01:00
2008-12-31 16:55:44 +02:00
2008-11-14 10:39:05 +11:00
2008-12-31 18:07:43 -05:00
2009-01-03 11:45:54 -08:00
2008-11-14 10:39:24 +11:00
2008-12-28 12:33:21 -08:00
2008-11-14 10:39:24 +11:00
2009-01-05 11:54:28 -05:00
2008-11-14 10:39:24 +11:00
2008-12-29 08:29:23 +01:00
2008-12-29 08:29:53 +01:00
2008-12-31 18:07:43 -05:00
2009-01-04 13:33:20 -08:00
2008-11-14 10:39:24 +11:00
2008-12-31 18:07:42 -05:00
2008-12-31 18:07:38 -05:00
2009-01-05 08:40:25 -08:00
2008-12-01 19:55:24 -08:00
2009-01-05 11:54:28 -05:00
2008-12-25 11:40:09 +11:00
2008-12-31 18:07:42 -05:00
2009-01-05 11:54:29 -05:00
2009-01-05 11:54:28 -05:00
2008-11-14 10:39:24 +11:00
2009-01-05 07:38:46 +00:00
2008-11-14 10:39:19 +11:00
2009-01-05 08:40:23 -08:00
2009-01-05 18:32:06 -08:00
2008-11-14 10:39:05 +11:00
2009-01-05 08:40:21 -08:00
2009-01-05 18:32:06 -08:00
2008-12-31 18:07:38 -05:00
2008-12-31 18:07:41 -05:00
2009-01-05 11:54:28 -05:00
2009-01-04 15:14:41 -05:00
2008-11-14 10:39:05 +11:00
2009-01-05 08:40:21 -08:00
2009-01-05 08:40:21 -08:00
2009-01-05 08:36:58 -08:00
2009-01-05 08:40:21 -08:00
2009-01-05 08:36:57 -08:00
2009-01-05 08:36:58 -08:00
2009-01-05 08:40:21 -08:00
2009-01-05 11:53:07 -05:00
2008-10-26 11:22:08 -07:00
2009-01-03 12:04:39 -08:00
2008-10-30 11:38:45 -07:00
2009-01-05 11:54:28 -05:00
2008-12-20 09:02:39 +11:00
2009-01-05 11:54:28 -05:00
2009-01-05 11:54:28 -05:00