mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-29 21:05:13 +00:00
0287587884
Testing xmit_more support with netperf and connected UDP sockets, I found strange dst refcount false sharing. Current handling of IFF_XMIT_DST_RELEASE is not optimal. Dropping dst in validate_xmit_skb() is certainly too late in case packet was queued by cpu X but dequeued by cpu Y The logical point to take care of drop/force is in __dev_queue_xmit() before even taking qdisc lock. As Julian Anastasov pointed out, need for skb_dst() might come from some packet schedulers or classifiers. This patch adds new helper to cleanly express needs of various drivers or qdiscs/classifiers. Drivers that need skb_dst() in their ndo_start_xmit() should call following helper in their setup instead of the prior : dev->priv_flags &= ~IFF_XMIT_DST_RELEASE; -> netif_keep_dst(dev); Instead of using a single bit, we use two bits, one being eventually rebuilt in bonding/team drivers. The other one, is permanent and blocks IFF_XMIT_DST_RELEASE being rebuilt in bonding/team. Eventually, we could add something smarter later. Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Julian Anastasov <ja@ssi.bg> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
---|---|---|
.. | ||
addr.c | ||
addr.h | ||
atm_misc.c | ||
atm_sysfs.c | ||
br2684.c | ||
clip.c | ||
common.c | ||
common.h | ||
ioctl.c | ||
Kconfig | ||
lec_arpc.h | ||
lec.c | ||
lec.h | ||
Makefile | ||
mpc.c | ||
mpc.h | ||
mpoa_caches.c | ||
mpoa_caches.h | ||
mpoa_proc.c | ||
pppoatm.c | ||
proc.c | ||
protocols.h | ||
pvc.c | ||
raw.c | ||
resources.c | ||
resources.h | ||
signaling.c | ||
signaling.h | ||
svc.c |