mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-22 01:10:28 +00:00
daeeafecf0
Calling a notifier three times in the debug handler does not make much sense,
because a debugger can figure out the various conditions by itself. Remove
the additional calls to DIE_DEBUG and DIE_DEBUGSTEP completely.
This matches what i386 does now.
This also makes sure interrupts are always still disabled when calling a
debugger, which prevents:
BUG: using smp_processor_id() in preemptible [00000001] code: tpopf/1470
caller is post_kprobe_handler+0x9/0x70
Call Trace:<ffffffff8024f10f>{smp_processor_id+191} <ffffffff80120e69>{post_kpro
be_handler+9}
<ffffffff80120f7a>{kprobe_exceptions_notify+58}
<ffffffff80144fc0>{notifier_call_chain+32} <ffffffff80110daf>{do_debug+335}
<ffffffff8010f513>{debug+127} <EOE>
on preemptible debug kernels with kprobes when single stepping in user space.
This was probably a bug even on non preempt kernels, this function was
supposed to be running with interrupts off according to a comment there.
Note to third part debugger maintainers: please double check your debugger can
still single step.
Cc: <prasanna@in.ibm.com>
Cc: <jbeulich@novell.com>
Cc: <kaos@sgi.com>
Cc: <jim.houston@ccur.com>
Cc: <jfv@bluesong.net>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
|
||
|---|---|---|
| .. | ||
| acpi | ||
| cpufreq | ||
| aperture.c | ||
| apic.c | ||
| asm-offsets.c | ||
| e820.c | ||
| early_printk.c | ||
| entry.S | ||
| genapic_cluster.c | ||
| genapic_flat.c | ||
| genapic.c | ||
| head64.c | ||
| head.S | ||
| i387.c | ||
| i8259.c | ||
| init_task.c | ||
| io_apic.c | ||
| ioport.c | ||
| irq.c | ||
| kprobes.c | ||
| ldt.c | ||
| Makefile | ||
| mce_intel.c | ||
| mce.c | ||
| module.c | ||
| mpparse.c | ||
| msr.c | ||
| nmi.c | ||
| pci-dma.c | ||
| pci-gart.c | ||
| pci-nommu.c | ||
| process.c | ||
| ptrace.c | ||
| reboot.c | ||
| semaphore.c | ||
| setup64.c | ||
| setup.c | ||
| signal.c | ||
| smp.c | ||
| smpboot.c | ||
| suspend_asm.S | ||
| suspend.c | ||
| sys_x86_64.c | ||
| syscall.c | ||
| time.c | ||
| trampoline.S | ||
| traps.c | ||
| vmlinux.lds.S | ||
| vsyscall.c | ||
| x8664_ksyms.c | ||