linux

mirror of https://github.com/FEX-Emu/linux.git synced 2025-01-15 06:00:41 +00:00

History

Herbert Xu 1f770c0a09 netlink: Fix autobind race condition that leads to zero port ID

The commit c0bb07df7d981e4091432754e30c9c720e2c0c78 ("netlink:
Reset portid after netlink_insert failure") introduced a race
condition where if two threads try to autobind the same socket
one of them may end up with a zero port ID.  This led to kernel
deadlocks that were observed by multiple people.

This patch reverts that commit and instead fixes it by introducing
a separte rhash_portid variable so that the real portid is only set
after the socket has been successfully hashed.

Fixes: c0bb07df7d98 ("netlink: Reset portid after netlink_insert failure")
Reported-by: Tejun Heo <tj@kernel.org>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

2015-09-20 22:55:31 -07:00

af_netlink.c

netlink: Fix autobind race condition that leads to zero port ID

2015-09-20 22:55:31 -07:00

af_netlink.h

netlink: Fix autobind race condition that leads to zero port ID

2015-09-20 22:55:31 -07:00

diag.c

netlink: make nlmsg_end() and genlmsg_end() void

2015-01-18 01:03:45 -05:00

genetlink.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net