Frederic Weisbecker fc3b86d673 perf: Roll back callchain buffer refcount under the callchain mutex ... When we fail to allocate the callchain buffers, we roll back the refcount we did and return from get_callchain_buffers(). However we take the refcount and allocate under the callchain lock but the rollback is done outside the lock. As a result, while we roll back, some concurrent callchain user may call get_callchain_buffers(), see the non-zero refcount and give up because the buffers are NULL without itself retrying the allocation. The consequences aren't that bad but that behaviour looks weird enough and it's better to give their chances to the following callchain users where we failed. Reported-by: Jiri Olsa <jolsa@redhat.com> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Stephane Eranian <eranian@google.com> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1375460996-16329-2-git-send-email-fweisbec@gmail.com Signed-off-by: Ingo Molnar <mingo@kernel.org>		2013-08-16 17:55:50 +02:00
..
callchain.c	perf: Roll back callchain buffer refcount under the callchain mutex	2013-08-16 17:55:50 +02:00
core.c	perf: Do not get values from disabled counters in group format read	2013-08-07 17:35:19 -03:00
hw_breakpoint.c	hw_breakpoint: Introduce "struct bp_cpuinfo"	2013-06-20 17:58:57 +02:00
internal.h	perf: Fix mmap() accounting hole	2013-06-19 12:44:13 +02:00
Makefile	uprobes: Move to kernel/events/	2012-02-22 11:08:00 +01:00
ring_buffer.c	perf: Fix vmalloc ring buffer pages handling	2013-05-01 12:34:46 +02:00
uprobes.c	uretprobes: Remove -ENOSYS as return probes implemented	2013-04-13 15:31:58 +02:00