mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-18 23:18:20 +00:00
5336377d62
With all the recent module loading cleanups, we've minimized the code
that sits under module_mutex, fixing various deadlocks and making it
possible to do most of the module loading in parallel.
However, that whole conversion totally missed the rather obscure code
that adds a new module to the list for BUG() handling. That code was
doubly obscure because (a) the code itself lives in lib/bugs.c (for
dubious reasons) and (b) it gets called from the architecture-specific
"module_finalize()" rather than from generic code.
Calling it from arch-specific code makes no sense what-so-ever to begin
with, and is now actively wrong since that code isn't protected by the
module loading lock any more.
So this commit moves the "module_bug_{finalize,cleanup}()" calls away
from the arch-specific code, and into the generic code - and in the
process protects it with the module_mutex so that the list operations
are now safe.
Future fixups:
- move the module list handling code into kernel/module.c where it
belongs.
- get rid of 'module_bug_list' and just use the regular list of modules
(called 'modules' - imagine that) that we already create and maintain
for other reasons.
Reported-and-tested-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
||
|---|---|---|
| .. | ||
| vdso32 | ||
| vdso64 | ||
| asm-offsets.c | ||
| audit.c | ||
| audit.h | ||
| base.S | ||
| bitmap.c | ||
| compat_audit.c | ||
| compat_exec_domain.c | ||
| compat_linux.c | ||
| compat_linux.h | ||
| compat_ptrace.h | ||
| compat_signal.c | ||
| compat_wrapper.S | ||
| cpcmd.c | ||
| crash.c | ||
| debug.c | ||
| diag.c | ||
| dis.c | ||
| early.c | ||
| ebcdic.c | ||
| entry64.S | ||
| entry.h | ||
| entry.S | ||
| ftrace.c | ||
| head31.S | ||
| head64.S | ||
| head.S | ||
| init_task.c | ||
| ipl.c | ||
| irq.c | ||
| kprobes.c | ||
| machine_kexec.c | ||
| Makefile | ||
| mcount64.S | ||
| mcount.S | ||
| mem_detect.c | ||
| module.c | ||
| nmi.c | ||
| process.c | ||
| processor.c | ||
| ptrace.c | ||
| reipl64.S | ||
| reipl.S | ||
| relocate_kernel64.S | ||
| relocate_kernel.S | ||
| s390_ext.c | ||
| s390_ksyms.c | ||
| sclp.S | ||
| setup.c | ||
| signal.c | ||
| smp.c | ||
| stacktrace.c | ||
| suspend.c | ||
| switch_cpu64.S | ||
| switch_cpu.S | ||
| swsusp_asm64.S | ||
| sys_s390.c | ||
| syscalls.S | ||
| sysinfo.c | ||
| time.c | ||
| topology.c | ||
| traps.c | ||
| vdso.c | ||
| vmlinux.lds.S | ||
| vtime.c | ||