Game-Decompilation/2ship2harkinian
1
0
Fork 0
mirror of https://github.com/HarbourMasters/2ship2harkinian.git synced 2024-11-27 00:00:32 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

properly array bounds check the font table (#32)

Browse Source
This commit is contained in:
Archez 2024-01-12 19:00:24 -05:00 committed by Garrett Cox
parent 248539479d
commit 6e0cef8fa0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mm/src/code/z_kanfont.c
View File

@ -181,8 +181,9 @@ void Font_LoadCharNES(PlayState* play, u8 codePointIndex, s32 offset) {
int fontIdx = codePointIndex - 0x20;
if (codePointIndex < 0x8B)
if (fontIdx >= 0 && fontIdx < ARRAY_COUNT(fontTbl)) {
memcpy(&font->charBuf[font->unk_11D88][offset], fontTbl[fontIdx], strlen(fontTbl[fontIdx]) + 1);
}
// DmaMgr_SendRequest0(&font->charBuf[font->unk_11D88][offset],
//&((u8*)SEGMENT_ROM_START(nes_font_static))[(codePointIndex - ' ') * FONT_CHAR_TEX_SIZE],