Game-Decompilation/OdysseyDecomp
1
0
Fork 0
mirror of https://github.com/MonsterDruide1/OdysseyDecomp.git synced 2024-11-26 23:00:25 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

lint: Remove this-> prefix (#102)

Browse Source
This commit is contained in:
GRAnimated 2024-06-20 13:53:29 -04:00 committed by GitHub
parent 88a54e47f4
commit 4ae60d7b12
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/al/Library/Base/StringUtil.h
View File

@ -41,7 +41,7 @@ public:
StringTmp(const char* format, ...) : sead::FixedSafeString<L>() {
std::va_list args;
va_start(args, format);
this->formatV(format, args);
sead::FixedSafeString<L>::formatV(format, args);
va_end(args);
}
~StringTmp() = default;

2
lib/al/Library/Layout/LayoutActor.cpp
View File

@ -13,7 +13,7 @@ void LayoutActor::appear() {
if (mLayoutPartsActorKeeper)
mLayoutPartsActorKeeper->appear();
updateLayoutPaneRecursive(this);
this->calcAnim(false);
calcAnim(false);
}
void LayoutActor::initLayoutPartsActorKeeper(s32 capacity) {
mLayoutPartsActorKeeper = new LayoutPartsActorKeeper(capacity);

6
lib/al/Library/LiveActor/LiveActorGroup.cpp
View File

@ -10,9 +10,9 @@ LiveActorGroup::LiveActorGroup(const char* groupName, s32 maxActors)
}
s32 LiveActorGroup::registerActor(LiveActor* pActor) {
this->mActors[this->mActorCount] = pActor;
auto count = this->mActorCount;
this->mActorCount = count + 1;
mActors[mActorCount] = pActor;
auto count = mActorCount;
mActorCount = count + 1;
return count;
}

4
src/MapObj/AnagramAlphabetCharacter.cpp
View File

@ -127,7 +127,7 @@ void AnagramAlphabetCharacter::exeHackWait() {
al::setNerve(this, &NrvAnagramAlphabetCharacter.HackGoal);
else {
if (!rs::updateJudgeAndResult((IJudge*)this->mHackerJudgeStartRun))
if (!rs::updateJudgeAndResult((IJudge*)mHackerJudgeStartRun))
return;
al::setNerve(this, &NrvAnagramAlphabetCharacter.HackMove);
}
@ -182,7 +182,7 @@ void AnagramAlphabetCharacter::exeHackGoal() {
if (al::isGreaterEqualStep(this, 0LL))
return;
al::updatePoseMtx(this, unkMtx);
rs::endHackDir(&this->mHackerParent, rot);
rs::endHackDir(&mHackerParent, rot);
al::validateClipping(this);
al::setNerve(this, &NrvAnagramAlphabetCharacter.Wait);
mCapTargetParts->startNormal();

2
src/Sequence/HakoniwaSequence.h
View File

@ -26,7 +26,7 @@ public:
void update();
bool isEnableSave();
void drawMain();
al::Scene* getCurrentScene(); // {return this->curScene}
al::Scene* getCurrentScene(); // {return curScene}
u8** field_0x0;
u8 padding_120[120];

7
tools/check-format.py
View File

@ -211,6 +211,11 @@ def common_const_type(c, path):
continue
index += 1
def common_this_prefix(c, path):
for line in c.splitlines():
if 'this->' in line:
FAIL("this-> is not allowed!", line, path)
# Header files
def header_sorted_visibility(c, path):
@ -325,6 +330,7 @@ def check_source(c, path):
common_sead_types(c, path)
common_void_params(c, path)
common_const_type(c, path)
common_this_prefix(c, path)
def check_header(c, path):
common_newline_eof(c, path)
@ -335,6 +341,7 @@ def check_header(c, path):
common_const_type(c, path)
header_sorted_visibility(c, path)
header_no_offset_comments(c, path)
common_this_prefix(c, path)
def check_file(file_str):
file = open(file_str, mode="r")