Game-Decompilation/botw
1
0
Fork 0
mirror of https://github.com/zeldaret/botw.git synced 2024-11-30 08:31:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

contributing: Drop #ifdef NON_MATCHING requirement

Browse Source
This commit is contained in:
Léo Lam 2021-12-31 19:24:15 +01:00
parent f74f3046e2
commit b4f29aa59c
No known key found for this signature in database
GPG Key ID: 0DF30F9081000741
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Contributing.md
View File

@ -99,7 +99,7 @@ CLion interacts with CMake directly, so you need to make sure CLion's build prof
8. **Update the list of decompiled functions**.
* If you have a function that matches perfectly, great!
* If there are still minor differences left, wrap the function in an `#ifdef NON_MATCHING`, add a comment to explain what is wrong, and change the status (the second column) to `m` (minor difference) in the CSV.
* If there are still minor differences left, write a comment to explain what is wrong (if you think that is necessary), and change the status (the second column) to `m` (minor difference) in the CSV.
* For major differences (lots of entirely red/green/blue lines in the diff), use a capital `M` (major difference) in place of `m`.
9. Before opening a PR, reformat the code with clang-format and run `tools/check`.