Game-Decompilation/fireemblem8u
1
0
Fork 0
mirror of https://github.com/FireEmblemUniverse/fireemblem8u.git synced 2025-02-21 13:33:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix compilation failure of textencode in tools under the latest MSYS2 environment (gcc 13.3.0).

Browse Source 
Changed the parameters of is* functions (isdigit and isspace) in <ctype.h> from char to uint8_t. These functions require int parameters, and passing char can cause warnings in some compiler versions. Since -Werror is enabled, warnings are treated as errors (error: array subscript has type ‘char’ [-Werror=char-subscripts]), leading to compilation failure. Using uint8_t, which is automatically converted to int, prevents these warnings.
This commit is contained in:
Sun Daowen 2024-05-27 22:46:11 +08:00
parent ad40f18155
commit 8f311c40e7
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/textencode/inputfile.c
View File

@ -197,7 +197,7 @@ static void expand_control_codes(char *src, char *dest)
case '[': // control code
src++;
if (isdigit(*src)) // raw number
if (isdigit((uint8_t)*src)) // raw number
{
int value;
@ -262,7 +262,7 @@ char *skip_whitespace_and_comments(char *str)
while (1)
{
if (isspace(*str))
if (isspace((uint8_t)*str))
{
if (*str == '\n')
{
@ -294,7 +294,7 @@ char *skip_whitespace_and_comments(char *str)
// skips all whitespace until a newline char or non-whitespace char is encountered
char *skip_whitespace_no_newline(char *str)
{
while (isspace(*str))
while (isspace((uint8_t)*str))
{
if (*str == '\n')
break;
@ -315,7 +315,7 @@ char *parse_ctrlcode_def(char *str)
// identifier
identStart = str;
if (isdigit(*str))
if (isdigit((uint8_t)*str))
syntax_error("identifier cannot start with digit");
while (is_valid_ctrlcode_id_char(*str))
str++;
@ -374,7 +374,7 @@ char *parse_string_entry(char *str)
// identifier
identStart = str;
if (isdigit(*str))
if (isdigit((uint8_t)*str))
syntax_error("identifier cannot start with digit");
while (is_valid_string_id_char(*str))
str++;