ci: dont bother installing rosetta 2

.github/workflows/macos-build-arm.yaml

@@ -20,11 +20,8 @@ jobs:
       - name: Checkout Repository
         uses: actions/checkout@v4
 
-      - name: Set up ARM64 environment
-        run: sudo softwareupdate --install-rosetta --agree-to-license
-
       - name: Install Package Dependencies
-        run: arch -arm64 brew install cmake ninja
+        run: brew install cmake ninja
 
       - name: Setup sccache
         uses: hendrikmuhs/ccache-action@v1.2.14

common/util/os.cpp

@@ -125,7 +125,7 @@ std::optional<double> get_macos_version() {
   }
   try {
     return std::stod(buffer);
-  } catch (std::exception e) {
+  } catch (std::exception& e) {
     lg::error("Error occured when attempting to convert sysctl value {} to number", buffer);
     return {};
   }