Game-Decompilation/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project.git synced 2024-11-27 00:10:31 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

extractor: add error code messages around 3990 (#3699)
Some checks are pending
Build / 🖥️ Windows (push) Waiting to run
Details
Build / 🐧 Linux (push) Waiting to run
Details
Build / 🍎 MacOS (push) Waiting to run
Details
Lint / 📝 Formatting (push) Waiting to run
Details
Lint / 📝 Required Checks (push) Waiting to run
Details
Lint / 📝 Optional Checks (push) Waiting to run
Details

Browse Source 
Also added a new error code to make invalid folder paths hopefully more
clear/obvious.
This commit is contained in:
Tyler Wilding 2024-10-05 01:45:29 -04:00 committed by GitHub
parent cb4f7772bb
commit eb544bcfc0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/scripts/releases/error-code-metadata.json vendored
View File

@ -1,4 +1,10 @@
{
"3990": {
"msg": "Provided invalid or missing arguments"
},
"3991": {
"msg": "Input path(s) do not exist"
},
"4000": {
"msg": "Validation Failed: Cannot locate ELF"
},

1
decompiler/extractor/extractor_util.h
View File

@ -12,6 +12,7 @@
enum class ExtractorErrorCode {
SUCCESS = 0,
INVALID_CLI_INPUT = 3990,
INVALID_CLI_INPUT_MISSING_FOLDER = 3991,
VALIDATION_CANT_LOCATE_ELF = 4000,
VALIDATION_SERIAL_MISSING_FROM_DB = 4001,
VALIDATION_ELF_MISSING_FROM_DB = 4002,

6
decompiler/extractor/main.cpp
View File

@ -225,7 +225,7 @@ int main(int argc, char** argv) {
if (!project_path_override.empty()) {
if (!fs::exists(project_path_override)) {
lg::error("Error: project path override '{}' does not exist", project_path_override.string());
return static_cast<int>(ExtractorErrorCode::INVALID_CLI_INPUT);
return static_cast<int>(ExtractorErrorCode::INVALID_CLI_INPUT_MISSING_FOLDER);
}
auto ok = file_util::setup_project_path(project_path_override);
if (!ok) {
@ -255,7 +255,7 @@ int main(int argc, char** argv) {
// - INPUT VALIDATION
if (!fs::exists(input_file_path)) {
lg::error("Error: input game file path '{}' does not exist", input_file_path.string());
return static_cast<int>(ExtractorErrorCode::INVALID_CLI_INPUT);
return static_cast<int>(ExtractorErrorCode::INVALID_CLI_INPUT_MISSING_FOLDER);
}
if (data_subfolders.count(game_name) == 0) {
lg::error("Error: input game name '{}' is not valid", game_name);
@ -325,7 +325,7 @@ int main(int argc, char** argv) {
} else if (fs::is_directory(input_file_path)) {
if (!flag_folder) {
// if we didn't request a folder explicitly, but we got one, assume something went wrong.
lg::error("got a folder, but didn't get folder flag");
lg::error("got a folder, but didn't provide the folder flag");
return static_cast<int>(ExtractorErrorCode::INVALID_CLI_INPUT);
}
iso_data_path = input_file_path;